Re: x25_create initializing socket data twice ...

2005-03-03 Thread Aristeu Sergio Rozanski Filho
Hi, > On the same path sk_set_owner also gets called twice, I think this > causes double module use count when creating sockets. Module use count > need some attention all over x25. I'm working on it already. I hope to send patches soon. Is linux-x25 list alive? if not, perhaps we should add netde

Re: x25_create initializing socket data twice ...

2005-03-02 Thread Andrew Hendry
Hi Herbert, On the same path sk_set_owner also gets called twice, I think this causes double module use count when creating sockets. Module use count need some attention all over x25. Im not sure if the fix is as straightforward, the calls are: sock_init_data(sock,sk) vs sock_init_data(NULL,sk)

x25_create initializing socket data twice ...

2005-03-02 Thread Herbert Poetzl
Hi Folks! x25_create() [net/x25/af_x25.c] is calling sock_init_data() twice ... once indirectly via x25_alloc_socket() and a second time directly via sock_init_data(sock, sk); while this might not look as critical as it seems, it can easily break stuff which assumes that sock_init_data() isn't c