Re: [PATCH] mfd: cros_ec: Avoid unneeded internal declaration warning

2018-10-09 Thread Stephen Boyd
Quoting Nathan Chancellor (2018-09-27 18:16:14) > On Wed, Sep 26, 2018 at 08:33:17PM -0700, Nathan Chancellor wrote: > > diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c > > index 999dac752bcc..8f9d6964173e 100644 > > --- a/drivers/mfd/cros_ec_dev.c > > +++ b/drivers/mfd/cros_ec_d

Re: [PATCH] mfd: cros_ec: Avoid unneeded internal declaration warning

2018-10-09 Thread Lee Jones
On Thu, 27 Sep 2018, Nathan Chancellor wrote: > On Wed, Sep 26, 2018 at 08:33:17PM -0700, Nathan Chancellor wrote: > > Clang warns: > > > > drivers/mfd/cros_ec_dev.c:509:40: warning: variable 'cros_ec_id' is not > > needed and will not be emitted [-Wunneeded-internal-declaration] > > static const

Re: [PATCH] staging: bcm2835-camera: Avoid unneeded internal declaration warning

2018-09-28 Thread Nathan Chancellor
On Fri, Sep 28, 2018 at 10:04:29AM +0100, Dave Stevenson wrote: > Hi Nate > > Thanks for the patch. > > On Fri, 28 Sep 2018 at 01:53, Nathan Chancellor > wrote: > > > > Clang warns: > > > > drivers/staging/vc04_services/bcm2835-camera/controls.c:59:18: warning: > > variable 'mains_freq_qmenu' is

Re: [PATCH] staging: bcm2835-camera: Avoid unneeded internal declaration warning

2018-09-28 Thread Dave Stevenson
Hi Nate Thanks for the patch. On Fri, 28 Sep 2018 at 01:53, Nathan Chancellor wrote: > > Clang warns: > > drivers/staging/vc04_services/bcm2835-camera/controls.c:59:18: warning: > variable 'mains_freq_qmenu' is not needed and will not be emitted > [-Wunneeded-internal-declaration] > static const

Re: [PATCH] mfd: cros_ec: Avoid unneeded internal declaration warning

2018-09-27 Thread Nathan Chancellor
On Wed, Sep 26, 2018 at 08:33:17PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/mfd/cros_ec_dev.c:509:40: warning: variable 'cros_ec_id' is not > needed and will not be emitted [-Wunneeded-internal-declaration] > static const struct platform_device_id cros_ec_id[] = { >

[PATCH] staging: bcm2835-camera: Avoid unneeded internal declaration warning

2018-09-27 Thread Nathan Chancellor
Clang warns: drivers/staging/vc04_services/bcm2835-camera/controls.c:59:18: warning: variable 'mains_freq_qmenu' is not needed and will not be emitted [-Wunneeded-internal-declaration] static const s64 mains_freq_qmenu[] = { ^ 1 warning generated. This is because mains_freq_qmenu

[PATCH] mfd: cros_ec: Avoid unneeded internal declaration warning

2018-09-26 Thread Nathan Chancellor
Clang warns: drivers/mfd/cros_ec_dev.c:509:40: warning: variable 'cros_ec_id' is not needed and will not be emitted [-Wunneeded-internal-declaration] static const struct platform_device_id cros_ec_id[] = { ^ 1 warning generated. Avoid this warning by adding

Re: unneeded internal declaration

2017-09-27 Thread Paolo Bonzini
On 27/09/2017 14:39, Avi Ghosh wrote: > Can someone remove me form this thread. I don’t know why I’m on it. Because you are a...@redhat.com, which belonged to Avi Kivity before you. In any case, no one can "remove you from this thread". Everyone involved would have to remember to remove you from

Re: unneeded internal declaration

2017-09-27 Thread Paolo Bonzini
On 26/09/2017 05:07, Nick Desaulniers wrote: > today I noticed I was getting the warning: > > arch/x86/kvm/vmx.c:64:32: warning: variable 'vmx_cpu_id' is not needed > and will not be emitted [-Wunneeded-internal-declaration] > > seems like this was added in commit: e9bda3b3d0ce7 "KVM: VMX: > Auto

Re: unneeded internal declaration

2017-09-25 Thread Nick Desaulniers
Good find, will send a patch with your suggestion. The documentation for x86_match_cpu() says: 25 * Arrays used to match for this should also be declared using 26 * MODULE_DEVICE_TABLE(x86cpu, ...) Will save another patch for a friend, then. On Mon, Sep 25, 2017 at 8:35 PM, Josh Triplett w

Re: unneeded internal declaration

2017-09-25 Thread Josh Triplett
On Mon, Sep 25, 2017 at 08:07:41PM -0700, Nick Desaulniers wrote: > today I noticed I was getting the warning: > > arch/x86/kvm/vmx.c:64:32: warning: variable 'vmx_cpu_id' is not needed > and will not be emitted [-Wunneeded-internal-declaration] > > seems like this was added in commit: e9bda3b3d0

unneeded internal declaration

2017-09-25 Thread Nick Desaulniers
today I noticed I was getting the warning: arch/x86/kvm/vmx.c:64:32: warning: variable 'vmx_cpu_id' is not needed and will not be emitted [-Wunneeded-internal-declaration] seems like this was added in commit: e9bda3b3d0ce7 "KVM: VMX: Auto-load on CPUs with VMX" seems like other call sites of the