Re: uml and -regparm=3

2008-01-10 Thread Ingo Molnar
* Miklos Szeredi <[EMAIL PROTECTED]> wrote: > Thanks. Patch works, but needed to add asmregparm to the definitions > as well, plus added default define into (updated > patch below). thanks, applied. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

Re: uml and -regparm=3

2008-01-10 Thread Miklos Szeredi
> * Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > > FASTCALL is defined empty in -mm, but UML is not compiled with > > -mregparm=3 and so this breaks things (I noticed problems with > > rwsem_down_write_failed). > > > > Tried recompiling UML with -mregparm=3, but that resulted in a strange > >

Re: uml and -regparm=3

2008-01-09 Thread Ingo Molnar
* Miklos Szeredi <[EMAIL PROTECTED]> wrote: > FASTCALL is defined empty in -mm, but UML is not compiled with > -mregparm=3 and so this breaks things (I noticed problems with > rwsem_down_write_failed). > > Tried recompiling UML with -mregparm=3, but that resulted in a strange > failure immedi

Re: uml and -regparm=3

2008-01-09 Thread H. Peter Anvin
Andi Kleen wrote: On Wed, Jan 09, 2008 at 09:14:04PM -0500, Jeff Dike wrote: On Wed, Jan 09, 2008 at 10:50:48PM +0100, Miklos Szeredi wrote: FASTCALL is useless and should not make a difference. It enables regparm on specific functions, but that should not make a difference if it works or not.

Re: uml and -regparm=3

2008-01-09 Thread Andi Kleen
On Wed, Jan 09, 2008 at 09:14:04PM -0500, Jeff Dike wrote: > On Wed, Jan 09, 2008 at 10:50:48PM +0100, Miklos Szeredi wrote: > > > FASTCALL is useless and should not make a difference. It enables > > > regparm on specific functions, but that should not make a difference > > > if it works or not. >

Re: uml and -regparm=3

2008-01-09 Thread Jeff Dike
On Wed, Jan 09, 2008 at 10:50:48PM +0100, Miklos Szeredi wrote: > > FASTCALL is useless and should not make a difference. It enables > > regparm on specific functions, but that should not make a difference > > if it works or not. > > __down_write() in include/asm-x86/rwsem.h seems to assume, that

Re: uml and -regparm=3

2008-01-09 Thread linux-os (Dick Johnson)
On Wed, 9 Jan 2008, Miklos Szeredi wrote: > FASTCALL is defined empty in -mm, but UML is not compiled with > -mregparm=3 and so this breaks things (I noticed problems with > rwsem_down_write_failed). > > Tried recompiling UML with -mregparm=3, but that resulted in a strange > failure immediately

Re: uml and -regparm=3

2008-01-09 Thread Miklos Szeredi
> FASTCALL is useless and should not make a difference. It enables > regparm on specific functions, but that should not make a difference > if it works or not. __down_write() in include/asm-x86/rwsem.h seems to assume, that the semaphore pointer is passed in %eax down to rwsem_down_write_failed(),

Re: uml and -regparm=3

2008-01-09 Thread Adrian Bunk
On Wed, Jan 09, 2008 at 10:20:49PM +0100, Miklos Szeredi wrote: > > Miklos Szeredi <[EMAIL PROTECTED]> writes: > > > > > FASTCALL is defined empty in -mm, but UML is not compiled with > > > -mregparm=3 and so this breaks things (I noticed problems with > > > rwsem_down_write_failed). > > > > > > T

Re: uml and -regparm=3

2008-01-09 Thread Andi Kleen
On Wed, Jan 09, 2008 at 10:20:49PM +0100, Miklos Szeredi wrote: > > Miklos Szeredi <[EMAIL PROTECTED]> writes: > > > > > FASTCALL is defined empty in -mm, but UML is not compiled with > > > -mregparm=3 and so this breaks things (I noticed problems with > > > rwsem_down_write_failed). > > > > > > T

Re: uml and -regparm=3

2008-01-09 Thread Miklos Szeredi
> Miklos Szeredi <[EMAIL PROTECTED]> writes: > > > FASTCALL is defined empty in -mm, but UML is not compiled with > > -mregparm=3 and so this breaks things (I noticed problems with > > rwsem_down_write_failed). > > > > Tried recompiling UML with -mregparm=3, but that resulted in a strange > > fail

Re: uml and -regparm=3

2008-01-09 Thread Andi Kleen
Miklos Szeredi <[EMAIL PROTECTED]> writes: > FASTCALL is defined empty in -mm, but UML is not compiled with > -mregparm=3 and so this breaks things (I noticed problems with > rwsem_down_write_failed). > > Tried recompiling UML with -mregparm=3, but that resulted in a strange > failure immediately

uml and -regparm=3

2008-01-09 Thread Miklos Szeredi
FASTCALL is defined empty in -mm, but UML is not compiled with -mregparm=3 and so this breaks things (I noticed problems with rwsem_down_write_failed). Tried recompiling UML with -mregparm=3, but that resulted in a strange failure immediately after startup: |%G�%@: Invalid argument What's up