Re: tty_[un]register_devfs putting 3K structures on the stack

2000-10-16 Thread Jeff Dike
[EMAIL PROTECTED] said: > If the problem only impacts User-mode Linux, it's hard for me to justify > hanging the "critical" label on it. However I'm willing to look at the > patch, bless it, and send it on to Linus Below is the patch to rid tty_register_devfs and tty_unregister_devfs of the tty

Re: tty_[un]register_devfs putting 3K structures on the stack

2000-10-12 Thread Jeff Dike
> If the problem only impacts User-mode Linux, it's hard for me to > justify > hanging the "critical" label on it. However I'm willing to look at > the > patch, bless it, and send it on to Linus (who as you know sometimes is > a > softy about such things. :-) I wasn't considering it a possi

Re: tty_[un]register_devfs putting 3K structures on the stack

2000-10-11 Thread Alan Cox
> If the problem only impacts User-mode Linux, it's hard for me to justify > hanging the "critical" label on it. However I'm willing to look at the > patch, bless it, and send it on to Linus (who as you know sometimes is a > softy about such things. :-) > > I'm pretty sure that we'd be able

Re: tty_[un]register_devfs putting 3K structures on the stack

2000-10-11 Thread tytso
Date: Fri, 06 Oct 2000 16:22:11 -0500 From: Jeff Dike <[EMAIL PROTECTED]> [EMAIL PROTECTED] said: > And it's allocating a tty_struct for a really dumb reason, too. It's > just using it so it cna call tty_name. > Just replace the call to tty_name with something like this: >

Re: tty_[un]register_devfs putting 3K structures on the stack

2000-10-06 Thread Jeff Dike
[EMAIL PROTECTED] said: > And it's allocating a tty_struct for a really dumb reason, too. It's > just using it so it cna call tty_name. > Just replace the call to tty_name with something like this: > sprintf(buf, driver->name, idx + driver->name_base) > and make the obvious change to avo

Re: tty_[un]register_devfs putting 3K structures on the stack

2000-10-06 Thread Theodore Y. Ts'o
Date:Fri, 06 Oct 2000 12:01:34 -0500 From: Jeff Dike <[EMAIL PROTECTED]> tty_register_devfs and tty_unregister_devfs both declare "struct tty_struct" locals. According to gdb: (gdb) p sizeof(struct tty_struct) $20 = 3084 This eats up most of a 4K page, and on UML t

tty_[un]register_devfs putting 3K structures on the stack

2000-10-06 Thread Jeff Dike
tty_register_devfs and tty_unregister_devfs both declare "struct tty_struct" locals. According to gdb: (gdb) p sizeof(struct tty_struct) $20 = 3084 This eats up most of a 4K page, and on UML this is causing the stack to flow off the page for some people. Is it possible to make that tty_struct