Re: tty OOPS (Re: 2.6.21-rc5-mm2)

2007-03-29 Thread Maneesh Soni
On Wed, Mar 28, 2007 at 01:07:56PM -0700, Andrew Morton wrote: > On Wed, 28 Mar 2007 22:56:32 +0400 > Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > > > On Wed, Mar 28, 2007 at 10:38:14PM +0400, Alexey Dobriyan wrote: > > > On Wed, Mar 28, 2007 at 08:04:46PM +0200, Andreas Mohr wrote: > > > > [unrel

Re: [FIXED] Re: tty OOPS (Re: 2.6.21-rc5-mm2)

2007-03-28 Thread Ethan Solomita
Apologies -- I didn't notice lkml on the cc list. I'll catch up from lkml directly. -- Ethan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please rea

Re: [FIXED] Re: tty OOPS (Re: 2.6.21-rc5-mm2)

2007-03-28 Thread Ethan Solomita
Andreas Mohr wrote: Hi, On Wed, Mar 28, 2007 at 10:56:32PM +0400, Alexey Dobriyan wrote: The only suspicious new patch in -rc5-mm1 to me is fix-sysfs-reclaim-crash.patch which removes "sd->s_dentry = NULL;". Note that whole sysfs_drop_dentry() is NOP if ->s_dentry is NULL. Could you try to

[FIXED] Re: tty OOPS (Re: 2.6.21-rc5-mm2)

2007-03-28 Thread Andreas Mohr
Hi, On Wed, Mar 28, 2007 at 10:56:32PM +0400, Alexey Dobriyan wrote: > The only suspicious new patch in -rc5-mm1 to me is > fix-sysfs-reclaim-crash.patch which removes "sd->s_dentry = NULL;". Note > that whole sysfs_drop_dentry() is NOP if ->s_dentry is NULL. > > Could you try to revert it? > >

Re: tty OOPS (Re: 2.6.21-rc5-mm2)

2007-03-28 Thread Andrew Morton
On Wed, 28 Mar 2007 22:56:32 +0400 Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > On Wed, Mar 28, 2007 at 10:38:14PM +0400, Alexey Dobriyan wrote: > > On Wed, Mar 28, 2007 at 08:04:46PM +0200, Andreas Mohr wrote: > > > [unrelated maintainers removed, Alexey added] > > > > > > On Wed, Mar 28, 2007 at

Re: tty OOPS (Re: 2.6.21-rc5-mm2)

2007-03-28 Thread Alexey Dobriyan
On Wed, Mar 28, 2007 at 10:38:14PM +0400, Alexey Dobriyan wrote: > On Wed, Mar 28, 2007 at 08:04:46PM +0200, Andreas Mohr wrote: > > [unrelated maintainers removed, Alexey added] > > > > On Wed, Mar 28, 2007 at 07:45:24PM +0200, Andreas Mohr wrote: > > > Hi, > > > > > > just wanted to add that when

Re: tty OOPS (Re: 2.6.21-rc5-mm2)

2007-03-28 Thread Alexey Dobriyan
On Wed, Mar 28, 2007 at 08:04:46PM +0200, Andreas Mohr wrote: > [unrelated maintainers removed, Alexey added] > > On Wed, Mar 28, 2007 at 07:45:24PM +0200, Andreas Mohr wrote: > > Hi, > > > > just wanted to add that when analyzing the backtrace I found the comment > > at drivers/char/vt.c/con_close

tty OOPS (Re: 2.6.21-rc5-mm2)

2007-03-28 Thread Andreas Mohr
Hi, [unrelated maintainers removed, Alexey added] On Wed, Mar 28, 2007 at 07:45:24PM +0200, Andreas Mohr wrote: > Hi, > > just wanted to add that when analyzing the backtrace I found the comment > at drivers/char/vt.c/con_close() to be VERY suspicious... > (need to take tty_mutex to prevent conc