[PATCH 3.12 116/212] tty: incorrect test of echo_buf() result for ECHO_OP_START

2013-12-02 Thread Greg Kroah-Hartman
3.12-stable review patch. If anyone has any objections, please let me know. -- From: Roel Kluin commit c476f6584b0011741b4f0316f1ac4aa3a99403e1 upstream. test echo_buf() result for ECHO_OP_START Signed-off-by: Roel Kluin Acked-by: Peter Hurley Signed-off-by: Greg Kroah-Hart

Re: tty: incorrect test of echo_buf() result for ECHO_OP_START

2013-10-11 Thread Peter Hurley
On 10/11/2013 04:08 PM, Roel Kluin wrote: Untested, but this looks like a bug to me Careless error on my part. Fix looks good; thanks for catching this. Regards, Peter Hurley --- test echo_buf() result for ECHO_OP_START Signed-off-by: Roel Kluin --- diff --git a/drivers/tty/n_tty.c

Re: tty: incorrect test of echo_buf() result for ECHO_OP_START

2013-10-11 Thread Greg Kroah-Hartman
On Sat, Oct 12, 2013 at 12:04:50AM +0200, Roel Kluin wrote: > Adding Andrew to CC, thanks for comments & picking up my patches, BTW. Given that Jiri and I are the tty/serial maintainers, we should be able to handle this, give us a few days to catch up with patches sent before yours... thanks, gr

tty: incorrect test of echo_buf() result for ECHO_OP_START

2013-10-11 Thread Roel Kluin
Untested, but this looks like a bug to me --- test echo_buf() result for ECHO_OP_START Signed-off-by: Roel Kluin --- diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c index 7a744b6..42b6cca 100644 --- a/drivers/tty/n_tty.c +++ b/drivers/tty/n_tty.c @@ -767,7 +767,7 @@ static size_t _