Re: [PATCH] Re: tools/liblockdep: Build failure

2014-04-01 Thread Sasha Levin
On 04/01/2014 11:34 AM, Andi Kleen wrote: On Tue, Apr 01, 2014 at 12:21:59PM +0200, Robin Hack wrote: From: Robin Hack Copy asmlinkage macro to lockdep/uinclude/linux/linkage.h. You can just do #define asmlinkage #define __visible Thanks Andi, I've queued it up along with another fix for

Re: [PATCH] Re: tools/liblockdep: Build failure

2014-04-01 Thread Andi Kleen
On Tue, Apr 01, 2014 at 12:21:59PM +0200, Robin Hack wrote: > From: Robin Hack > Copy asmlinkage macro to lockdep/uinclude/linux/linkage.h. You can just do #define asmlinkage #define __visible for this case. don't need all the ifdefs or the attribute in the userspace build. -Andi -- To unsu

Re: [PATCH] Re: tools/liblockdep: Build failure

2014-04-01 Thread Robin Hack
Patch is wrong. On Tue, Apr 01, 2014 at 12:21:59PM +0200, Robin Hack wrote: > From: Robin Hack > Copy asmlinkage macro to lockdep/uinclude/linux/linkage.h. > > diff --git a/tools/lib/lockdep/uinclude/linux/linkage.h > b/tools/lib/lockdep/uinclude/linux/linkage.h > index fab00ff..6799a5b 100644 >

[PATCH] Re: tools/liblockdep: Build failure

2014-04-01 Thread Robin Hack
From: Robin Hack Copy asmlinkage macro to lockdep/uinclude/linux/linkage.h. diff --git a/tools/lib/lockdep/uinclude/linux/linkage.h b/tools/lib/lockdep/uinclude/linux/linkage.h index fab00ff..6799a5b 100644 --- a/tools/lib/lockdep/uinclude/linux/linkage.h +++ b/tools/lib/lockdep/uinclude/linux/l

Re: tools/liblockdep: Build failure

2014-04-01 Thread Robin Hack
t; Hi. > > I have same issue. > > I investigated output of gcc -E and I found that asmlinkage macro isn't > expanded as is expected. > > $ grep asmlinkage common.o > asmlinkage extern void lockdep_sys_exit(void); > > On Tue, Apr 01, 2014 at 06:04:35AM +0000, Eunbon

Re: tools/liblockdep: Build failure

2014-04-01 Thread Robin Hack
Hi. I have same issue. I investigated output of gcc -E and I found that asmlinkage macro isn't expanded as is expected. $ grep asmlinkage common.o asmlinkage extern void lockdep_sys_exit(void); On Tue, Apr 01, 2014 at 06:04:35AM +, Eunbong Song wrote: > > There is tools/liblo

tools/liblockdep: Build failure

2014-03-31 Thread Eunbong Song
There is tools/liblockdep build failure. I have been trying to find the cause and i found commit id 63f9a7fde715352e0769302527670542a664b981 is the casue. Author: Andi Kleen Date: Sat Feb 8 08:52:01 2014 +0100 asmlinkage: Make lockdep_sys_exit asmlinkage lockdep_sys_exit can be