Re: [PATCH 1/4] sysctl: move u8 register test to lib/test_sysctl.c

2025-04-11 Thread Joel Granados
On Wed, Apr 09, 2025 at 10:26:56AM -0700, Kees Cook wrote: > On Fri, Mar 21, 2025 at 01:47:24PM +0100, Joel Granados wrote: > > If the test added in commit b5ffbd139688 ("sysctl: move the extra1/2 > > boundary check of u8 to sysctl_check_table_array") is run as a module,

Re: [PATCH 4/4] sysctl: Close test ctl_headers with a for loop

2025-04-10 Thread Kees Cook
On Fri, Mar 21, 2025 at 01:47:27PM +0100, Joel Granados wrote: > As more tests are added, the exit function gets longer than it should > be. Condense the un-register calls into a for loop to make it easier to > add/remove tests. > > Signed-off-by: Joel Granados Much cleaner too. :) Reviewed-by:

Re: [PATCH 3/4] sysctl: call sysctl tests with a for loop

2025-04-09 Thread Kees Cook
On Fri, Mar 21, 2025 at 01:47:26PM +0100, Joel Granados wrote: > As we add more test functions in lib/tests_sysctl the main test function > (test_sysctl_init) grows. Condense the logic to make it easier to > add/remove tests. > > Signed-off-by: Joel Granados Nice cleanup! Reviewed-by: Kees Cook

Re: [PATCH 1/4] sysctl: move u8 register test to lib/test_sysctl.c

2025-04-09 Thread Kees Cook
On Fri, Mar 21, 2025 at 01:47:24PM +0100, Joel Granados wrote: > If the test added in commit b5ffbd139688 ("sysctl: move the extra1/2 > boundary check of u8 to sysctl_check_table_array") is run as a module, a > lingering reference to the module is left behind, and a 'sysct

Re: [PATCH 2/4] sysctl: Add 0012 to test the u8 range check

2025-04-09 Thread Kees Cook
On Fri, Mar 21, 2025 at 01:47:25PM +0100, Joel Granados wrote: > Add a sysctl test that uses the new u8 test ctl files in a created by > the sysctl test module. Check that the u8 proc file that is valid is > created and that there are two messages in dmesg for the files that were >

[PATCH 3/4] sysctl: call sysctl tests with a for loop

2025-04-05 Thread Joel Granados
As we add more test functions in lib/tests_sysctl the main test function (test_sysctl_init) grows. Condense the logic to make it easier to add/remove tests. Signed-off-by: Joel Granados --- lib/test_sysctl.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) di

[PATCH 4/4] sysctl: Close test ctl_headers with a for loop

2025-04-04 Thread Joel Granados
As more tests are added, the exit function gets longer than it should be. Condense the un-register calls into a for loop to make it easier to add/remove tests. Signed-off-by: Joel Granados --- lib/test_sysctl.c | 65 +-- 1 file changed, 29 inse

[PATCH 0/4] sysctl: Move the u8 range check test to lib/test_sysctl.c

2025-03-22 Thread Joel Granados
Originally introduced to sysctl-test.c by commit b5ffbd139688 ("sysctl: move the extra1/2 boundary check of u8 to sysctl_check_table_array"), it has been shown to lead to a panic under certain conditions related to a dangling registration. This series moves the u8 test to lib/test_sysc

[PATCH 2/4] sysctl: Add 0012 to test the u8 range check

2025-03-21 Thread Joel Granados
Add a sysctl test that uses the new u8 test ctl files in a created by the sysctl test module. Check that the u8 proc file that is valid is created and that there are two messages in dmesg for the files that were out of range. Signed-off-by: Joel Granados --- tools/testing/selftests/sysctl

[PATCH 1/4] sysctl: move u8 register test to lib/test_sysctl.c

2025-03-21 Thread Joel Granados
If the test added in commit b5ffbd139688 ("sysctl: move the extra1/2 boundary check of u8 to sysctl_check_table_array") is run as a module, a lingering reference to the module is left behind, and a 'sysctl -a' leads to a panic. To reproduce CONFIG_KUNIT=y CONFIG_SYSCT

Re: [PATCH sysctl-next v2] selftests/sysctl: fix wording of help messages

2025-02-27 Thread Joel Granados
On Fri, Feb 21, 2025 at 03:51:49PM +0530, Bharadwaj Raju wrote: > Fix grammar such as "number amount of times is > recommended" etc -> "the recommended number of > times". > > Signed-off-by: Bharadwaj Raju > --- > tools/testing/selftests/sysc

[PATCH sysctl-next v2] selftests/sysctl: fix wording of help messages

2025-02-21 Thread Bharadwaj Raju
Fix grammar such as "number amount of times is recommended" etc -> "the recommended number of times". Signed-off-by: Bharadwaj Raju --- tools/testing/selftests/sysctl/sysctl.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selfte

Re: [PATCH] selftests/sysctl: fix wording of help messages

2025-02-21 Thread Joel Granados
r of > times". > > Signed-off-by: Bharadwaj Raju > --- > tools/testing/selftests/sysctl/sysctl.sh | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/sysctl/sysctl.sh > b/tools/testing/selftests/sysctl/sysctl.

Re: [PATCH] selftests: fix spelling/grammar errors in sysctl/sysctl.sh

2025-02-21 Thread Joel Granados
On Tue, Jan 28, 2025 at 04:06:55PM +0530, Chandra Pratap wrote: > Fix the grammatical/spelling errors in sysctl/sysctl.sh. > This fixes all errors pointed out by codespell in the file. > > Signed-off-by: Chandra Pratap > --- > tools/testing/selftests/sysctl/sysctl.sh |

Re: [PATCH v2] selftests:sysctl:Fix minor typos in sysctl test

2025-02-19 Thread Greg KH
On Wed, Feb 19, 2025 at 07:33:01PM +, Sumya Hoque wrote: > > Signed-off-by: Sumya Hoque > --- > tools/testing/selftests/sysctl/sysctl.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/sysctl/sysctl.sh > b/tools/

[PATCH v2] selftests:sysctl:Fix minor typos in sysctl test

2025-02-19 Thread Sumya Hoque
Signed-off-by: Sumya Hoque --- tools/testing/selftests/sysctl/sysctl.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/sysctl/sysctl.sh b/tools/testing/selftests/sysctl/sysctl.sh index 84472b436c07..323468653327 100755 --- a/tools/testing

Re: [PATCH] selftests:sysctl:Fix minor grammers in sysctl test

2025-02-19 Thread Kees Cook
d-off-by: Sumya Hoque > --- > tools/testing/selftests/sysctl/sysctl.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/sysctl/sysctl.sh > b/tools/testing/selftests/sysctl/sysctl.sh > index 84472b436c07..a4d76147ed8a 10075

[PATCH] selftests:sysctl:Fix minor grammers in sysctl test

2025-02-18 Thread Sumya Hoque
Hello everyone, Some minor grammer issues that I have fixed: 1. echo "If an error every occurs --> echo "If an error occurs, every execution 2. Example uses --> Example Usage Signed-off-by: Sumya Hoque --- tools/testing/selftests/sysctl/sysctl.sh | 4 ++-- 1 file changed, 2

[PATCH] selftests/sysctl: fix wording of help messages

2025-02-15 Thread Bharadwaj Raju
Fix paramter -> parameter, and recomended -> recommended in sysctl.sh's help messages. Also correct grammar: "number amount of times is recommended" etc -> "the recommended number of times". Signed-off-by: Bharadwaj Raju --- tools/testing/selftests/sysctl/sy

[PATCH] selftests: fix spelling/grammar errors in sysctl/sysctl.sh

2025-01-28 Thread Chandra Pratap
Fix the grammatical/spelling errors in sysctl/sysctl.sh. This fixes all errors pointed out by codespell in the file. Signed-off-by: Chandra Pratap --- tools/testing/selftests/sysctl/sysctl.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests

Re: [PATCH v1] selftests/memfd: Run sysctl tests when PID namespace support is enabled

2024-12-05 Thread Jeff Xu
On Thu, Dec 5, 2024 at 11:29 AM Isaac J. Manjarres wrote: > > The sysctl tests for vm.memfd_noexec rely on the kernel to support PID > namespaces (i.e. the kernel is built with CONFIG_PID_NS=y). If the > kernel the test runs on does not support PID namespaces, the first > sysctl

[PATCH v1] selftests/memfd: Run sysctl tests when PID namespace support is enabled

2024-12-05 Thread Isaac J. Manjarres
The sysctl tests for vm.memfd_noexec rely on the kernel to support PID namespaces (i.e. the kernel is built with CONFIG_PID_NS=y). If the kernel the test runs on does not support PID namespaces, the first sysctl test will fail when attempting to spawn a new thread in a new PID namespace, abort the

Re: [PATCH net 3/3] selftests: mptcp: list sysctl data

2024-10-23 Thread Simon Horman
On Mon, Oct 21, 2024 at 12:25:28PM +0200, Matthieu Baerts (NGI0) wrote: > Listing all the values linked to the MPTCP sysctl knobs was not > exercised in MPTCP test suite. > > Let's do that to avoid any regressions, but also to have a kernel with a > debug kconfig verifying m

[PATCH net 3/3] selftests: mptcp: list sysctl data

2024-10-21 Thread Matthieu Baerts (NGI0)
Listing all the values linked to the MPTCP sysctl knobs was not exercised in MPTCP test suite. Let's do that to avoid any regressions, but also to have a kernel with a debug kconfig verifying more assumptions. For the moment, we are not interested by the output, only to avoid crashes and war

[PATCH net-next 2/5] net/ipv4/sysctl: constify ctl_table arguments of utility functions

2024-05-27 Thread Thomas Weißschuh
The sysctl core is preparing to only expose instances of struct ctl_table as "const". This will also affect the ctl_table argument of sysctl handlers. As the function prototype of all sysctl handlers throughout the tree needs to stay consistent that change will be done in one commit.

Re: [PATCH v3 0/7] sysctl: Remove sentinel elements from arch

2023-10-11 Thread Joel Granados
the trailing comma for the ctl_table arrays. This was a comment > > that we received "drivers/*" patch set. > > * Link to v2: > > https://lore.kernel.org/r/20230913-jag-sysctl_remove_empty_elem_arch-v2-0-d1bd13a29...@samsung.com > > Thanks! I replaced the v2 with th

Re: [PATCH v3 0/7] sysctl: Remove sentinel elements from arch

2023-10-10 Thread Luis Chamberlain
drivers/*" patch set. > * Link to v2: > https://lore.kernel.org/r/20230913-jag-sysctl_remove_empty_elem_arch-v2-0-d1bd13a29...@samsung.com Thanks! I replaced the v2 with this v3 on sysctl-next. Luis

[PATCH v3 0/7] sysctl: Remove sentinel elements from arch

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados What? These commits remove the sentinel element (last empty element) from the sysctl arrays of all the files under the "arch/" directory that use a sysctl array for registration. The merging of the preparation patches (in https://lore.kernel.org/all/zo5yx

Re: [PATCH v2 0/8] sysctl: Remove sentinel elements from arch

2023-09-20 Thread Luis Chamberlain
nel.org/r/20230906-jag-sysctl_remove_empty_elem_arch-v1-0-3935d4854...@samsung.com Thanks! I've merged this onto sysctl-next. Luis

[PATCH v2 0/8] sysctl: Remove sentinel elements from arch

2023-09-13 Thread Joel Granados via B4 Relay
From: Joel Granados What? These commits remove the sentinel element (last empty element) from the sysctl arrays of all the files under the "arch/" directory that use a sysctl array for registration. The merging of the preparation patches (in https://lore.kernel.org/all/zo5yx

[PATCH] docs: admin-guide: update description for kernel.modprobe sysctl

2021-04-20 Thread Rasmus Villemoes
ion/admin-guide/sysctl/kernel.rst | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst index 1d56a6b73a4e..7ca8df5451d4 100644 --- a/Documentation/admin-guide/sysctl/kernel.rst +++

[PATCH] docs: admin-guide: update description for kernel.hotplug sysctl

2021-04-20 Thread Rasmus Villemoes
uot;Driver-Core: disable /sbin/hotplug by default") Signed-off-by: Rasmus Villemoes --- Documentation/admin-guide/sysctl/kernel.rst | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rs

[tip: sched/core] sched: Move SCHED_DEBUG sysctl to debugfs

2021-04-16 Thread tip-bot2 for Peter Zijlstra
Committer: Peter Zijlstra CommitterDate: Fri, 16 Apr 2021 17:06:34 +02:00 sched: Move SCHED_DEBUG sysctl to debugfs Stop polluting sysctl with undocumented knobs that really are debug only, move them all to /debug/sched/ along with the existing /debug/sched_* files that already exist. Signed-off

[tip: sched/core] sched: Remove sched_schedstats sysctl out from under SCHED_DEBUG

2021-04-16 Thread tip-bot2 for Peter Zijlstra
Committer: Peter Zijlstra CommitterDate: Fri, 16 Apr 2021 17:06:33 +02:00 sched: Remove sched_schedstats sysctl out from under SCHED_DEBUG CONFIG_SCHEDSTATS does not depend on SCHED_DEBUG, it is inconsistent to have the sysctl depend on it. Suggested-by: Mel Gorman Signed-off-by: Peter Zijlstra

[tip: sched/core] sched,debug: Convert sysctl sched_domains to debugfs

2021-04-16 Thread tip-bot2 for Peter Zijlstra
Committer: Peter Zijlstra CommitterDate: Fri, 16 Apr 2021 17:06:35 +02:00 sched,debug: Convert sysctl sched_domains to debugfs Stop polluting sysctl, move to debugfs for SCHED_DEBUG stuff. Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Dietmar Eggemann Reviewed-by: Valentin Schneider Tested

Re: [PATCH v2 7/9] sched,debug: Convert sysctl sched_domains to debugfs

2021-04-15 Thread Peter Zijlstra
On Thu, Apr 15, 2021 at 01:34:27PM +0100, Valentin Schneider wrote: > On 15/04/21 11:06, Peter Zijlstra wrote: > > @@ -2388,8 +2384,6 @@ void partition_sched_domains_locked(int > > doms_cur = doms_new; > > dattr_cur = dattr_new; > > ndoms_cur = ndoms_new; > > - > > - register_sc

Re: [PATCH v2 7/9] sched,debug: Convert sysctl sched_domains to debugfs

2021-04-15 Thread Valentin Schneider
On 15/04/21 11:06, Peter Zijlstra wrote: > On Tue, Apr 13, 2021 at 03:55:15PM +0100, Valentin Schneider wrote: >> On 12/04/21 12:14, Peter Zijlstra wrote: >> > Stop polluting sysctl, move to debugfs for SCHED_DEBUG stuff. >> > >> > Signed-off-by: Peter Zijlstr

Re: [PATCH v2 7/9] sched,debug: Convert sysctl sched_domains to debugfs

2021-04-15 Thread Dietmar Eggemann
On 15/04/2021 11:06, Peter Zijlstra wrote: > On Tue, Apr 13, 2021 at 03:55:15PM +0100, Valentin Schneider wrote: >> On 12/04/21 12:14, Peter Zijlstra wrote: >>> Stop polluting sysctl, move to debugfs for SCHED_DEBUG stuff. >>> >>> Signed-off-by: Peter Zijlst

Re: [PATCH v2 7/9] sched,debug: Convert sysctl sched_domains to debugfs

2021-04-15 Thread Peter Zijlstra
On Tue, Apr 13, 2021 at 03:55:15PM +0100, Valentin Schneider wrote: > On 12/04/21 12:14, Peter Zijlstra wrote: > > Stop polluting sysctl, move to debugfs for SCHED_DEBUG stuff. > > > > Signed-off-by: Peter Zijlstra (Intel) > > Reviewed-by: Dietmar Eggemann > >

Re: [PATCH v2 7/9] sched,debug: Convert sysctl sched_domains to debugfs

2021-04-13 Thread Valentin Schneider
On 12/04/21 12:14, Peter Zijlstra wrote: > Stop polluting sysctl, move to debugfs for SCHED_DEBUG stuff. > > Signed-off-by: Peter Zijlstra (Intel) > Reviewed-by: Dietmar Eggemann On my Juno (2+4 big.LITTLE), sys/kernel/debug/sched/domains/ is now empty. I think that&

[PATCH v2 7/9] sched,debug: Convert sysctl sched_domains to debugfs

2021-04-12 Thread Peter Zijlstra
Stop polluting sysctl, move to debugfs for SCHED_DEBUG stuff. Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Dietmar Eggemann --- kernel/sched/debug.c| 255 +++- kernel/sched/sched.h|2 kernel/sched/topology.c |1 3 files

[PATCH v2 4/9] sched: Move SCHED_DEBUG sysctl to debugfs

2021-04-12 Thread Peter Zijlstra
Stop polluting sysctl with undocumented knobs that really are debug only, move them all to /debug/sched/ along with the existing /debug/sched_* files that already exist. Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Greg Kroah-Hartman --- include/linux/sched/sysctl.h |8 +-- kernel

[PATCH v2 2/9] sched: Remove sched_schedstats sysctl out from under SCHED_DEBUG

2021-04-12 Thread Peter Zijlstra
CONFIG_SCHEDSTATS does not depend on SCHED_DEBUG, it is inconsistent to have the sysctl depend on it. Suggested-by: Mel Gorman Signed-off-by: Peter Zijlstra (Intel) --- kernel/sysctl.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) --- a/kernel/sysctl.c +++ b

Re: [PATCH] sysctl: use min() helper for namecmp()

2021-04-11 Thread Masahiro Yamada
On Tue, Mar 2, 2021 at 8:47 AM Kees Cook wrote: > > On Sun, Feb 28, 2021 at 04:44:22PM +0900, Masahiro Yamada wrote: > > (CC: Andrew Morton) > > > > A friendly reminder. > > > > > > This is just a minor clean-up. > > > > If nobody picks it up, > > I hope perhaps Andrew Morton will do. > > > > This

Re: [PATCH 7/9] sched,debug: Convert sysctl sched_domains to debugfs

2021-04-07 Thread Peter Zijlstra
On Wed, Apr 07, 2021 at 11:46:32AM +0100, Valentin Schneider wrote: > > - __cpumask_clear_cpu(i, sd_sysctl_cpus); > > That seems to be the only place we cleared a CPU in that cpumask, and I > don't see its replacement Yeah, oops :-) Lemme go fix that. Thanks!

Re: [PATCH 7/9] sched,debug: Convert sysctl sched_domains to debugfs

2021-04-07 Thread Valentin Schneider
On 26/03/21 11:33, Peter Zijlstra wrote: > Stop polluting sysctl, move to debugfs for SCHED_DEBUG stuff. > > Signed-off-by: Peter Zijlstra (Intel) > --- > kernel/sched/debug.c| 255 > ++-- > kernel/sched/sched.h|

Re: [PATCH] mm/vmscan: add sysctl knobs for protecting the specified

2021-04-05 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Alexey-Avramov/mm-vmscan-add-sysctl-knobs-for-protecting-the-specified/20210406-061034 base: https://git.kernel.org/pub/scm/linux/

Re: [PATCH] mm/vmscan: add sysctl knobs for protecting the specified

2021-04-05 Thread kernel test robot
patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Alexey-Avramov/mm-vmscan-add-sysctl-knobs-for-protecting-the-specified/20210406-061034 base: https://git.kernel.org/pub/scm/linux/kernel/gi

[RFC PATCH v1 10/11] mm: Set toptier_scale_factor via sysctl

2021-04-05 Thread Tim Chen
Update the toptier_scale_factor via sysctl. This variable determines when kswapd wakes up to recalaim toptier memory from those mem cgroups exceeding their toptier memory limit. Signed-off-by: Tim Chen --- include/linux/mm.h | 4 include/linux/mmzone.h | 2 ++ kernel/sysctl.c

Re: [PATCH 7/9] sched,debug: Convert sysctl sched_domains to debugfs

2021-03-26 Thread Dietmar Eggemann
On 26/03/2021 11:33, Peter Zijlstra wrote: > Stop polluting sysctl, move to debugfs for SCHED_DEBUG stuff. > > Signed-off-by: Peter Zijlstra (Intel) > --- > kernel/sched/debug.c| 255 > ++-- > kernel/sched/sched.h|

[PATCH 7/9] sched,debug: Convert sysctl sched_domains to debugfs

2021-03-26 Thread Peter Zijlstra
Stop polluting sysctl, move to debugfs for SCHED_DEBUG stuff. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/debug.c| 255 ++-- kernel/sched/sched.h|2 kernel/sched/topology.c |1 3 files changed, 59 insertions(+), 199

[PATCH 2/9] sched: Remove sched_schedstats sysctl out from under SCHED_DEBUG

2021-03-26 Thread Peter Zijlstra
CONFIG_SCHEDSTATS does not depend on SCHED_DEBUG, it is inconsistent to have the sysctl depend on it. Suggested-by: Mel Gorman Signed-off-by: Peter Zijlstra (Intel) --- kernel/sysctl.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) --- a/kernel/sysctl.c +++ b

[PATCH v9 21/22] dt-bindings: add BCM6318 GPIO sysctl binding documentation

2021-03-24 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM6318 SoCs. Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Rob Herring --- v9: no changes v8: add changes suggested by Rob Herring v7: add changes suggested by Rob Herring .../mfd/brcm,bcm6318-gpio-sysctl.yaml | 177

[PATCH v9 15/22] dt-bindings: add BCM6368 GPIO sysctl binding documentation

2021-03-24 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM6368 SoCs. Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Rob Herring --- v9: no changes v8: add changes suggested by Rob Herring v7: add changes suggested by Rob Herring .../mfd/brcm,bcm6368-gpio-sysctl.yaml | 246

[PATCH v9 12/22] dt-bindings: add BCM6362 GPIO sysctl binding documentation

2021-03-24 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM6362 SoCs. Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Rob Herring --- v9: no changes v8: add changes suggested by Rob Herring v7: add changes suggested by Rob Herring .../mfd/brcm,bcm6362-gpio-sysctl.yaml | 236

[PATCH v9 18/22] dt-bindings: add BCM63268 GPIO sysctl binding documentation

2021-03-24 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM63268 SoCs. Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Rob Herring --- v9: no changes v8: add changes suggested by Rob Herring v7: add changes suggested by Rob Herring .../mfd/brcm,bcm63268-gpio-sysctl.yaml| 194

[PATCH v9 06/22] dt-bindings: add BCM6328 GPIO sysctl binding documentation

2021-03-24 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM6328 SoCs. Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Rob Herring --- v9: no changes v8: add changes suggested by Rob Herring v7: add changes suggested by Rob Herring .../mfd/brcm,bcm6328-gpio-sysctl.yaml | 162

[PATCH v9 09/22] dt-bindings: add BCM6358 GPIO sysctl binding documentation

2021-03-24 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM6358 SoCs. Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Rob Herring --- v9: no changes v8: add changes suggested by Rob Herring v7: add changes suggested by Rob Herring .../mfd/brcm,bcm6358-gpio-sysctl.yaml | 130

Re: [PATCH v8 21/22] dt-bindings: add BCM6318 GPIO sysctl binding documentation

2021-03-23 Thread Rob Herring
On Wed, 17 Mar 2021 15:38:02 +0100, Álvaro Fernández Rojas wrote: > Add binding documentation for the GPIO sysctl found in BCM6318 SoCs. > > Signed-off-by: Álvaro Fernández Rojas > --- > v8: add changes suggested by Rob Herring > v7: add changes suggested by Rob Herring

Re: [PATCH v8 18/22] dt-bindings: add BCM63268 GPIO sysctl binding documentation

2021-03-23 Thread Rob Herring
On Wed, 17 Mar 2021 15:37:59 +0100, Álvaro Fernández Rojas wrote: > Add binding documentation for the GPIO sysctl found in BCM63268 SoCs. > > Signed-off-by: Álvaro Fernández Rojas > --- > v8: add changes suggested by Rob Herring > v7: add changes suggested by Rob Herring

Re: [PATCH v8 15/22] dt-bindings: add BCM6368 GPIO sysctl binding documentation

2021-03-23 Thread Rob Herring
On Wed, 17 Mar 2021 15:37:56 +0100, Álvaro Fernández Rojas wrote: > Add binding documentation for the GPIO sysctl found in BCM6368 SoCs. > > Signed-off-by: Álvaro Fernández Rojas > --- > v8: add changes suggested by Rob Herring > v7: add changes suggested by Rob Herring

Re: [PATCH v8 12/22] dt-bindings: add BCM6362 GPIO sysctl binding documentation

2021-03-23 Thread Rob Herring
On Wed, 17 Mar 2021 15:37:53 +0100, Álvaro Fernández Rojas wrote: > Add binding documentation for the GPIO sysctl found in BCM6362 SoCs. > > Signed-off-by: Álvaro Fernández Rojas > --- > v8: add changes suggested by Rob Herring > v7: add changes suggested by Rob Herring

Re: [PATCH v8 09/22] dt-bindings: add BCM6358 GPIO sysctl binding documentation

2021-03-23 Thread Rob Herring
On Wed, 17 Mar 2021 15:37:50 +0100, Álvaro Fernández Rojas wrote: > Add binding documentation for the GPIO sysctl found in BCM6358 SoCs. > > Signed-off-by: Álvaro Fernández Rojas > --- > v8: add changes suggested by Rob Herring > v7: add changes suggested by Rob Herring

Re: [PATCH v8 06/22] dt-bindings: add BCM6328 GPIO sysctl binding documentation

2021-03-23 Thread Rob Herring
On Wed, Mar 17, 2021 at 03:37:47PM +0100, Álvaro Fernández Rojas wrote: > Add binding documentation for the GPIO sysctl found in BCM6328 SoCs. > > Signed-off-by: Álvaro Fernández Rojas > --- > v8: add changes suggested by Rob Herring > v7: add changes suggested by Rob H

[PATCH v8 21/22] dt-bindings: add BCM6318 GPIO sysctl binding documentation

2021-03-17 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM6318 SoCs. Signed-off-by: Álvaro Fernández Rojas --- v8: add changes suggested by Rob Herring v7: add changes suggested by Rob Herring .../mfd/brcm,bcm6318-gpio-sysctl.yaml | 177 ++ 1 file changed, 177

[PATCH v8 18/22] dt-bindings: add BCM63268 GPIO sysctl binding documentation

2021-03-17 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM63268 SoCs. Signed-off-by: Álvaro Fernández Rojas --- v8: add changes suggested by Rob Herring v7: add changes suggested by Rob Herring .../mfd/brcm,bcm63268-gpio-sysctl.yaml| 194 ++ 1 file changed, 194

[PATCH v8 15/22] dt-bindings: add BCM6368 GPIO sysctl binding documentation

2021-03-17 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM6368 SoCs. Signed-off-by: Álvaro Fernández Rojas --- v8: add changes suggested by Rob Herring v7: add changes suggested by Rob Herring .../mfd/brcm,bcm6368-gpio-sysctl.yaml | 246 ++ 1 file changed, 246

[PATCH v8 12/22] dt-bindings: add BCM6362 GPIO sysctl binding documentation

2021-03-17 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM6362 SoCs. Signed-off-by: Álvaro Fernández Rojas --- v8: add changes suggested by Rob Herring v7: add changes suggested by Rob Herring .../mfd/brcm,bcm6362-gpio-sysctl.yaml | 236 ++ 1 file changed, 236

[PATCH v8 09/22] dt-bindings: add BCM6358 GPIO sysctl binding documentation

2021-03-17 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM6358 SoCs. Signed-off-by: Álvaro Fernández Rojas --- v8: add changes suggested by Rob Herring v7: add changes suggested by Rob Herring .../mfd/brcm,bcm6358-gpio-sysctl.yaml | 130 ++ 1 file changed, 130

[PATCH v8 06/22] dt-bindings: add BCM6328 GPIO sysctl binding documentation

2021-03-17 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM6328 SoCs. Signed-off-by: Álvaro Fernández Rojas --- v8: add changes suggested by Rob Herring v7: add changes suggested by Rob Herring .../mfd/brcm,bcm6328-gpio-sysctl.yaml | 162 ++ 1 file changed, 162

Re: [PATCH v7 21/22] dt-bindings: add BCM6318 GPIO sysctl binding documentation

2021-03-17 Thread Álvaro Fernández Rojas
Hi Rob, > El 16 mar 2021, a las 22:20, Rob Herring escribió: > > On Mon, Mar 15, 2021 at 5:42 AM Álvaro Fernández Rojas > wrote: >> >> Add binding documentation for the GPIO sysctl found in BCM6318 SoCs. >> >> Signed-off-by: Álvaro Fernández Rojas >&g

Re: [PATCH v7 21/22] dt-bindings: add BCM6318 GPIO sysctl binding documentation

2021-03-16 Thread Rob Herring
On Mon, Mar 15, 2021 at 5:42 AM Álvaro Fernández Rojas wrote: > > Add binding documentation for the GPIO sysctl found in BCM6318 SoCs. > > Signed-off-by: Álvaro Fernández Rojas > --- > v7: add changes suggested by Rob Herring > > .../mfd/brcm,bcm6318-gpio-s

Re: [PATCH] proc/sysctl: Fix function name error in comments

2021-03-15 Thread Luis Chamberlain
On Mon, Mar 15, 2021 at 04:19:54AM -0700, zhouchuangao wrote: > The function name should be modified to register_sysctl_paths instead > of register_sysctl_table_path. > > Signed-off-by: zhouchuangao Acked-by: Luis Chamberlain Luis

[PATCH v7 21/22] dt-bindings: add BCM6318 GPIO sysctl binding documentation

2021-03-15 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM6318 SoCs. Signed-off-by: Álvaro Fernández Rojas --- v7: add changes suggested by Rob Herring .../mfd/brcm,bcm6318-gpio-sysctl.yaml | 179 ++ 1 file changed, 179 insertions(+) create mode 100644 Documentation

[PATCH v7 18/22] dt-bindings: add BCM63268 GPIO sysctl binding documentation

2021-03-15 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM63268 SoCs. Signed-off-by: Álvaro Fernández Rojas --- v7: add changes suggested by Rob Herring .../mfd/brcm,bcm63268-gpio-sysctl.yaml| 196 ++ 1 file changed, 196 insertions(+) create mode 100644 Documentation

[PATCH v7 15/22] dt-bindings: add BCM6368 GPIO sysctl binding documentation

2021-03-15 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM6368 SoCs. Signed-off-by: Álvaro Fernández Rojas --- v7: add changes suggested by Rob Herring .../mfd/brcm,bcm6368-gpio-sysctl.yaml | 248 ++ 1 file changed, 248 insertions(+) create mode 100644 Documentation

[PATCH v7 12/22] dt-bindings: add BCM6362 GPIO sysctl binding documentation

2021-03-15 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM6362 SoCs. Signed-off-by: Álvaro Fernández Rojas --- v7: add changes suggested by Rob Herring .../mfd/brcm,bcm6362-gpio-sysctl.yaml | 238 ++ 1 file changed, 238 insertions(+) create mode 100644 Documentation

[PATCH v7 09/22] dt-bindings: add BCM6358 GPIO sysctl binding documentation

2021-03-15 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM6358 SoCs. Signed-off-by: Álvaro Fernández Rojas --- v7: add changes suggested by Rob Herring .../mfd/brcm,bcm6358-gpio-sysctl.yaml | 132 ++ 1 file changed, 132 insertions(+) create mode 100644 Documentation

[PATCH v7 06/22] dt-bindings: add BCM6328 GPIO sysctl binding documentation

2021-03-15 Thread Álvaro Fernández Rojas
Add binding documentation for the GPIO sysctl found in BCM6328 SoCs. Signed-off-by: Álvaro Fernández Rojas --- v7: add changes suggested by Rob Herring .../mfd/brcm,bcm6328-gpio-sysctl.yaml | 164 ++ 1 file changed, 164 insertions(+) create mode 100644 Documentation

[PATCH] proc/sysctl: Fix function name error in comments

2021-03-15 Thread zhouchuangao
100644 --- a/fs/proc/proc_sysctl.c +++ b/fs/proc/proc_sysctl.c @@ -1562,7 +1562,7 @@ struct ctl_table_header *__register_sysctl_paths( } /** - * register_sysctl_table_path - register a sysctl table hierarchy + * register_sysctl_paths - register a sysctl table hierarchy * @path: The path to the

Re: [PATCH] sysctl: use min() helper for namecmp()

2021-03-01 Thread Kees Cook
On Sun, Feb 28, 2021 at 04:44:22PM +0900, Masahiro Yamada wrote: > (CC: Andrew Morton) > > A friendly reminder. > > > This is just a minor clean-up. > > If nobody picks it up, > I hope perhaps Andrew Morton will do. > > This patch: > https://lore.kernel.org/patchwork/patch/1360092/ > > > >

Re: [PATCH] sysctl: use min() helper for namecmp()

2021-02-27 Thread Masahiro Yamada
(CC: Andrew Morton) A friendly reminder. This is just a minor clean-up. If nobody picks it up, I hope perhaps Andrew Morton will do. This patch: https://lore.kernel.org/patchwork/patch/1360092/ On Mon, Jan 4, 2021 at 5:33 PM Masahiro Yamada wrote: > > Make it slightly readable by using m

Re: Memory allocation issues after "sysctl: Convert to iter interfaces"

2021-02-24 Thread Matthew Wilcox
On Wed, Feb 24, 2021 at 05:02:09PM -0800, Ivan Babrou wrote: > Hello, > > We started seeing allocation failures on procfs reads after > commit 4bd6a7353ee1 "sysctl: Convert to iter interfaces". https://lore.kernel.org/linux-fsdevel/6345270a2c1160b89dd5e6715461f3881768

Memory allocation issues after "sysctl: Convert to iter interfaces"

2021-02-24 Thread Ivan Babrou
Hello, We started seeing allocation failures on procfs reads after commit 4bd6a7353ee1 "sysctl: Convert to iter interfaces". I haven't done a full bisect, but the decoded stacks point squarely at the following piece of code which was introduced: kbuf = kzalloc(count

[PATCH 4.19 04/17] sysctl: handle overflow in proc_get_long

2021-02-05 Thread Greg Kroah-Hartman
From: Christian Brauner commit 7f2923c4f73f21cfd714d12a2d48de8c21f11cfe upstream. proc_get_long() is a funny function. It uses simple_strtoul() and for a good reason. proc_get_long() wants to always succeed the parse and return the maybe incorrect value and the trailing characters to check aga

[PATCH 5.10 079/142] xfrm: fix disable_xfrm sysctl when used on xfrm interfaces

2021-02-02 Thread Greg Kroah-Hartman
From: Eyal Birger [ Upstream commit 9f8550e4bd9d78a8436c2061ad2530215f875376 ] The disable_xfrm flag signals that xfrm should not be performed during routing towards a device before reaching device xmit. For xfrm interfaces this is usually desired as they perform the outbound policy lookup as p

[PATCH 4.19 23/37] xfrm: fix disable_xfrm sysctl when used on xfrm interfaces

2021-02-02 Thread Greg Kroah-Hartman
From: Eyal Birger [ Upstream commit 9f8550e4bd9d78a8436c2061ad2530215f875376 ] The disable_xfrm flag signals that xfrm should not be performed during routing towards a device before reaching device xmit. For xfrm interfaces this is usually desired as they perform the outbound policy lookup as p

[PATCH 5.4 34/61] xfrm: fix disable_xfrm sysctl when used on xfrm interfaces

2021-02-02 Thread Greg Kroah-Hartman
From: Eyal Birger [ Upstream commit 9f8550e4bd9d78a8436c2061ad2530215f875376 ] The disable_xfrm flag signals that xfrm should not be performed during routing towards a device before reaching device xmit. For xfrm interfaces this is usually desired as they perform the outbound policy lookup as p

Re: [PATCH] Update Documentation/admin-guide/sysctl/fs.rst

2021-01-28 Thread Jonathan Corbet
On Wed, 20 Jan 2021 13:26:47 + Eric Curtin wrote: > max_user_watches for epoll should say 1/25, rather than 1/32 > > Signed-off-by: Eric Curtin > --- > Documentation/admin-guide/sysctl/fs.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --g

Re: [PATCH] net: sysctl: remove redundant #ifdef CONFIG_NET

2021-01-27 Thread patchwork-bot+netdevbpf
d-off-by: Masahiro Yamada > > [...] Here is the summary with links: - net: sysctl: remove redundant #ifdef CONFIG_NET https://git.kernel.org/netdev/net-next/c/69783429cd13 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html

[PATCH] net: sysctl: remove redundant #ifdef CONFIG_NET

2021-01-25 Thread Masahiro Yamada
CONFIG_NET is a bool option, and this file is compiled only when CONFIG_NET=y. Remove #ifdef CONFIG_NET, which we know it is always met. Signed-off-by: Masahiro Yamada --- net/core/sysctl_net_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/core/sysctl_net_core.c b/net/core/sysc

Re: [PATCH] doc: networking: ip-sysctl: Document conf/all/disable_ipv6 and conf/default/disable_ipv6

2021-01-23 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 21 Jan 2021 16:02:44 +0100 you wrote: > This patch adds documentation for sysctl conf/all/disable_ipv6 and > conf/default/disable_ipv6 settings which is currently missing. > > Signed-off-by

[PATCH] doc: networking: ip-sysctl: Document conf/all/disable_ipv6 and conf/default/disable_ipv6

2021-01-21 Thread Pali Rohár
This patch adds documentation for sysctl conf/all/disable_ipv6 and conf/default/disable_ipv6 settings which is currently missing. Signed-off-by: Pali Rohár --- Documentation/networking/ip-sysctl.rst | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/networking/ip

[PATCH] Update Documentation/admin-guide/sysctl/fs.rst

2021-01-20 Thread Eric Curtin
max_user_watches for epoll should say 1/25, rather than 1/32 Signed-off-by: Eric Curtin --- Documentation/admin-guide/sysctl/fs.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/sysctl/fs.rst b/Documentation/admin-guide/sysctl/fs.rst index

[PATCH net-next 0/3] Namespace-ify some sysctl in net/core

2021-01-18 Thread menglong8 . dong
From: Menglong Dong For now, most sysctl in 'net/core' are globally unified, such as sysctl_wmem_default, sysctl_rmem_default, sysctl_wmem_default, sysctl_rmem_default, etc. It's not convenient in some case. For example, when we use docker and try to control the default udp

Re: [PATCH net-next] net: sysctl: cleanup net_sysctl_init()

2021-01-07 Thread Jakub Kicinski
On Thu, 07 Jan 2021 09:13:40 + Alexander Lobakin wrote: > From: Jakub Kicinski > Date: Wed, 6 Jan 2021 16:30:56 -0800 > > > On Wed, 06 Jan 2021 20:40:28 + Alexander Lobakin wrote: > >> 'net_header' is not used outside of this function, so can be moved > >> from BSS onto the stack. > >>

Re: [PATCH net-next] net: sysctl: cleanup net_sysctl_init()

2021-01-07 Thread Alexander Lobakin
From: Jakub Kicinski Date: Wed, 6 Jan 2021 16:30:56 -0800 > On Wed, 06 Jan 2021 20:40:28 + Alexander Lobakin wrote: >> 'net_header' is not used outside of this function, so can be moved >> from BSS onto the stack. >> Declarations of one-element arrays are discouraged, and there's no >> need t

Re: [PATCH net-next] net: sysctl: cleanup net_sysctl_init()

2021-01-06 Thread Jakub Kicinski
On Wed, 06 Jan 2021 20:40:28 + Alexander Lobakin wrote: > 'net_header' is not used outside of this function, so can be moved > from BSS onto the stack. > Declarations of one-element arrays are discouraged, and there's no > need to store 'empty' in BSS. Simply allocate it from heap at init. Are

Re: [PATCH] sysctl: use min() helper for namecmp()

2021-01-06 Thread Kees Cook
On Mon, Jan 04, 2021 at 05:32:21PM +0900, Masahiro Yamada wrote: > Make it slightly readable by using min(). > > Signed-off-by: Masahiro Yamada Acked-by: Kees Cook -- Kees Cook

[PATCH net-next] net: sysctl: cleanup net_sysctl_init()

2021-01-06 Thread Alexander Lobakin
net_ops = { .exit = sysctl_net_exit, }; -static struct ctl_table_header *net_header; __init int net_sysctl_init(void) { - static struct ctl_table empty[1]; + struct ctl_table_header *net_header; + struct ctl_table *empty; int ret = -ENOMEM; + /* Avoid

  1   2   3   4   5   6   7   8   9   10   >