Re: Fw: suspicious behaviour in pcwd driver.

2005-08-31 Thread Wim Van Sebroeck
Hi Dave, > drivers/char/watchdog/pcwd.c does this if it detects > a temperature out of range.. > > if (temp_panic) { > printk (KERN_INFO PFX "Temperature overheat trip!\n"); > machine_power_off(); > } > > Two problems here are.. > > 1. mac

Re: suspicious behaviour in pcwd driver.

2005-08-26 Thread Pavel Machek
Hi! > > 2. that printk will never hit the logs, so the admin will just find > > a powered off box with no idea what happened. > > Should we at least sync block devices before doing the power off ? > > AFAICS, this is still a problem with kernel_power_off() though ? > Look at how acpi does t

Re: suspicious behaviour in pcwd driver.

2005-08-22 Thread Benjamin Herrenschmidt
> Export machine_power_off() on ppc64, as the pcwd watchdog driver needs it. > > Signed-off-by: Dave Jones <[EMAIL PROTECTED]> > > --- linux-2.6.12/arch/ppc64/kernel/setup.c~ 2005-08-09 17:37:36.0 > -0400 > +++ linux-2.6.12/arch/ppc64/kernel/setup.c2005-08-09 17:37:53.0 >

Re: suspicious behaviour in pcwd driver.

2005-08-22 Thread Dave Jones
On Mon, Aug 22, 2005 at 02:30:06PM -0400, Dave Jones wrote: > drivers/char/watchdog/pcwd.c does this if it detects > a temperature out of range.. > > if (temp_panic) { > printk (KERN_INFO PFX "Temperature overheat trip!\n"); > machine_power_off();

suspicious behaviour in pcwd driver.

2005-08-22 Thread Dave Jones
drivers/char/watchdog/pcwd.c does this if it detects a temperature out of range.. if (temp_panic) { printk (KERN_INFO PFX "Temperature overheat trip!\n"); machine_power_off(); } Two problems here are.. 1. machine_power_off() isn't exported