Re: staging: pi433: Possible bug in rf69.c

2017-11-11 Thread Marcus Wolf
Hi Joe, thank you for your suggestion. The enums are necessary for the (old fashioned) ioctl interface, too. So the user space uses these enums in order to configure the driver. If we want to completely remove rf69_enum.h, we need to find a solution for that, too. From the optics/readability, I

Re: staging: pi433: Possible bug in rf69.c

2017-11-11 Thread Joe Perches
On Fri, 2017-11-10 at 18:23 +0100, Marcus Wolf wrote: > Hi everybody! > > Just comparing the master of Gregs statging of pi433 with my local SVN > to review all changes, that were done the last monthes. > > I am not sure, but maybe we imported a bug in rf69.c lines 378 and > following: > > Gregs

Re: staging: pi433: Possible bug in rf69.c

2017-11-11 Thread Greg Kroah-Hartman
On Sat, Nov 11, 2017 at 01:51:10PM +0200, Marcus Wolf wrote: > Hi Greg, > > ok. > > I'll postpone all my work until then. Give me a hook, when I can start :-) I am not going to remember, sorry, I deal with over 1000 patches a week. Just watch kernel.org for when the new kernel is released. than

Re: staging: pi433: Possible bug in rf69.c

2017-11-11 Thread Dan Carpenter
On Sat, Nov 11, 2017 at 11:42:09AM +0200, Marcus Wolf wrote: > But I still need to know when to use staging and when to use linux-next. > I don't want to prepare patches for the wrong tree. Ah, I see now that the confusion is Al's patch. Al is a law unto himself so I don't know the answer. Norma

Re: staging: pi433: Possible bug in rf69.c

2017-11-11 Thread Marcus Wolf
Hi Greg, ok. I'll postpone all my work until then. Give me a hook, when I can start :-) Thanks, Marcus Am 11.11.2017 um 13:49 schrieb Greg Kroah-Hartman: On Sat, Nov 11, 2017 at 01:42:27PM +0200, Marcus Wolf wrote: Hi Greg, that's fine. Is this the right URL: git://git.kernel.org/pub/s

Re: staging: pi433: Possible bug in rf69.c

2017-11-11 Thread Greg Kroah-Hartman
On Sat, Nov 11, 2017 at 01:42:27PM +0200, Marcus Wolf wrote: > Hi Greg, > > that's fine. > > Is this the right URL: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git Yes. > Is there already an aprox. date, when 4.15rc1 will be out and > backintegration will be done? Should be

Re: staging: pi433: Possible bug in rf69.c

2017-11-11 Thread Marcus Wolf
Hi Greg, that's fine. Is this the right URL: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git Is there already an aprox. date, when 4.15rc1 will be out and backintegration will be done? Thx, Marcus Am 11.11.2017 um 13:18 schrieb Greg Kroah-Hartman: On Sat, Nov 11, 2017 a

Re: staging: pi433: Possible bug in rf69.c

2017-11-11 Thread Greg Kroah-Hartman
On Sat, Nov 11, 2017 at 11:42:09AM +0200, Marcus Wolf wrote: > Hi Dan, > > thanks fot the link. I can't remeber, why and what I wanted to redo. Maybe > there was a complaint about the format of the patch... > > In that patch, we also have the topic with the '>> 3', we were discussing a > few days

Re: staging: pi433: Possible bug in rf69.c

2017-11-11 Thread Marcus Wolf
Hi Dan, thanks fot the link. I can't remeber, why and what I wanted to redo. Maybe there was a complaint about the format of the patch... In that patch, we also have the topic with the '>> 3', we were discussing a few days ago! I'd suggest, not to invest the history any more. I'm ok with pr

Re: staging: pi433: Possible bug in rf69.c

2017-11-11 Thread Dan Carpenter
On Sat, Nov 11, 2017 at 08:55:30AM +0100, Marcus Wolf wrote: > Hi Dan, > > I checked it on my local SVN. You are right. I submitted the code with '&'. > Accodring to a check-in message on my SVN, there was a bugreport end of > July and most probably a patch - either from me, you, Joseph Wright, >

Re: staging: pi433: Possible bug in rf69.c

2017-11-11 Thread Dan Carpenter
On Sat, Nov 11, 2017 at 08:55:30AM +0100, Marcus Wolf wrote: > Shortly befor I fell ill, you proposed me to use Gregs staging for my > further development. But Colin yesterday was working on a repo, called > linux-next. > > Can you (or anyone else) please tell me, when (or for which kind of > patc

Re: staging: pi433: Possible bug in rf69.c

2017-11-10 Thread Marcus Wolf
Hi Dan, I checked it on my local SVN. You are right. I submitted the code with '&'. Accodring to a check-in message on my SVN, there was a bugreport end of July and most probably a patch - either from me, you, Joseph Wright, Colin King or Julia Lawall, changing '&' to '|'. I guess the patch for so

Re: staging: pi433: Possible bug in rf69.c

2017-11-10 Thread Dan Carpenter
On Fri, Nov 10, 2017 at 06:23:32PM +0100, Marcus Wolf wrote: > Hi everybody! > > Just comparing the master of Gregs statging of pi433 with my local SVN > to review all changes, that were done the last monthes. > > I am not sure, but maybe we imported a bug in rf69.c lines 378 and > following: >

staging: pi433: Possible bug in rf69.c

2017-11-10 Thread Marcus Wolf
Hi everybody! Just comparing the master of Gregs statging of pi433 with my local SVN to review all changes, that were done the last monthes. I am not sure, but maybe we imported a bug in rf69.c lines 378 and following: Gregs repo: case automatic: return WRITE_REG(REG_LNA, ( (READ_REG(RE