Re: [PATCH] Re: sparse breakage triggered by rcu_read_lock() lockdep annotations

2007-10-20 Thread Josh Triplett
Christopher Li wrote: > OK, I get a trivial fix after all. The test case is fixed now. > I haven't done much test otherwise. > > See the patch attached. Nice work Chris! Patch applied and pushed out. I may roll an 0.4.1 release in the near future to fix kernel builds with Sparse. - Josh Triple

[PATCH] Re: sparse breakage triggered by rcu_read_lock() lockdep annotations

2007-10-19 Thread Christopher Li
OK, I get a trivial fix after all. The test case is fixed now. I haven't done much test otherwise. See the patch attached. Chris On 10/19/07, Chris Li <[EMAIL PROTECTED]> wrote: > Err, > > Sparse does not support the local label syntax yet. It just treats the > second label "x:" as the same as

Re: sparse breakage triggered by rcu_read_lock() lockdep annotations

2007-10-19 Thread Chris Li
Err, Sparse does not support the local label syntax yet. It just treats the second label "x:" as the same as the first one. Then the linearize code gets serious confused when it saw one label get define in two places. The fix seems not trivial from the first look. Chris On 10/16/07, Alexey Dobr

Re: sparse breakage triggered by rcu_read_lock() lockdep annotations

2007-10-18 Thread Josh Triplett
Alexey Dobriyan wrote: > FWIW, commit 851a67b825540a8e00c0be3ee25e4627ba8b133b > aka "lockdep: annotate rcu_read_{,un}lock{,_bh}" > causes sparse to trigger internal assertion in quite a few places over > allyesconfig run. > > sparse: flow.c:805: rewrite_parent_branch: Assertion `changed' fa

sparse breakage triggered by rcu_read_lock() lockdep annotations

2007-10-16 Thread Alexey Dobriyan
FWIW, commit 851a67b825540a8e00c0be3ee25e4627ba8b133b aka "lockdep: annotate rcu_read_{,un}lock{,_bh}" causes sparse to trigger internal assertion in quite a few places over allyesconfig run. sparse: flow.c:805: rewrite_parent_branch: Assertion `changed' failed. Trimmed down testcase: