Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump

2021-02-14 Thread Jassi Brar
On Thu, Jan 7, 2021 at 7:48 PM Yongqiang Niu wrote: > > On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote: > > Add address shift when compose jump instruction > > to compatible with 35bit format. > > > > Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform") > > > > Signe

Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump

2021-01-31 Thread Matthias Brugger
On 08/01/2021 02:48, Yongqiang Niu wrote: > On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote: >> Add address shift when compose jump instruction >> to compatible with 35bit format. >> >> Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform") >> >> Signed-off-by: Yongqi

Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump

2021-01-07 Thread Yongqiang Niu
On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote: > Add address shift when compose jump instruction > to compatible with 35bit format. > > Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform") > > Signed-off-by: Yongqiang Niu > Reviewed-by: Nicolas Boichat > --- > d

soc: mediatek: cmdq: add address shift in jump

2020-12-23 Thread Yongqiang Niu
Change since v1: -move out from mt8192 seri series Yongqiang Niu (1): soc: mediatek: cmdq: add address shift in jump drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 1.8.1.1.dirty

[PATCH v2] soc: mediatek: cmdq: add address shift in jump

2020-12-23 Thread Yongqiang Niu
Add address shift when compose jump instruction to compatible with 35bit format. Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform") Signed-off-by: Yongqiang Niu Reviewed-by: Nicolas Boichat --- drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++- 1 file changed, 2 insertions(+)

Re: [PATCH v1, 4/5] soc: mediatek: cmdq: add address shift in jump

2020-12-22 Thread Yongqiang Niu
On Wed, 2020-12-09 at 23:16 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Nicolas Boichat 於 2020年12月5日 週六 下午3:30寫道: > > > > On Sat, Dec 5, 2020 at 12:16 PM Yongqiang Niu > > wrote: > > > > > > Add address shift when compose jump instruction > > > to compatible with 35bit format. > > > > This

Re: [PATCH v1, 4/5] soc: mediatek: cmdq: add address shift in jump

2020-12-09 Thread Chun-Kuang Hu
Hi, Yongqiang: Nicolas Boichat 於 2020年12月5日 週六 下午3:30寫道: > > On Sat, Dec 5, 2020 at 12:16 PM Yongqiang Niu > wrote: > > > > Add address shift when compose jump instruction > > to compatible with 35bit format. > > This looks reasonable, but task->cmdq->shift_pa is not new and was > introduced as

Re: [PATCH v1, 4/5] soc: mediatek: cmdq: add address shift in jump

2020-12-04 Thread Nicolas Boichat
On Sat, Dec 5, 2020 at 12:16 PM Yongqiang Niu wrote: > > Add address shift when compose jump instruction > to compatible with 35bit format. This looks reasonable, but task->cmdq->shift_pa is not new and was introduced as part of mt6779 GCE support. Do you want to add a Fixes tag? Fixes: 0858fde4

[PATCH v1, 4/5] soc: mediatek: cmdq: add address shift in jump

2020-12-04 Thread Yongqiang Niu
Add address shift when compose jump instruction to compatible with 35bit format. Signed-off-by: Yongqiang Niu --- drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c inde

Re: [PATCH v3 1/9] soc: mediatek: cmdq: add address shift in jump

2020-09-21 Thread Matthias Brugger
On 07/07/2020 17:45, Dennis YC Hsieh wrote: Add address shift when compose jump instruction to compatible with 35bit format. Change since v1: - Rename cmdq_mbox_shift() to cmdq_get_shift_pa(). Signed-off-by: Dennis YC Hsieh Now pushed to v5.9-next/soc Thanks! --- drivers/soc/mediatek

Re: [PATCH v3 1/9] soc: mediatek: cmdq: add address shift in jump

2020-07-08 Thread Bibby Hsieh
Reviewed-by: Bibby Hsieh On Tue, 2020-07-07 at 23:45 +0800, Dennis YC Hsieh wrote: > Add address shift when compose jump instruction > to compatible with 35bit format. > > Change since v1: > - Rename cmdq_mbox_shift() to cmdq_get_shift_pa(). > > Signed-off-by: Dennis YC Hsieh > --- > drivers

[PATCH v3 1/9] soc: mediatek: cmdq: add address shift in jump

2020-07-07 Thread Dennis YC Hsieh
Add address shift when compose jump instruction to compatible with 35bit format. Change since v1: - Rename cmdq_mbox_shift() to cmdq_get_shift_pa(). Signed-off-by: Dennis YC Hsieh --- drivers/soc/mediatek/mtk-cmdq-helper.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

Re: [PATCH v2 1/8] soc: mediatek: cmdq: add address shift in jump

2020-07-06 Thread Dennis-YC Hsieh
Hi Matthias, thanks for your comment On Mon, 2020-07-06 at 16:03 +0200, Matthias Brugger wrote: > > On 05/07/2020 08:48, Dennis YC Hsieh wrote: > > Add address shift when compose jump instruction > > to compatible with 35bit format. > > > > Signed-off-by: Dennis YC Hsieh > > You are missing B

Re: [PATCH v2 1/8] soc: mediatek: cmdq: add address shift in jump

2020-07-06 Thread Matthias Brugger
On 05/07/2020 08:48, Dennis YC Hsieh wrote: > Add address shift when compose jump instruction > to compatible with 35bit format. > > Signed-off-by: Dennis YC Hsieh You are missing Bibby's Reviewed-by. Please honour the effort reviewers do by adding the appropriate tags. Please double check t

[PATCH v2 1/8] soc: mediatek: cmdq: add address shift in jump

2020-07-04 Thread Dennis YC Hsieh
Add address shift when compose jump instruction to compatible with 35bit format. Signed-off-by: Dennis YC Hsieh --- drivers/soc/mediatek/mtk-cmdq-helper.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-c

Re: [PATCH v1 01/11] soc: mediatek: cmdq: add address shift in jump

2020-06-21 Thread Bibby Hsieh
Reviewed-by: Bibby Hsieh Thanks. On Sun, 2020-06-21 at 22:18 +0800, Dennis YC Hsieh wrote: > Add address shift when compose jump instruction > to compatible with 35bit format. > > Signed-off-by: Dennis YC Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c |3 ++- > 1 file changed, 2 ins

[PATCH v1 01/11] soc: mediatek: cmdq: add address shift in jump

2020-06-21 Thread Dennis YC Hsieh
Add address shift when compose jump instruction to compatible with 35bit format. Signed-off-by: Dennis YC Hsieh --- drivers/soc/mediatek/mtk-cmdq-helper.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-c

[PATCH v6 06/16] soc: mediatek: cmdq: add address shift in jump

2020-05-28 Thread Dennis YC Hsieh
Add address shift when compose jump instruction to compatible with 35bit format. Signed-off-by: Dennis YC Hsieh --- drivers/soc/mediatek/mtk-cmdq-helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq