Re: sched: Reenable interrupts in do sched_yield()

2020-12-23 Thread Qais Yousef
On 10/21/20 10:07, Steven Rostedt wrote: > On Wed, 21 Oct 2020 09:27:22 +0200 > Thomas Gleixner wrote: > > > On Tue, Oct 20 2020 at 16:07, Steven Rostedt wrote: > > > On Tue, 20 Oct 2020 20:02:55 +0200 > > > Thomas Gleixner wrote: > > > What I wrote wasn't exactly what I meant. What I meant to h

Re: sched: Reenable interrupts in do sched_yield()

2020-10-21 Thread Steven Rostedt
On Wed, 21 Oct 2020 09:27:22 +0200 Thomas Gleixner wrote: > On Tue, Oct 20 2020 at 16:07, Steven Rostedt wrote: > > On Tue, 20 Oct 2020 20:02:55 +0200 > > Thomas Gleixner wrote: > > What I wrote wasn't exactly what I meant. What I meant to have: > > > > /* > > * Since we are going to ca

Re: sched: Reenable interrupts in do sched_yield()

2020-10-21 Thread Thomas Gleixner
On Tue, Oct 20 2020 at 16:07, Steven Rostedt wrote: > On Tue, 20 Oct 2020 20:02:55 +0200 > Thomas Gleixner wrote: > What I wrote wasn't exactly what I meant. What I meant to have: > > /* >* Since we are going to call schedule() anyways, there's >* no need to do the preemption

Re: sched: Reenable interrupts in do sched_yield()

2020-10-20 Thread Steven Rostedt
On Tue, 20 Oct 2020 20:02:55 +0200 Thomas Gleixner wrote: > On Tue, Oct 20 2020 at 11:38, Steven Rostedt wrote: > > On Tue, 20 Oct 2020 16:46:55 +0200 > > Thomas Gleixner wrote: > > > >> - /* > >> - * Since we are going to call schedule() anyway, there's > >> - * no need to preempt or ena

Re: sched: Reenable interrupts in do sched_yield()

2020-10-20 Thread Thomas Gleixner
On Tue, Oct 20 2020 at 11:38, Steven Rostedt wrote: > On Tue, 20 Oct 2020 16:46:55 +0200 > Thomas Gleixner wrote: > >> -/* >> - * Since we are going to call schedule() anyway, there's >> - * no need to preempt or enable interrupts: > > I think the above comment still makes sense, just

Re: sched: Reenable interrupts in do sched_yield()

2020-10-20 Thread Steven Rostedt
On Tue, 20 Oct 2020 16:46:55 +0200 Thomas Gleixner wrote: > - /* > - * Since we are going to call schedule() anyway, there's > - * no need to preempt or enable interrupts: I think the above comment still makes sense, just needs to be tweeked: /* * Since we are goi

sched: Reenable interrupts in do sched_yield()

2020-10-20 Thread Thomas Gleixner
do_sched_yield() invokes schedule() with interrupts disabled which is not allowed. This goes back to the pre git era to commit a6efb709806c ("[PATCH] irqlock patch 2.5.27-H6") in the history tree. Reenable interrupts and remove the misleading comment which "explains" it. Fixes: 1da177e4c3f4 ("Lin