Re: save_xstate_sig (Re: frequent lockups in 3.18rc4)

2014-12-18 Thread Andy Lutomirski
On Thu, Dec 18, 2014 at 1:34 PM, Linus Torvalds wrote: > On Thu, Dec 18, 2014 at 1:17 PM, Andy Lutomirski wrote: >> >> I admit that my understanding of the disaster that is x86's FPU handling is >> limited, but I'm moderately confident that save_xstate_sig is broken. > > Very possible. The FPU co

Re: save_xstate_sig (Re: frequent lockups in 3.18rc4)

2014-12-18 Thread Dave Jones
On Thu, Dec 18, 2014 at 01:17:59PM -0800, Andy Lutomirski wrote: > FWIW, if xsave traps with cr2 value, then there would indeed be an > infinite loop in here. It seems to work right on my machine. Dave, > want to run the attached little test? XSAVE to offset 0 [OK]xsave offset = 0, cr2

Re: save_xstate_sig (Re: frequent lockups in 3.18rc4)

2014-12-18 Thread Linus Torvalds
On Thu, Dec 18, 2014 at 1:17 PM, Andy Lutomirski wrote: > > I admit that my understanding of the disaster that is x86's FPU handling is > limited, but I'm moderately confident that save_xstate_sig is broken. Very possible. The FPU code *is* nasty. > The code is: > > if (user_has_fpu()) {

save_xstate_sig (Re: frequent lockups in 3.18rc4)

2014-12-18 Thread Andy Lutomirski
On 12/14/2014 09:47 PM, Linus Torvalds wrote: On Sun, Dec 14, 2014 at 4:38 PM, Linus Torvalds wrote: Can anybody make sense of that backtrace, keeping in mind that we're looking for some kind of endless loop where we don't make progress? So looking at all the backtraces, which is kind of mes