Re: [PATCH v4 -mm] rework mem_cgroup iterator

2013-03-13 Thread Michal Hocko
Hi Andrew, it seems that there were no other objections[1] to this version of the patchset. Could you take it into your tree and target it for 3.10? --- [1] The only one from Johannes (https://lkml.org/lkml/2013/2/8/379) has been addressed On Thu 14-02-13 14:26:30, Michal Hocko wrote: > Hi, > thi

[PATCH v4 -mm] rework mem_cgroup iterator

2013-02-14 Thread Michal Hocko
Hi, this is a fourth iteration of the patch series previously posted here: http://lkml.org/lkml/2013/1/3/293. I am adding Andrew to the CC as I feel this is getting to the acceptable state finally. It still need review as some things changed a lot since the last version but we are getting there...

Re: [PATCH v3 0/7] rework mem_cgroup iterator

2013-01-23 Thread Michal Hocko
Are there any comments? Ying, Johannes? I would be happy if this could go into 3.9. On Thu 03-01-13 18:54:14, Michal Hocko wrote: > Hi all, > this is a third version of the patchset previously posted here: > https://lkml.org/lkml/2012/11/26/616 > > The patch set tries to make mem_cgroup_iter sane

[PATCH v3 0/7] rework mem_cgroup iterator

2013-01-03 Thread Michal Hocko
Hi all, this is a third version of the patchset previously posted here: https://lkml.org/lkml/2012/11/26/616 The patch set tries to make mem_cgroup_iter saner in the way how it walks hierarchies. css->id based traversal is far from being ideal as it is not deterministic because it depends on the c

rework mem_cgroup iterator

2012-11-26 Thread Michal Hocko
Hi all, this is a second version of the patchset previously posted here: https://lkml.org/lkml/2012/11/13/335 The patch set tries to make mem_cgroup_iter saner in the way how it walks hierarchies. css->id based traversal is far from being ideal as it is not deterministic because it depends on the

Re: [RFC] rework mem_cgroup iterator

2012-11-14 Thread Kamezawa Hiroyuki
(2012/11/14 10:55), Li Zefan wrote: > On 2012/11/13 23:30, Michal Hocko wrote: >> Hi all, >> this patch set tries to make mem_cgroup_iter saner in the way how it >> walks hierarchies. css->id based traversal is far from being ideal as it >> is not deterministic because it depends on the creation or

Re: [RFC] rework mem_cgroup iterator

2012-11-14 Thread Tejun Heo
Hello, On Thu, Nov 15, 2012 at 06:44:57AM +0400, Glauber Costa wrote: > Is there any particular reason why we can't do the other way around > then, and use a for_each_*() for sched walks? Without even consider what > I personally prefer, what I really don't like is to have two different > cgroup w

Re: [RFC] rework mem_cgroup iterator

2012-11-14 Thread Glauber Costa
On 11/14/2012 10:41 PM, Tejun Heo wrote: > Hello, Glauber. > > On Wed, Nov 14, 2012 at 05:17:51PM +0100, Glauber Costa wrote: >> Why can't we reuse the scheduler iterator and move it to kernel/cgroup.c >> ? It already exists, provide sane ordering, and only relies on parent >> information - which

Re: [RFC] rework mem_cgroup iterator

2012-11-14 Thread Tejun Heo
Hello, Glauber. On Wed, Nov 14, 2012 at 05:17:51PM +0100, Glauber Costa wrote: > Why can't we reuse the scheduler iterator and move it to kernel/cgroup.c > ? It already exists, provide sane ordering, and only relies on parent > information - which cgroup core already have - to do the walk. Hmmm..

Re: [RFC] rework mem_cgroup iterator

2012-11-14 Thread Tejun Heo
Hello, Michal. On Wed, Nov 14, 2012 at 09:36:53AM +0100, Michal Hocko wrote: > > So memcg won't use css id at all, right? > > Unfortunately we still use it for the swap accounting but that one could > be replaced by something else, probably. Have to think about it. I have a patch to add cgrp->id

Re: [RFC] rework mem_cgroup iterator

2012-11-14 Thread Michal Hocko
On Wed 14-11-12 17:17:51, Glauber Costa wrote: [...] > Why can't we reuse the scheduler iterator and move it to kernel/cgroup.c? I do not care much about the internal implementation of the core iterators. Those implemented by Tejun make sense to me. I just want to get rid of css->id based ones. M

Re: [RFC] rework mem_cgroup iterator

2012-11-14 Thread Michal Hocko
On Wed 14-11-12 09:55:08, Li Zefan wrote: > On 2012/11/13 23:30, Michal Hocko wrote: > > Hi all, > > this patch set tries to make mem_cgroup_iter saner in the way how it > > walks hierarchies. css->id based traversal is far from being ideal as it > > is not deterministic because it depends on the c

Re: [RFC] rework mem_cgroup iterator

2012-11-14 Thread Glauber Costa
On 11/13/2012 04:30 PM, Michal Hocko wrote: > Hi all, > this patch set tries to make mem_cgroup_iter saner in the way how it > walks hierarchies. css->id based traversal is far from being ideal as it > is not deterministic because it depends on the creation ordering. > > Diffstat looks promising b

Re: [RFC] rework mem_cgroup iterator

2012-11-13 Thread Li Zefan
On 2012/11/13 23:30, Michal Hocko wrote: > Hi all, > this patch set tries to make mem_cgroup_iter saner in the way how it > walks hierarchies. css->id based traversal is far from being ideal as it > is not deterministic because it depends on the creation ordering. > > Diffstat looks promising but

Re: [RFC] rework mem_cgroup iterator

2012-11-13 Thread Kamezawa Hiroyuki
(2012/11/14 0:30), Michal Hocko wrote: > Hi all, > this patch set tries to make mem_cgroup_iter saner in the way how it > walks hierarchies. css->id based traversal is far from being ideal as it > is not deterministic because it depends on the creation ordering. > > Diffstat looks promising but it

[RFC] rework mem_cgroup iterator

2012-11-13 Thread Michal Hocko
Hi all, this patch set tries to make mem_cgroup_iter saner in the way how it walks hierarchies. css->id based traversal is far from being ideal as it is not deterministic because it depends on the creation ordering. Diffstat looks promising but it is fair the say that the biggest cleanup is just c