Re: Re: regulator: s2mps11: Question about the code updating ramp_delay setting

2013-08-05 Thread Mark Brown
On Mon, Aug 05, 2013 at 05:58:36AM +, Yadwinder Singh Brar wrote: > Samsung Enterprise Portal mySingle > Please fix your mailer to send plain text mails, or at least provide a text/plain alternative. signature.asc Description: Digital signature

regulator: s2mps11: Question about the code updating ramp_delay setting

2013-08-03 Thread Axel Lin
Hi Yadwinder, The code updating ramp_delay setting looks wrong to me. Current code: return regmap_update_bits(rdev->regmap, ramp_reg, ramp_val << ramp_shift, 1 << ramp_shift); I'd expect something like below: return regmap_update_bits(rdev->regmap,