Re: xfs: cancel dfops on xfs_defer_finish() error

2018-08-07 Thread Brian Foster
On Tue, Aug 07, 2018 at 08:26:44AM -0700, Darrick J. Wong wrote: > On Tue, Aug 07, 2018 at 11:18:36AM -0400, Brian Foster wrote: > > On Tue, Aug 07, 2018 at 08:10:29AM -0700, Darrick J. Wong wrote: > > > On Tue, Aug 07, 2018 at 10:37:21AM -0400, Brian Foster wrote: > > > > On Tue, Aug 07, 2018 at 0

Re: xfs: cancel dfops on xfs_defer_finish() error

2018-08-07 Thread Darrick J. Wong
On Tue, Aug 07, 2018 at 11:18:36AM -0400, Brian Foster wrote: > On Tue, Aug 07, 2018 at 08:10:29AM -0700, Darrick J. Wong wrote: > > On Tue, Aug 07, 2018 at 10:37:21AM -0400, Brian Foster wrote: > > > On Tue, Aug 07, 2018 at 03:14:07PM +0100, Colin Ian King wrote: > > > > Hi, > > > > > > > > Recen

Re: xfs: cancel dfops on xfs_defer_finish() error

2018-08-07 Thread Brian Foster
On Tue, Aug 07, 2018 at 08:10:29AM -0700, Darrick J. Wong wrote: > On Tue, Aug 07, 2018 at 10:37:21AM -0400, Brian Foster wrote: > > On Tue, Aug 07, 2018 at 03:14:07PM +0100, Colin Ian King wrote: > > > Hi, > > > > > > Recent commit 82ff27bc52a88cb5cc400bfa64e210d3ec8dfebd ("xfs: automatic > > > d

Re: xfs: cancel dfops on xfs_defer_finish() error

2018-08-07 Thread Darrick J. Wong
On Tue, Aug 07, 2018 at 10:37:21AM -0400, Brian Foster wrote: > On Tue, Aug 07, 2018 at 03:14:07PM +0100, Colin Ian King wrote: > > Hi, > > > > Recent commit 82ff27bc52a88cb5cc400bfa64e210d3ec8dfebd ("xfs: automatic > > dfops buffer relogging") removed the assignment of variable error: > > > > -

Re: xfs: cancel dfops on xfs_defer_finish() error

2018-08-07 Thread Brian Foster
On Tue, Aug 07, 2018 at 03:14:07PM +0100, Colin Ian King wrote: > Hi, > > Recent commit 82ff27bc52a88cb5cc400bfa64e210d3ec8dfebd ("xfs: automatic > dfops buffer relogging") removed the assignment of variable error: > > - error = xfs_defer_bjoin(tp->t_dfops, bp); > if (error) { >

re: xfs: cancel dfops on xfs_defer_finish() error

2018-08-07 Thread Colin Ian King
Hi, Recent commit 82ff27bc52a88cb5cc400bfa64e210d3ec8dfebd ("xfs: automatic dfops buffer relogging") removed the assignment of variable error: - error = xfs_defer_bjoin(tp->t_dfops, bp); if (error) { xfs_trans_bhold_release(tp, bp); xfs_trans_brelse(t