Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Darren Hart
On 07/18/2012 11:01 AM, Dave Jones wrote: > On Wed, Jul 18, 2012 at 09:03:22AM -0700, Darren Hart wrote: > > > > This will oops if pi_mutex is NULL. > > > > > > 2374 rt_mutex_unlock(pi_mutex); > > > 2375 } else if (ret == -EINTR) { > > > > Nice Dan,

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Dave Jones
On Wed, Jul 18, 2012 at 09:03:22AM -0700, Darren Hart wrote: > > This will oops if pi_mutex is NULL. > > > > 2374 rt_mutex_unlock(pi_mutex); > > 2375 } else if (ret == -EINTR) { > > Nice Dan, thanks for taking a closer look. This appears to be a simpl

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Darren Hart
On 07/18/2012 07:25 AM, Dan Carpenter wrote: > Hi Darren, > > The patch 52400ba94675: "futex: add requeue_pi functionality" from > Apr 3, 2009, leads to the following warning: > kernel/futex.c:2373 futex_wait_requeue_pi() >error: potential NULL dereference 'pi_mutex'. > > 2330

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Dan Carpenter
On Wed, Jul 18, 2012 at 08:41:38AM -0700, Darren Hart wrote: > > > On 07/18/2012 08:31 AM, Dave Jones wrote: > > On Wed, Jul 18, 2012 at 05:25:14PM +0300, Dan Carpenter wrote: > > > Hi Darren, > > > > > > The patch 52400ba94675: "futex: add requeue_pi functionality" from > > > Apr 3, 2009, l

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Darren Hart
On 07/18/2012 08:31 AM, Dave Jones wrote: > On Wed, Jul 18, 2012 at 05:25:14PM +0300, Dan Carpenter wrote: > > Hi Darren, > > > > The patch 52400ba94675: "futex: add requeue_pi functionality" from > > Apr 3, 2009, leads to the following warning: > > kernel/futex.c:2373 futex_wait_requeue_pi

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Dave Jones
On Wed, Jul 18, 2012 at 05:25:14PM +0300, Dan Carpenter wrote: > Hi Darren, > > The patch 52400ba94675: "futex: add requeue_pi functionality" from > Apr 3, 2009, leads to the following warning: > kernel/futex.c:2373 futex_wait_requeue_pi() > error: potential NULL dereference 'pi_mutex'

potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Dan Carpenter
Hi Darren, The patch 52400ba94675: "futex: add requeue_pi functionality" from Apr 3, 2009, leads to the following warning: kernel/futex.c:2373 futex_wait_requeue_pi() error: potential NULL dereference 'pi_mutex'. 2330 if (!q.rt_waiter) { 2331 /* 2332