Re: pidfd design

2019-03-28 Thread Christian Brauner
On Mon, Mar 25, 2019 at 05:24:49PM -0700, Andy Lutomirski wrote: > On Mon, Mar 25, 2019 at 5:12 PM Christian Brauner > wrote: > > > > On Mon, Mar 25, 2019 at 05:00:17PM -0700, Andy Lutomirski wrote: > > > On Mon, Mar 25, 2019 at 4:45 PM Christian Brauner > > > wrote: > > > > > > > > On Mon, Mar

Re: pidfd design

2019-03-25 Thread Andy Lutomirski
On Mon, Mar 25, 2019 at 5:12 PM Christian Brauner wrote: > > On Mon, Mar 25, 2019 at 05:00:17PM -0700, Andy Lutomirski wrote: > > On Mon, Mar 25, 2019 at 4:45 PM Christian Brauner > > wrote: > > > > > > On Mon, Mar 25, 2019 at 04:42:14PM -0700, Andy Lutomirski wrote: > > > > On Mon, Mar 25, 2019

Re: pidfd design

2019-03-25 Thread Christian Brauner
On Mon, Mar 25, 2019 at 05:00:17PM -0700, Andy Lutomirski wrote: > On Mon, Mar 25, 2019 at 4:45 PM Christian Brauner > wrote: > > > > On Mon, Mar 25, 2019 at 04:42:14PM -0700, Andy Lutomirski wrote: > > > On Mon, Mar 25, 2019 at 1:23 PM Daniel Colascione > > > wrote: > > > > > > > > On Mon, Mar

Re: pidfd design

2019-03-25 Thread Andy Lutomirski
On Mon, Mar 25, 2019 at 4:45 PM Christian Brauner wrote: > > On Mon, Mar 25, 2019 at 04:42:14PM -0700, Andy Lutomirski wrote: > > On Mon, Mar 25, 2019 at 1:23 PM Daniel Colascione wrote: > > > > > > On Mon, Mar 25, 2019 at 1:14 PM Jann Horn wrote: > > > > > > > > On Mon, Mar 25, 2019 at 8:44 PM

Re: pidfd design

2019-03-25 Thread Christian Brauner
On Mon, Mar 25, 2019 at 04:42:14PM -0700, Andy Lutomirski wrote: > On Mon, Mar 25, 2019 at 1:23 PM Daniel Colascione wrote: > > > > On Mon, Mar 25, 2019 at 1:14 PM Jann Horn wrote: > > > > > > On Mon, Mar 25, 2019 at 8:44 PM Andy Lutomirski wrote: > > > > One ioctl on procfs roots to translate

Re: pidfd design

2019-03-25 Thread Andy Lutomirski
On Mon, Mar 25, 2019 at 1:23 PM Daniel Colascione wrote: > > On Mon, Mar 25, 2019 at 1:14 PM Jann Horn wrote: > > > > On Mon, Mar 25, 2019 at 8:44 PM Andy Lutomirski wrote: > > One ioctl on procfs roots to translate pidfds into that procfs, > > subject to both the normal lookup permission check

Re: pidfd design

2019-03-25 Thread Christian Brauner
On Mon, Mar 25, 2019 at 10:45:29AM -0700, Linus Torvalds wrote: > On Fri, Mar 22, 2019 at 11:34 AM Michael Tirado wrote: > > > > On Wed, Mar 20, 2019 at 8:08 PM Alexey Dobriyan wrote: > > > > > > pidfd code should be backed out immediately. Forget about /proc. > > > > Seems like Torvalds just mer

Re: pidfd design

2019-03-25 Thread Michael Tirado
On Mon, Mar 25, 2019 at 5:45 PM Linus Torvalds wrote: > > On Fri, Mar 22, 2019 at 11:34 AM Michael Tirado wrote: > > > > On Wed, Mar 20, 2019 at 8:08 PM Alexey Dobriyan wrote: > > > > > > pidfd code should be backed out immediately. Forget about /proc. > > > > Seems like Torvalds just merges thi

Re: pidfd design

2019-03-25 Thread Daniel Colascione
On Mon, Mar 25, 2019 at 1:14 PM Jann Horn wrote: > > On Mon, Mar 25, 2019 at 8:44 PM Andy Lutomirski wrote: > > On Wed, Mar 20, 2019 at 12:40 PM Daniel Colascione > > wrote: > > > On Wed, Mar 20, 2019 at 12:14 PM Christian Brauner > > > wrote: > > > > On Wed, Mar 20, 2019 at 11:58:57AM -0700,

Re: pidfd design

2019-03-25 Thread Jann Horn
On Mon, Mar 25, 2019 at 8:44 PM Andy Lutomirski wrote: > On Wed, Mar 20, 2019 at 12:40 PM Daniel Colascione wrote: > > On Wed, Mar 20, 2019 at 12:14 PM Christian Brauner > > wrote: > > > On Wed, Mar 20, 2019 at 11:58:57AM -0700, Andy Lutomirski wrote: > > > > On Wed, Mar 20, 2019 at 11:52 AM Ch

Re: pidfd design

2019-03-25 Thread Christian Brauner
On Fri, Mar 22, 2019 at 02:04:35PM +, Michael Tirado wrote: > On Wed, Mar 20, 2019 at 8:08 PM Alexey Dobriyan wrote: > > > > pidfd code should be backed out immediately. Forget about /proc. > > Seems like Torvalds just merges this sort of "stuff" without reading > it now, or there's something

Re: pidfd design

2019-03-25 Thread Linus Torvalds
On Fri, Mar 22, 2019 at 11:34 AM Michael Tirado wrote: > > On Wed, Mar 20, 2019 at 8:08 PM Alexey Dobriyan wrote: > > > > pidfd code should be backed out immediately. Forget about /proc. > > Seems like Torvalds just merges this sort of "stuff" without reading > it now, or there's something that a

Re: pidfd design

2019-03-24 Thread Joel Fernandes
On Sun, Mar 24, 2019 at 10:44 AM Serge E. Hallyn wrote: > > On Wed, Mar 20, 2019 at 12:29:31PM -0700, Daniel Colascione wrote: > > On Wed, Mar 20, 2019 at 11:52 AM Christian Brauner > > wrote: > > > I really want to see Joel's pidfd_wait() patchset and have more people > > > review the actual co

Re: pidfd design

2019-03-24 Thread Serge E. Hallyn
On Wed, Mar 20, 2019 at 12:29:31PM -0700, Daniel Colascione wrote: > On Wed, Mar 20, 2019 at 11:52 AM Christian Brauner > wrote: > > I really want to see Joel's pidfd_wait() patchset and have more people > > review the actual code. > > Sure. But it's also unpleasant to have people write code and

Re: pidfd design

2019-03-22 Thread Michael Tirado
On Wed, Mar 20, 2019 at 8:08 PM Alexey Dobriyan wrote: > > pidfd code should be backed out immediately. Forget about /proc. Seems like Torvalds just merges this sort of "stuff" without reading it now, or there's something that auto accepted pull request to RC tree? > The pull request you sent on

Re: pidfd design

2019-03-21 Thread Andy Lutomirski
On Wed, Mar 20, 2019 at 12:40 PM Daniel Colascione wrote: > > On Wed, Mar 20, 2019 at 12:14 PM Christian Brauner > wrote: > > > > On Wed, Mar 20, 2019 at 11:58:57AM -0700, Andy Lutomirski wrote: > > > On Wed, Mar 20, 2019 at 11:52 AM Christian Brauner > > > wrote: > > > > > > > > You're misund

Re: pidfd design

2019-03-20 Thread Christian Brauner
On Wed, Mar 20, 2019 at 01:50:43PM -0700, Daniel Colascione wrote: > On Wed, Mar 20, 2019 at 1:47 PM Christian Brauner > wrote: > > > > On Wed, Mar 20, 2019 at 11:39:10PM +0300, Alexey Dobriyan wrote: > > > On Wed, Mar 20, 2019 at 01:14:01PM -0700, Daniel Colascione wrote: > > > > On Wed, Mar 20,

Re: pidfd design

2019-03-20 Thread Daniel Colascione
On Wed, Mar 20, 2019 at 1:47 PM Christian Brauner wrote: > > On Wed, Mar 20, 2019 at 11:39:10PM +0300, Alexey Dobriyan wrote: > > On Wed, Mar 20, 2019 at 01:14:01PM -0700, Daniel Colascione wrote: > > > On Wed, Mar 20, 2019 at 1:07 PM Alexey Dobriyan > > > wrote: > > > > > What would be your opi

Re: pidfd design

2019-03-20 Thread Christian Brauner
On Wed, Mar 20, 2019 at 11:39:10PM +0300, Alexey Dobriyan wrote: > On Wed, Mar 20, 2019 at 01:14:01PM -0700, Daniel Colascione wrote: > > On Wed, Mar 20, 2019 at 1:07 PM Alexey Dobriyan wrote: > > > > What would be your opinion to having a > > > > /proc//handle > > > > file instead of having a dir

Re: pidfd design

2019-03-20 Thread Alexey Dobriyan
On Wed, Mar 20, 2019 at 01:14:01PM -0700, Daniel Colascione wrote: > On Wed, Mar 20, 2019 at 1:07 PM Alexey Dobriyan wrote: > > > What would be your opinion to having a > > > /proc//handle > > > file instead of having a dirfd. > > > > This is even worse than depending on PROC_FS. Just for the depe

Re: pidfd design

2019-03-20 Thread Daniel Colascione
On Wed, Mar 20, 2019 at 1:07 PM Alexey Dobriyan wrote: > > What would be your opinion to having a > > /proc//handle > > file instead of having a dirfd. > > This is even worse than depending on PROC_FS. Just for the dependency > pidfd code should be backed out immediately. Forget about /proc. We a

Re: pidfd design

2019-03-20 Thread Alexey Dobriyan
> What would be your opinion to having a > /proc//handle > file instead of having a dirfd. This is even worse than depending on PROC_FS. Just for the dependency pidfd code should be backed out immediately. Forget about /proc.

Re: pidfd design

2019-03-20 Thread Daniel Colascione
On Wed, Mar 20, 2019 at 12:14 PM Christian Brauner wrote: > > On Wed, Mar 20, 2019 at 11:58:57AM -0700, Andy Lutomirski wrote: > > On Wed, Mar 20, 2019 at 11:52 AM Christian Brauner > > wrote: > > > > > > You're misunderstanding. Again, I said in my previous mails it should > > > accept pidfds o

Re: pidfd design

2019-03-20 Thread Daniel Colascione
On Wed, Mar 20, 2019 at 11:52 AM Christian Brauner wrote: > > On Wed, Mar 20, 2019 at 11:38:35AM -0700, Daniel Colascione wrote: > > On Wed, Mar 20, 2019 at 11:26 AM Christian Brauner > > wrote: > > > On Wed, Mar 20, 2019 at 07:33:51AM -0400, Joel Fernandes wrote: > > > > > > > > > > > > On Marc

Re: pidfd design

2019-03-20 Thread Joel Fernandes
On Wed, Mar 20, 2019 at 07:51:57PM +0100, Christian Brauner wrote: [snip] > > > translate_pid() should just return you a pidfd. Having it return a pidfd > > > and a status fd feels like stuffing too much functionality in there. If > > > you're fine with it I'll finish prototyping what I had in mind

Re: pidfd design

2019-03-20 Thread Christian Brauner
On Wed, Mar 20, 2019 at 11:58:57AM -0700, Andy Lutomirski wrote: > On Wed, Mar 20, 2019 at 11:52 AM Christian Brauner > wrote: > > > > You're misunderstanding. Again, I said in my previous mails it should > > accept pidfds optionally as arguments, yes. But I don't want it to > > return the status

Re: pidfd design

2019-03-20 Thread Joel Fernandes
On Wed, Mar 20, 2019 at 07:26:50PM +0100, Christian Brauner wrote: > On Wed, Mar 20, 2019 at 07:33:51AM -0400, Joel Fernandes wrote: > > > > > > On March 20, 2019 3:02:32 AM EDT, Daniel Colascione > > wrote: > > >On Tue, Mar 19, 2019 at 8:59 PM Christian Brauner > > > wrote: > > >> > > >> On Tu

Re: pidfd design

2019-03-20 Thread Andy Lutomirski
On Wed, Mar 20, 2019 at 11:52 AM Christian Brauner wrote: > > You're misunderstanding. Again, I said in my previous mails it should > accept pidfds optionally as arguments, yes. But I don't want it to > return the status fds that you previously wanted pidfd_wait() to return. > I really want to see

Re: pidfd design

2019-03-20 Thread Christian Brauner
On Wed, Mar 20, 2019 at 11:38:35AM -0700, Daniel Colascione wrote: > On Wed, Mar 20, 2019 at 11:26 AM Christian Brauner > wrote: > > On Wed, Mar 20, 2019 at 07:33:51AM -0400, Joel Fernandes wrote: > > > > > > > > > On March 20, 2019 3:02:32 AM EDT, Daniel Colascione > > > wrote: > > > >On Tue,

Re: pidfd design

2019-03-20 Thread Daniel Colascione
On Wed, Mar 20, 2019 at 11:26 AM Christian Brauner wrote: > On Wed, Mar 20, 2019 at 07:33:51AM -0400, Joel Fernandes wrote: > > > > > > On March 20, 2019 3:02:32 AM EDT, Daniel Colascione > > wrote: > > >On Tue, Mar 19, 2019 at 8:59 PM Christian Brauner > > > wrote: > > >> > > >> On Tue, Mar 19,

Re: pidfd design

2019-03-20 Thread Christian Brauner
On Wed, Mar 20, 2019 at 07:33:51AM -0400, Joel Fernandes wrote: > > > On March 20, 2019 3:02:32 AM EDT, Daniel Colascione wrote: > >On Tue, Mar 19, 2019 at 8:59 PM Christian Brauner > > wrote: > >> > >> On Tue, Mar 19, 2019 at 07:42:52PM -0700, Daniel Colascione wrote: > >> > On Tue, Mar 19, 201

Re: pidfd design

2019-03-20 Thread Joel Fernandes
On March 20, 2019 3:02:32 AM EDT, Daniel Colascione wrote: >On Tue, Mar 19, 2019 at 8:59 PM Christian Brauner > wrote: >> >> On Tue, Mar 19, 2019 at 07:42:52PM -0700, Daniel Colascione wrote: >> > On Tue, Mar 19, 2019 at 6:52 PM Joel Fernandes > wrote: >> > > >> > > On Wed, Mar 20, 2019 at 12:1

Re: pidfd design

2019-03-20 Thread Daniel Colascione
On Tue, Mar 19, 2019 at 8:59 PM Christian Brauner wrote: > > On Tue, Mar 19, 2019 at 07:42:52PM -0700, Daniel Colascione wrote: > > On Tue, Mar 19, 2019 at 6:52 PM Joel Fernandes > > wrote: > > > > > > On Wed, Mar 20, 2019 at 12:10:23AM +0100, Christian Brauner wrote: > > > > On Tue, Mar 19, 201

Re: pidfd design

2019-03-19 Thread Christian Brauner
On Tue, Mar 19, 2019 at 07:42:52PM -0700, Daniel Colascione wrote: > On Tue, Mar 19, 2019 at 6:52 PM Joel Fernandes wrote: > > > > On Wed, Mar 20, 2019 at 12:10:23AM +0100, Christian Brauner wrote: > > > On Tue, Mar 19, 2019 at 03:48:32PM -0700, Daniel Colascione wrote: > > > > On Tue, Mar 19, 201

pidfd design

2019-03-19 Thread Daniel Colascione
On Tue, Mar 19, 2019 at 6:52 PM Joel Fernandes wrote: > > On Wed, Mar 20, 2019 at 12:10:23AM +0100, Christian Brauner wrote: > > On Tue, Mar 19, 2019 at 03:48:32PM -0700, Daniel Colascione wrote: > > > On Tue, Mar 19, 2019 at 3:14 PM Christian Brauner > > > wrote: > > > > So I dislike the idea o