Re: perf: Add support for full Intel event lists v8

2014-11-25 Thread Jiri Olsa
On Mon, Nov 24, 2014 at 02:37:36PM -0800, Sukadev Bhattiprolu wrote: > Andi Kleen [a...@firstfloor.org] wrote: > > | Since it seems the download mechanism is controversal, > | I removed the downloader for now until a suitable distribution > | method with kernel.org can be established. This is jus

Re: perf: Add support for full Intel event lists v8

2014-11-24 Thread Sukadev Bhattiprolu
Andi Kleen [a...@firstfloor.org] wrote: | Since it seems the download mechanism is controversal, | I removed the downloader for now until a suitable distribution | method with kernel.org can be established. This is just | the rest of the perf JSON event code that should hopefully | not be controv

perf: Add support for full Intel event lists v8

2014-07-30 Thread Andi Kleen
Since it seems the download mechanism is controversal, I removed the downloader for now until a suitable distribution method with kernel.org can be established. This is just the rest of the perf JSON event code that should hopefully not be controversal. [v2: Review feedback addressed and some min

Re: perf: Add support for full Intel event lists v7

2014-07-18 Thread Michael Ellerman
On Fri, 2014-07-11 at 16:59 -0700, Andi Kleen wrote: > All feedback addressed. Hopefully ready for merge now. ... > The JSON format and perf parser has some minor Intelisms, but they > are simple and small and optional. It's easy to extend, so it would be > possible to use it for other CPUs too, a

perf: Add support for full Intel event lists v7

2014-07-11 Thread Andi Kleen
All feedback addressed. Hopefully ready for merge now. [v2: Review feedback addressed and some minor improvements] [v3: More review feedback addressed and handle test failures better. Ported to latest tip/core.] [v4: Addressed Namhyung's feedback] [v5: Rebase to latest tree. Minor description upda

Re: perf: Add support for full Intel event lists v7

2014-07-09 Thread Jiri Olsa
On Fri, Jun 27, 2014 at 04:15:55PM -0700, Andi Kleen wrote: > Should be ready for merge now. Please consider. > > [v2: Review feedback addressed and some minor improvements] > [v3: More review feedback addressed and handle test failures better. > Ported to latest tip/core.] > [v4: Addressed Namhyu

Re: perf: Add support for full Intel event lists v7

2014-07-08 Thread Sukadev Bhattiprolu
Andi Kleen [a...@firstfloor.org] wrote: | Works for me with your input file: | | % perf list --events-file t.json | ... | pm_cyc [Cycles completed] | pm_inst_cmpl [Instructions completed] Ah, lower case. | |

Re: perf: Add support for full Intel event lists v7

2014-07-08 Thread Andi Kleen
Thanks for testing. On Tue, Jul 08, 2014 at 11:43:11AM -0700, Sukadev Bhattiprolu wrote: > | The JSON format and perf parser has some minor Intelisms, but they > | are simple and small and optional. It's easy to extend, so it would be > | possible to use it for other CPUs too, add different pmu at

Re: perf: Add support for full Intel event lists v7

2014-07-08 Thread Sukadev Bhattiprolu
Andi Kleen [a...@firstfloor.org] wrote: | Should be ready for merge now. Please consider. Overall I think it is a cool feature. I was able to run some simple tests on Power8 (by explicitly specifying the JSON file). Have a couple of questions below. | | [v2: Review feedback addressed and some m

perf: Add support for full Intel event lists v7

2014-06-27 Thread Andi Kleen
Should be ready for merge now. Please consider. [v2: Review feedback addressed and some minor improvements] [v3: More review feedback addressed and handle test failures better. Ported to latest tip/core.] [v4: Addressed Namhyung's feedback] [v5: Rebase to latest tree. Minor description update.] [v

Re: perf: Add support for full Intel event lists v6

2014-06-16 Thread Hagen Paul Pfeifer
Hey Andi, Namhyung, intention was just to raise hands, later there is probably no possibility to change the command name without breaking scripts. Anyway, the whole mechanism is awesome! ;-) Hagen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: perf: Add support for full Intel event lists v6

2014-06-15 Thread Andi Kleen
On Sun, Jun 15, 2014 at 10:03:09PM +0900, Namhyung Kim wrote: > Hi Hagen, > > 2014-06-14 (토), 22:49 +0200, Hagen Paul Pfeifer: > > Probably too late, but IMHO the subcommand "download" is unhappy > > named. What is "downloaded"? traces? Python helper libs for > > perf-python support, I don't know

Re: perf: Add support for full Intel event lists v6

2014-06-15 Thread Namhyung Kim
Hi Hagen, 2014-06-14 (토), 22:49 +0200, Hagen Paul Pfeifer: > Probably too late, but IMHO the subcommand "download" is unhappy > named. What is "downloaded"? traces? Python helper libs for > perf-python support, I don't know it. What about "events-download", > "events-database", ... Hmm.. maybe we

Re: perf: Add support for full Intel event lists v6

2014-06-14 Thread Andi Kleen
On Sat, Jun 14, 2014 at 10:49:35PM +0200, Hagen Paul Pfeifer wrote: > Probably too late, but IMHO the subcommand "download" is unhappy > named. What is "downloaded"? traces? Python helper libs for > perf-python support, I don't know it. What about "events-download", > "events-database", ... I pref

Re: perf: Add support for full Intel event lists v6

2014-06-14 Thread Hagen Paul Pfeifer
Probably too late, but IMHO the subcommand "download" is unhappy named. What is "downloaded"? traces? Python helper libs for perf-python support, I don't know it. What about "events-download", "events-database", ... I also thought about further sub-command to delete the cache, update the cache, li

perf: Add support for full Intel event lists v6

2014-06-13 Thread Andi Kleen
[v2: Review feedback addressed and some minor improvements] [v3: More review feedback addressed and handle test failures better. Ported to latest tip/core.] [v4: Addressed Namhyung's feedback] [v5: Rebase to latest tree. Minor description update.] [v6: Rebase. Add acked by from Namhyung and address

Re: perf: Add support for full Intel event lists v5

2014-06-09 Thread Andi Kleen
> So I played with this patchset for a little while, and it's mostly good > and I left comments for each patch I have concerns. With that change, > > Acked-by: Namhyung Kim Thanks for the review. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: perf: Add support for full Intel event lists v5

2014-06-08 Thread Namhyung Kim
On Fri, 30 May 2014 14:50:06 -0700, Andi Kleen wrote: > [v2: Review feedback addressed and some minor improvements] > [v3: More review feedback addressed and handle test failures better. > Ported to latest tip/core.] > [v4: Addressed Namhyung's feedback] > [v5: Rebase to latest tree. Minor descript

perf: Add support for full Intel event lists v5

2014-05-30 Thread Andi Kleen
[v2: Review feedback addressed and some minor improvements] [v3: More review feedback addressed and handle test failures better. Ported to latest tip/core.] [v4: Addressed Namhyung's feedback] [v5: Rebase to latest tree. Minor description update.] perf has high level events which are useful in man

perf: Add support for full Intel event lists v4

2014-05-15 Thread Andi Kleen
[v2: Review feedback addressed and some minor improvements] [v3: More review feedback addressed and handle test failures better. Ported to latest tip/core.] [v4: Addressed Namhyung's feedback] perf has high level events which are useful in many cases. However there are some tuning situations where

Re: perf: Add support for full Intel event lists v3

2014-05-15 Thread Andi Kleen
On Thu, May 15, 2014 at 06:09:20PM +0200, Hagen Paul Pfeifer wrote: > On 13 May 2014 00:51, Andi Kleen wrote: > > > I implemented an automatic downloader to get the event file for the > > current CPU. The events are stored in ~/.events. > > Then perf adds a parser that converts the JSON format i

Re: perf: Add support for full Intel event lists v3

2014-05-15 Thread Hagen Paul Pfeifer
On 13 May 2014 00:51, Andi Kleen wrote: > I implemented an automatic downloader to get the event file for the > current CPU. The events are stored in ~/.events. > Then perf adds a parser that converts the JSON format into perf event > aliases, which then can be used directly as any other perf ev

perf: Add support for full Intel event lists v3

2014-05-12 Thread Andi Kleen
[v2: Review feedback addressed and some minor improvements] [v3: More review feedback addressed and handle test failures better. Ported to latest tip/core.] perf has high level events which are useful in many cases. However there are some tuning situations where low level events in the CPU are nee

perf: Add support for full Intel event lists v2

2014-03-14 Thread Andi Kleen
[v2: Review feedback addressed and some minor improvements] perf has high level events which are useful in many cases. However there are some tuning situations where low level events in the CPU are needed. Traditionally this required specifying the event in raw form (very awkward) or using non st

Re: perf: Add support for full Intel event lists

2014-03-10 Thread Andi Kleen
> > I don't want people shipping those. It just causes lots > > of outdated events everywhere, like in oprofile. > > Sure, no-one should be shipping files under /var/cache. It would be a > an alternate download location. You mean root perf download downloading there? But then people would down

Re: perf: Add support for full Intel event lists

2014-03-10 Thread Ben Hutchings
On Mon, 2014-03-10 at 23:14 +0100, Andi Kleen wrote: > On Mon, Mar 10, 2014 at 07:39:14PM +, Ben Hutchings wrote: > > On Wed, 2014-03-05 at 11:49 -0800, Andi Kleen wrote: > > [...] > > > I implemented an automatic downloader to get the event file for the > > > current CPU. The events are store

Re: perf: Add support for full Intel event lists

2014-03-10 Thread Andi Kleen
On Mon, Mar 10, 2014 at 07:39:14PM +, Ben Hutchings wrote: > On Wed, 2014-03-05 at 11:49 -0800, Andi Kleen wrote: > [...] > > I implemented an automatic downloader to get the event file for the > > current CPU. The events are stored in ~/.events. > [...] > > This directory should be placed un

Re: perf: Add support for full Intel event lists

2014-03-10 Thread Ben Hutchings
On Wed, 2014-03-05 at 11:49 -0800, Andi Kleen wrote: [...] > I implemented an automatic downloader to get the event file for the > current CPU. The events are stored in ~/.events. [...] This directory should be placed under $XDG_CACHE_DIR (default: ~/.cache), and should have a more specific name

Re: perf: Add support for full Intel event lists

2014-03-06 Thread Jiri Olsa
On Wed, Mar 05, 2014 at 11:49:30AM -0800, Andi Kleen wrote: SNIP > Patches also available from > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc perf/json > > Example output: > > % perf download > Downloading models file > Downloading readme.txt > 2014-03-05 10:39:33 URL:https://do

perf: Add support for full Intel event lists

2014-03-05 Thread Andi Kleen
perf has high level events which are useful in many cases. However there are some tuning situations where low level events in the CPU are needed. Traditionally this required specifying the event in raw form (very awkward) or using non standard frontends like ocperf or patching in libpfm. Intel CP