Re: perf's handling of unfindable user symbols...

2018-10-18 Thread Masami Hiramatsu
On Wed, 17 Oct 2018 09:28:55 -0300 Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 17, 2018 at 05:22:26PM +0900, Masami Hiramatsu escreveu: > > On Tue, 16 Oct 2018 15:45:06 -0300 > > Arnaldo Carvalho de Melo wrote: > > > So, I thought something had changed and in the past we would somehow > > > fi

Re: perf's handling of unfindable user symbols...

2018-10-18 Thread Masami Hiramatsu
On Wed, 17 Oct 2018 09:28:55 -0300 Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 17, 2018 at 05:22:26PM +0900, Masami Hiramatsu escreveu: > > On Tue, 16 Oct 2018 15:45:06 -0300 > > Arnaldo Carvalho de Melo wrote: > > > So, I thought something had changed and in the past we would somehow > > > fi

Re: perf's handling of unfindable user symbols...

2018-10-17 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 17, 2018 at 05:22:26PM +0900, Masami Hiramatsu escreveu: > On Tue, 16 Oct 2018 15:45:06 -0300 > Arnaldo Carvalho de Melo wrote: > > So, I thought something had changed and in the past we would somehow > > find that address in the kallsyms, but I couldn't find anything to back > > that

Re: perf's handling of unfindable user symbols...

2018-10-17 Thread Masami Hiramatsu
On Tue, 16 Oct 2018 15:45:06 -0300 Arnaldo Carvalho de Melo wrote: > > So, I thought something had changed and in the past we would somehow > find that address in the kallsyms, but I couldn't find anything to back > that up, the patch introducing this is over a decade old, lots of things > chang

Re: perf's handling of unfindable user symbols...

2018-10-16 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 16, 2018 at 12:02:30PM -0700, David Miller escreveu: > From: Arnaldo Carvalho de Melo > Date: Tue, 16 Oct 2018 15:45:06 -0300 > > > Exec summary: yeah, drop that hack, I agree, patch at the end of the > > message. > > So, I thought something had changed and in the past we would someh

Re: perf's handling of unfindable user symbols...

2018-10-16 Thread David Miller
From: Arnaldo Carvalho de Melo Date: Tue, 16 Oct 2018 15:45:06 -0300 > Exec summary: yeah, drop that hack, I agree, patch at the end of the > message. > > So, I thought something had changed and in the past we would somehow > find that address in the kallsyms, but I couldn't find anything to bac

Re: perf's handling of unfindable user symbols...

2018-10-16 Thread Arnaldo Carvalho de Melo
Adding some people to the CC list. Em Mon, Oct 15, 2018 at 04:02:46PM -0700, David Miller escreveu: > From: Arnaldo Carvalho de Melo > Date: Mon, 15 Oct 2018 19:25:46 -0300 > > But I think we should have it as a property of 'struct machine', because we > > may > > be processing on, say, x86, a

Re: perf's handling of unfindable user symbols...

2018-10-15 Thread David Miller
From: Arnaldo Carvalho de Melo Date: Mon, 15 Oct 2018 19:25:46 -0300 > But I think we should have it as a property of 'struct machine', because we > may > be processing on, say, x86, a perf.data file recorded on a Sparc machine, so > we > need to save this property on the perf.data file, humm,

Re: perf's handling of unfindable user symbols...

2018-10-15 Thread Arnaldo Carvalho de Melo
Em Sun, Oct 14, 2018 at 12:42:38AM -0700, David Miller escreveu: > > Perf has this hack where it uses the kernel symbol map as a backup > when a symbol can't be found in the user's symbol table(s). Right, I recall that, lemme find where this got introduced... there, Ingo added it while perf lived

perf's handling of unfindable user symbols...

2018-10-14 Thread David Miller
Perf has this hack where it uses the kernel symbol map as a backup when a symbol can't be found in the user's symbol table(s). This causes problems because the tests driving this code path use machine__kernel_ip(), and that is completely meaningless on Sparc. On sparc64 the kernel and user live