Re: patchlet for cs46xx

2001-01-25 Thread Richard B. Johnson
On Thu, 25 Jan 2001, Jens Axboe wrote: > On Thu, Jan 25 2001, Richard B. Johnson wrote: > > [SNIPPED...] > > >From what I tested, copy_to/from_user, now seg-faults the caller directly. > > If the function returns, it worked. Therefore you will never get a > > chance to return -EFAULT. > > Huh??

Re: patchlet for cs46xx

2001-01-25 Thread Jens Axboe
On Thu, Jan 25 2001, Richard B. Johnson wrote: > [SNIPPED...] > >From what I tested, copy_to/from_user, now seg-faults the caller directly. > If the function returns, it worked. Therefore you will never get a > chance to return -EFAULT. Huh?? copy_to/from_user returns the bytes _not_ copied, in w

Re: patchlet for cs46xx

2001-01-25 Thread Richard B. Johnson
On Thu, 25 Jan 2001, Pete Zaitcev wrote: > Sorry for the nitpicking, bust since 2.4 is now "stable"... > -- Pete > [SNIPPED...] >From what I tested, copy_to/from_user, now seg-faults the caller directly. If the function returns, it worked. Therefore you will never get a chance to return -EFAULT.

patchlet for cs46xx

2001-01-25 Thread Pete Zaitcev
Sorry for the nitpicking, bust since 2.4 is now "stable"... -- Pete diff -ur -X dontdiff linux-2.4.0-ac9/drivers/sound/cs46xx.c linux-2.4.0-ac9-p3/drivers/sound/cs46xx.c --- linux-2.4.0-ac9/drivers/sound/cs46xx.c Sun Jan 14 15:27:58 2001 +++ linux-2.4.0-ac9-p3/drivers/sound/cs46xx.c Wed J