Re: [PATCH] hwmon: (adm1026) Properly terminate sysfs groups (Was: panic about sysfs with adm1026)

Hi Jean et. al.: * Jean Delvare <[EMAIL PROTECTED]> [2008-02-10 19:01:15 +0100]: > The missing NULL at the end of two sysfs file groups causes a kernel > crash when calling sysfs_create_group(). > > Signed-off-by: Jean Delvare <[EMAIL PROTECTED]> > --- > drivers/hwmon/adm1026.c |2 ++ > 1 fi

Re: [lm-sensors] [PATCH] hwmon: (adm1026) Properly terminate sysfs groups (Was: panic about sysfs with adm1026)

Hi, Kernel 2.6.24 for my distro (Arch Linux) came out in the last few days. My board has a Fintek F1882g chip. It means that I can finally get voltage and fan speeds for the board, so thanks for that. I am wondering how I correctly calculate the correct offset and factors for the voltage numb

Re: [PATCH] hwmon: (adm1026) Properly terminate sysfs groups (Was: panic about sysfs with adm1026)

On Tue, Feb 12, 2008 at 04:37:33PM +0100, Jean Delvare wrote: > On Tue, 12 Feb 2008 07:27:15 -0800, Greg KH wrote: > > On Tue, Feb 12, 2008 at 09:27:22AM +0100, Jean Delvare wrote: > > > Hi Yinghai, > > > > > > On Mon, 11 Feb 2008 15:39:39 -0800, Yinghai Lu wrote: > > > > On Feb 10, 2008 10:01 AM,

Re: [PATCH] hwmon: (adm1026) Properly terminate sysfs groups (Was: panic about sysfs with adm1026)

On Tue, 12 Feb 2008 07:27:15 -0800, Greg KH wrote: > On Tue, Feb 12, 2008 at 09:27:22AM +0100, Jean Delvare wrote: > > Hi Yinghai, > > > > On Mon, 11 Feb 2008 15:39:39 -0800, Yinghai Lu wrote: > > > On Feb 10, 2008 10:01 AM, Jean Delvare <[EMAIL PROTECTED]> wrote: > > > > Yeah, I am an idiot. In 5

Re: [PATCH] hwmon: (adm1026) Properly terminate sysfs groups (Was: panic about sysfs with adm1026)

On Tue, Feb 12, 2008 at 09:27:22AM +0100, Jean Delvare wrote: > Hi Yinghai, > > On Mon, 11 Feb 2008 15:39:39 -0800, Yinghai Lu wrote: > > On Feb 10, 2008 10:01 AM, Jean Delvare <[EMAIL PROTECTED]> wrote: > > > Yeah, I am an idiot. In 5b34dbcd88251508d02e48ad9b0f9b8232a13ee0 I > > > introduced two

Re: [PATCH] hwmon: (adm1026) Properly terminate sysfs groups (Was: panic about sysfs with adm1026)

Hi Yinghai, On Mon, 11 Feb 2008 15:39:39 -0800, Yinghai Lu wrote: > On Feb 10, 2008 10:01 AM, Jean Delvare <[EMAIL PROTECTED]> wrote: > > Yeah, I am an idiot. In 5b34dbcd88251508d02e48ad9b0f9b8232a13ee0 I > > introduced two new sysfs file groups but forgot to NULL-terminate them. > > Sorry about t

Re: [PATCH] hwmon: (adm1026) Properly terminate sysfs groups (Was: panic about sysfs with adm1026)

On Feb 10, 2008 10:01 AM, Jean Delvare <[EMAIL PROTECTED]> wrote: > On Sun, 10 Feb 2008 09:10:04 -0800, Greg KH wrote: > > On Sat, Feb 09, 2008 at 11:55:43PM -0800, Yinghai Lu wrote: > > > Calling initcall 0x80c4b575: sm_adm1026_init+0x0/0xe() > > > i2c-adapter i2c-1: : Unrecognized steppin

Re: [PATCH] hwmon: (adm1026) Properly terminate sysfs groups (Was: panic about sysfs with adm1026)

On Feb 10, 2008 10:01 AM, Jean Delvare <[EMAIL PROTECTED]> wrote: > On Sun, 10 Feb 2008 09:10:04 -0800, Greg KH wrote: > > On Sat, Feb 09, 2008 at 11:55:43PM -0800, Yinghai Lu wrote: > > > Calling initcall 0x80c4b575: sm_adm1026_init+0x0/0xe() > > > i2c-adapter i2c-1: : Unrecognized steppin

Re: panic about sysfs with adm1026

On Sat, Feb 09, 2008 at 11:55:43PM -0800, Yinghai Lu wrote: > Calling initcall 0x80c4b575: sm_adm1026_init+0x0/0xe() > i2c-adapter i2c-1: : Unrecognized stepping 0x45. Defaulting to ADM1026. > general protection fault: [1] SMP > CPU 0 > Modules linked in: > Pid: 1, comm: swapper Not ta

panic about sysfs with adm1026

Calling initcall 0x80c4b575: sm_adm1026_init+0x0/0xe() i2c-adapter i2c-1: : Unrecognized stepping 0x45. Defaulting to ADM1026. general protection fault: [1] SMP CPU 0 Modules linked in: Pid: 1, comm: swapper Not tainted 2.6.24-smp-09379-g0cf975e-dirty #34 RIP: 0010:[] [] sysfs_add_fil