Re: nfs4_do_reclaim lockdep pop in v3.15.0-rc1

2014-06-03 Thread Trond Myklebust
On Tue, Jun 3, 2014 at 6:55 AM, Peter Zijlstra wrote: > Ah, I think I see what Trond means; so raw_write_seqcount_{begin,end}() > are without lockdep, _however_ raw_seqcount_begin() is with lockdep. > > This is inconsistent within the same API (seqcount/seqlock). > > Yes, we should fix that. > > r

Re: nfs4_do_reclaim lockdep pop in v3.15.0-rc1

2014-06-03 Thread Peter Zijlstra
On Mon, Jun 02, 2014 at 08:19:00PM -0700, John Stultz wrote: > On Mon, Jun 2, 2014 at 5:59 PM, Trond Myklebust > wrote: > > On Mon, Jun 2, 2014 at 6:49 PM, John Stultz wrote: > >> On Mon, Jun 2, 2014 at 3:42 PM, Trond Myklebust > >> wrote: > >>> The so_reclaim_seqcount only exists in order to te

Re: nfs4_do_reclaim lockdep pop in v3.15.0-rc1

2014-06-03 Thread Peter Zijlstra
On Mon, Jun 02, 2014 at 08:59:21PM -0400, Trond Myklebust wrote: > > I can change the write seqcount to use raw_write_seqcount(), but that > doesn't answer the question of why raw_seqcount_begin() is the _only_ > object out there with a "raw_" prefix, that doesn't explicitly disable > lockdep chec

Re: nfs4_do_reclaim lockdep pop in v3.15.0-rc1

2014-06-02 Thread John Stultz
On Mon, Jun 2, 2014 at 5:59 PM, Trond Myklebust wrote: > On Mon, Jun 2, 2014 at 6:49 PM, John Stultz wrote: >> On Mon, Jun 2, 2014 at 3:42 PM, Trond Myklebust >> wrote: >>> The so_reclaim_seqcount only exists in order to tell the other threads >>> that they may need to replay file open or file l

Re: nfs4_do_reclaim lockdep pop in v3.15.0-rc1

2014-06-02 Thread Trond Myklebust
On Mon, Jun 2, 2014 at 6:49 PM, John Stultz wrote: > On Mon, Jun 2, 2014 at 3:42 PM, Trond Myklebust > wrote: >> On Mon, Jun 2, 2014 at 6:12 PM, John Stultz wrote: >>> On Mon, Jun 2, 2014 at 9:02 AM, Trond Myklebust >>> wrote: On Mon, Jun 2, 2014 at 10:49 AM, Jeff Layton wrote: >

Re: nfs4_do_reclaim lockdep pop in v3.15.0-rc1

2014-06-02 Thread John Stultz
On Mon, Jun 2, 2014 at 3:42 PM, Trond Myklebust wrote: > On Mon, Jun 2, 2014 at 6:12 PM, John Stultz wrote: >> On Mon, Jun 2, 2014 at 9:02 AM, Trond Myklebust >> wrote: >>> On Mon, Jun 2, 2014 at 10:49 AM, Jeff Layton >>> wrote: I've been working on the patchset to break up the client_mute

Re: nfs4_do_reclaim lockdep pop in v3.15.0-rc1

2014-06-02 Thread Trond Myklebust
On Mon, Jun 2, 2014 at 6:12 PM, John Stultz wrote: > On Mon, Jun 2, 2014 at 9:02 AM, Trond Myklebust > wrote: >> On Mon, Jun 2, 2014 at 10:49 AM, Jeff Layton >> wrote: >>> I've been working on the patchset to break up the client_mutex in nfsd. >>> While doing some debugging, I had mounted my ker

Re: nfs4_do_reclaim lockdep pop in v3.15.0-rc1

2014-06-02 Thread John Stultz
On Mon, Jun 2, 2014 at 9:02 AM, Trond Myklebust wrote: > On Mon, Jun 2, 2014 at 10:49 AM, Jeff Layton > wrote: >> I've been working on the patchset to break up the client_mutex in nfsd. >> While doing some debugging, I had mounted my kernel git tree with >> NFSv4.1, and was running crash on the v

Re: nfs4_do_reclaim lockdep pop in v3.15.0-rc1

2014-06-02 Thread Trond Myklebust
On Mon, Jun 2, 2014 at 10:49 AM, Jeff Layton wrote: > I've been working on the patchset to break up the client_mutex in nfsd. > While doing some debugging, I had mounted my kernel git tree with > NFSv4.1, and was running crash on the vmlinux image in it. > > A little while later, I saw the followi