Re: nfnetlink warnings

2015-11-23 Thread Michael Wang
On 11/23/2015 11:32 AM, Borislav Petkov wrote: > On Mon, Nov 23, 2015 at 11:20:18AM +0100, Michael Wang wrote: >> Who want to do that would take responsibility to make an else branch at >> that time, but reserve the branch at this moment sounds unnecessary, and >> not that pretty frankly speaking

Re: nfnetlink warnings

2015-11-23 Thread Borislav Petkov
On Mon, Nov 23, 2015 at 11:20:18AM +0100, Michael Wang wrote: > Who want to do that would take responsibility to make an else branch at > that time, but reserve the branch at this moment sounds unnecessary, and > not that pretty frankly speaking. Actually, I was looking for the better idea which d

Re: nfnetlink warnings

2015-11-23 Thread Pablo Neira Ayuso
I have just applied this patch to resolve this issue. http://git.kernel.org/cgit/linux/kernel/git/pablo/nf.git/commit/?id=8e662164abb4a8fde701a46e1431980f9e325742 Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.o

Re: nfnetlink warnings

2015-11-23 Thread Michael Wang
On 11/23/2015 10:54 AM, Borislav Petkov wrote: > Hi Michael, > > On Mon, Nov 23, 2015 at 10:49:34AM +0100, Michael Wang wrote: >> Why not just initialized it as NULL, or mark it as uninitialized_var()? > > because I'd like us to save us the redundant NULL initialization in the > if-case. Well,

Re: nfnetlink warnings

2015-11-23 Thread Borislav Petkov
Hi Michael, On Mon, Nov 23, 2015 at 10:49:34AM +0100, Michael Wang wrote: > Why not just initialized it as NULL, or mark it as uninitialized_var()? because I'd like us to save us the redundant NULL initialization in the if-case. I'm not saying any of the approaches are good visually, though. Who

Re: nfnetlink warnings

2015-11-23 Thread Michael Wang
Hi, Borislav Why not just initialized it as NULL, or mark it as uninitialized_var()? Regards, Michael Wang On 11/23/2015 10:36 AM, Borislav Petkov wrote: > Hey, > > so I keep getting those since recently: > > net/netfilter/nfnetlink_queue.c:519:19: warning: ‘nfnl_ct’ may be used > uninitializ

nfnetlink warnings

2015-11-23 Thread Borislav Petkov
Hey, so I keep getting those since recently: net/netfilter/nfnetlink_queue.c:519:19: warning: ‘nfnl_ct’ may be used uninitialized in this function [-Wmaybe-uninitialized] if (ct && nfnl_ct->build(skb, ct, ctinfo, NFQA_CT, NFQA_CT_INFO) < 0) ^ net/netfilter/nfnetlink_queue.c: