On Thu, 11 Aug 2016, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Thu, 11 Aug 2016 13:30:32 +0200
>
> Adjust jump targets according to the Linux coding style convention.
> Another check for the variable "status" can be omitted then at the end.
>
> Link: https://lkml.kernel.org/g/<201
From: Markus Elfring
Date: Thu, 11 Aug 2016 13:30:32 +0200
Adjust jump targets according to the Linux coding style convention.
Another check for the variable "status" can be omitted then at the end.
Link: https://lkml.kernel.org/g/<20160628163146.GG29166@dell>
Signed-off-by: Markus Elfring
---
On Tue, 09 Aug 2016, SF Markus Elfring wrote:
> > But the change-log in this patch says "I did some stuff".
> > What stuff did you change? Which review comments did you
> > tend to?
>
> I imagine that I could increase the description granularity
> to a detail level which you might also not like.
> But the change-log in this patch says "I did some stuff".
> What stuff did you change? Which review comments did you
> tend to?
I imagine that I could increase the description granularity
to a detail level which you might also not like.
+put_device:
+ platform_device_put(pdev);
>>>
On Mon, 08 Aug 2016, SF Markus Elfring wrote:
> > Please rebase all of your unaccepted patches on v4.8-rc1.
>
> Thanks for your suggestion. - Would you like to add any comments
> to my remaining update suggestions for Linux modules
> (besides "dm355evm_msp")?
>
> I would like to clarify still a
On Mon, 08 Aug 2016, SF Markus Elfring wrote:
> >> v4: Further feedback was integrated into this message.
> >
> > This is not a good change-log. What actually changed?
>
> Which kind of information would you find more useful in this case?
That's for you to tell me surely?
If I wanted to know
>> v4: Further feedback was integrated into this message.
>
> This is not a good change-log. What actually changed?
Which kind of information would you find more useful in this case?
>> @@ -222,19 +222,20 @@ static struct device *add_child(struct i2c_client
>> *client, const char *name,
>>
> Please rebase all of your unaccepted patches on v4.8-rc1.
Thanks for your suggestion. - Would you like to add any comments
to my remaining update suggestions for Linux modules
(besides "dm355evm_msp")?
I would like to clarify still a few implementation details then.
https://patchwork.kernel.org
On Fri, 05 Aug 2016, SF Markus Elfring wrote:
> > I'm unsure if you're not re-submitting because you're waiting for an
> > answer for me or not.
>
> I found your five commits (on 2016-06-29) for this patch series
> sufficient in principle.
> https://git.kernel.org/cgit/linux/kernel/git/next/linux
> I'm unsure if you're not re-submitting because you're waiting for an
> answer for me or not.
I found your five commits (on 2016-06-29) for this patch series
sufficient in principle.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=d313cdde71ec9a5c327a515c37a0dca2cca00d
On Fri, 01 Jul 2016, SF Markus Elfring wrote:
> From: Markus Elfring
Please use `git send-email` to submit your patches.
> Adjust jump targets according to the Linux coding style convention.
> Another check for the variable "status" can be omitted then at the end.
>
> Signed-off-by: Markus Elf
On Fri, 01 Jul 2016, SF Markus Elfring wrote:
> > FYI, code looks fine.
>
> Thanks for your acknowledgement.
>
>
> > ... but please take this opportunity to set-up your submission
> > environment i.e. using `git format-patch` and `git send-email`.
>
>
> Would you like to see any special setti
From: Markus Elfring
Adjust jump targets according to the Linux coding style convention.
Another check for the variable "status" can be omitted then at the end.
Signed-off-by: Markus Elfring
---
v4: Further feedback was integrated into this message.
v3: Deletion of another blank line
v2: Rebasi
On Fri, 2016-07-01 at 16:40 +0200, SF Markus Elfring wrote:
> >
> > Can you please fix your email client to _not_ send References:
> > and In-reply-to: headers when sending new patches?
> I prefer to associate some patches with previous relevant
> discussion directly.
>
>
> >
> > Even better wo
> FYI, code looks fine.
Thanks for your acknowledgement.
> ... but please take this opportunity to set-up your submission
> environment i.e. using `git format-patch` and `git send-email`.
Would you like to see any special settings to be mentioned
in a section like "15) Explicit In-Reply-To hea
> Can you please fix your email client to _not_ send References:
> and In-reply-to: headers when sending new patches?
I prefer to associate some patches with previous relevant
discussion directly.
> Even better would be to use git send-email for these patches.
This command can also support a pa
On Thu, 30 Jun 2016, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Thu, 30 Jun 2016 21:54:51 +0200
>
> Adjust jump targets according to the Linux coding style convention.
> Another check for the variable "status" can be omitted then at the end.
>
> Signed-off-by: Markus Elfring
> ---
On Thu, 30 Jun 2016, Joe Perches wrote:
> On Thu, 2016-06-30 at 22:15 +0200, SF Markus Elfring wrote:
> > From: Markus Elfring
> > Date: Thu, 30 Jun 2016 21:54:51 +0200
> >
> > Adjust jump targets according to the Linux coding style convention.
> > Another check for the variable "status" can be
On Thu, 2016-06-30 at 22:15 +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Thu, 30 Jun 2016 21:54:51 +0200
>
> Adjust jump targets according to the Linux coding style convention.
> Another check for the variable "status" can be omitted then at the
> end.
Two headers in this email
From: Markus Elfring
Date: Thu, 30 Jun 2016 21:54:51 +0200
Adjust jump targets according to the Linux coding style convention.
Another check for the variable "status" can be omitted then at the end.
Signed-off-by: Markus Elfring
---
drivers/mfd/dm355evm_msp.c | 17 +
1 file cha
On Tue, 28 Jun 2016, SF Markus Elfring wrote:
> >> @@ -222,19 +222,21 @@ static struct device *add_child(struct i2c_client
> >> *client, const char *name,
> >>status = platform_device_add_resources(pdev, &r, 1);
> >>if (status < 0) {
> >>dev_dbg(&pdev->
>> @@ -222,19 +222,21 @@ static struct device *add_child(struct i2c_client
>> *client, const char *name,
>> status = platform_device_add_resources(pdev, &r, 1);
>> if (status < 0) {
>> dev_dbg(&pdev->dev, "can't add irq\n");
>> -go
On Sun, 26 Jun 2016, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 26 Jun 2016 13:56:58 +0200
>
> Adjust jump targets according to the Linux coding style convention.
> Another check for the variable "status" can be omitted then at the end.
>
> Signed-off-by: Markus Elfring
> ---
From: Markus Elfring
Date: Sun, 26 Jun 2016 13:56:58 +0200
Adjust jump targets according to the Linux coding style convention.
Another check for the variable "status" can be omitted then at the end.
Signed-off-by: Markus Elfring
---
drivers/mfd/dm355evm_msp.c | 18 ++
1 file ch
24 matches
Mail list logo
