Re: memory offline infinite loop after soft offline

2020-05-18 Thread Qian Cai
> On May 14, 2020, at 11:48 PM, HORIGUCHI NAOYA(堀口　直也) > wrote: > > I'm very sorry to be quiet for long, but I think that I agree with > this patchset and try to see what happend if merged into mmtom, > although we need rebaseing to latest mmotm and some basic testing. Looks like Oscar have

Re: memory offline infinite loop after soft offline

2020-05-14 Thread 堀口　直也
On Thu, May 14, 2020 at 10:46:33PM -0400, Qian Cai wrote: > > > > On Oct 20, 2019, at 11:16 PM, Naoya Horiguchi > > wrote: > > > > On Fri, Oct 18, 2019 at 07:56:09AM -0400, Qian Cai wrote: > >> > >> > >>On Oct 18, 2019, at 2:35 AM, Naoya Horiguchi > >>wrote: > >> > >> > >>You'

Re: memory offline infinite loop after soft offline

2020-05-14 Thread Qian Cai
> On Oct 20, 2019, at 11:16 PM, Naoya Horiguchi > wrote: > > On Fri, Oct 18, 2019 at 07:56:09AM -0400, Qian Cai wrote: >> >> >>On Oct 18, 2019, at 2:35 AM, Naoya Horiguchi >>wrote: >> >> >>You're right, then I don't see how this happens. If the error hugepage was >>isolat

Re: memory offline infinite loop after soft offline

2019-10-20 Thread Naoya Horiguchi
On Fri, Oct 18, 2019 at 07:56:09AM -0400, Qian Cai wrote: > > > On Oct 18, 2019, at 2:35 AM, Naoya Horiguchi > wrote: > > > You're right, then I don't see how this happens. If the error hugepage was > isolated without having PG_hwpoison set, it's unexpected and problematic. >

Re: memory offline infinite loop after soft offline

2019-10-18 Thread David Hildenbrand
On 18.10.19 13:34, Michal Hocko wrote: On Fri 18-10-19 13:00:45, David Hildenbrand wrote: On 18.10.19 10:55, Michal Hocko wrote: On Fri 18-10-19 10:38:21, David Hildenbrand wrote: On 18.10.19 10:24, Michal Hocko wrote: On Fri 18-10-19 10:13:36, David Hildenbrand wrote: [...] However, if the

Re: memory offline infinite loop after soft offline

2019-10-18 Thread Michal Hocko
On Fri 18-10-19 13:00:45, David Hildenbrand wrote: > On 18.10.19 10:55, Michal Hocko wrote: > > On Fri 18-10-19 10:38:21, David Hildenbrand wrote: > > > On 18.10.19 10:24, Michal Hocko wrote: > > > > On Fri 18-10-19 10:13:36, David Hildenbrand wrote: > > > > [...] > > > > > However, if the compound

Re: memory offline infinite loop after soft offline

2019-10-18 Thread David Hildenbrand
On 18.10.19 13:00, David Hildenbrand wrote: On 18.10.19 10:55, Michal Hocko wrote: On Fri 18-10-19 10:38:21, David Hildenbrand wrote: On 18.10.19 10:24, Michal Hocko wrote: On Fri 18-10-19 10:13:36, David Hildenbrand wrote: [...] However, if the compound page spans multiple pageblocks Altho

Re: memory offline infinite loop after soft offline

2019-10-18 Thread David Hildenbrand
On 18.10.19 10:55, Michal Hocko wrote: On Fri 18-10-19 10:38:21, David Hildenbrand wrote: On 18.10.19 10:24, Michal Hocko wrote: On Fri 18-10-19 10:13:36, David Hildenbrand wrote: [...] However, if the compound page spans multiple pageblocks Although hugetlb pages spanning pageblocks are pos

Re: memory offline infinite loop after soft offline

2019-10-18 Thread Michal Hocko
On Fri 18-10-19 10:38:21, David Hildenbrand wrote: > On 18.10.19 10:24, Michal Hocko wrote: > > On Fri 18-10-19 10:13:36, David Hildenbrand wrote: > > [...] > > > However, if the compound page spans multiple pageblocks > > > > Although hugetlb pages spanning pageblocks are possible this shouldn't

Re: memory offline infinite loop after soft offline

2019-10-18 Thread Naoya Horiguchi
On Fri, Oct 18, 2019 at 09:33:10AM +0200, Michal Hocko wrote: > On Fri 18-10-19 06:32:22, Naoya Horiguchi wrote: > > On Fri, Oct 18, 2019 at 08:06:35AM +0200, Michal Hocko wrote: > > > On Fri 18-10-19 02:19:06, Naoya Horiguchi wrote: > > > > On Thu, Oct 17, 2019 at 08:27:59PM +0200, Michal Hocko wr

Re: memory offline infinite loop after soft offline

2019-10-18 Thread David Hildenbrand
On 18.10.19 10:24, Michal Hocko wrote: On Fri 18-10-19 10:13:36, David Hildenbrand wrote: [...] However, if the compound page spans multiple pageblocks Although hugetlb pages spanning pageblocks are possible this shouldn't matter in__test_page_isolated_in_pageblock because this function doesn'

Re: memory offline infinite loop after soft offline

2019-10-18 Thread Michal Hocko
On Fri 18-10-19 10:13:36, David Hildenbrand wrote: [...] > However, if the compound page spans multiple pageblocks Although hugetlb pages spanning pageblocks are possible this shouldn't matter in__test_page_isolated_in_pageblock because this function doesn't really operate on pageblocks as the nam

Re: memory offline infinite loop after soft offline

2019-10-18 Thread David Hildenbrand
On 18.10.19 04:19, Naoya Horiguchi wrote: On Thu, Oct 17, 2019 at 08:27:59PM +0200, Michal Hocko wrote: On Thu 17-10-19 14:07:13, Qian Cai wrote: On Thu, 2019-10-17 at 12:01 +0200, Michal Hocko wrote: On Thu 17-10-19 09:34:10, Naoya Horiguchi wrote: On Mon, Oct 14, 2019 at 10:39:14AM +0200, M

Re: memory offline infinite loop after soft offline

2019-10-18 Thread Michal Hocko
On Fri 18-10-19 06:32:22, Naoya Horiguchi wrote: > On Fri, Oct 18, 2019 at 08:06:35AM +0200, Michal Hocko wrote: > > On Fri 18-10-19 02:19:06, Naoya Horiguchi wrote: > > > On Thu, Oct 17, 2019 at 08:27:59PM +0200, Michal Hocko wrote: > > > > On Thu 17-10-19 14:07:13, Qian Cai wrote: > > > > > On Th

Re: memory offline infinite loop after soft offline

2019-10-17 Thread Naoya Horiguchi
On Fri, Oct 18, 2019 at 08:06:35AM +0200, Michal Hocko wrote: > On Fri 18-10-19 02:19:06, Naoya Horiguchi wrote: > > On Thu, Oct 17, 2019 at 08:27:59PM +0200, Michal Hocko wrote: > > > On Thu 17-10-19 14:07:13, Qian Cai wrote: > > > > On Thu, 2019-10-17 at 12:01 +0200, Michal Hocko wrote: > > > > >

Re: memory offline infinite loop after soft offline

2019-10-17 Thread Naoya Horiguchi
On Thu, Oct 17, 2019 at 08:27:59PM +0200, Michal Hocko wrote: > On Thu 17-10-19 14:07:13, Qian Cai wrote: > > On Thu, 2019-10-17 at 12:01 +0200, Michal Hocko wrote: > > > On Thu 17-10-19 09:34:10, Naoya Horiguchi wrote: > > > > On Mon, Oct 14, 2019 at 10:39:14AM +0200, Michal Hocko wrote: > > > >

Re: memory offline infinite loop after soft offline

2019-10-17 Thread Michal Hocko
On Fri 18-10-19 02:19:06, Naoya Horiguchi wrote: > On Thu, Oct 17, 2019 at 08:27:59PM +0200, Michal Hocko wrote: > > On Thu 17-10-19 14:07:13, Qian Cai wrote: > > > On Thu, 2019-10-17 at 12:01 +0200, Michal Hocko wrote: > > > > On Thu 17-10-19 09:34:10, Naoya Horiguchi wrote: > > > > > On Mon, Oct

Re: memory offline infinite loop after soft offline

2019-10-17 Thread Michal Hocko
On Thu 17-10-19 14:07:13, Qian Cai wrote: > On Thu, 2019-10-17 at 12:01 +0200, Michal Hocko wrote: > > On Thu 17-10-19 09:34:10, Naoya Horiguchi wrote: > > > On Mon, Oct 14, 2019 at 10:39:14AM +0200, Michal Hocko wrote: > > > > [...] > > > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c >

Re: memory offline infinite loop after soft offline

2019-10-17 Thread Qian Cai
On Thu, 2019-10-17 at 12:01 +0200, Michal Hocko wrote: > On Thu 17-10-19 09:34:10, Naoya Horiguchi wrote: > > On Mon, Oct 14, 2019 at 10:39:14AM +0200, Michal Hocko wrote: > > [...] > > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > > > index 89c19c0feadb..5fb3fee16fde 100644 > > > ---

Re: memory offline infinite loop after soft offline

2019-10-17 Thread David Hildenbrand
On 17.10.19 12:01, Michal Hocko wrote: On Thu 17-10-19 09:34:10, Naoya Horiguchi wrote: On Mon, Oct 14, 2019 at 10:39:14AM +0200, Michal Hocko wrote: [...] diff --git a/mm/page_isolation.c b/mm/page_isolation.c index 89c19c0feadb..5fb3fee16fde 100644 --- a/mm/page_isolation.c +++ b/mm/page_iso

Re: memory offline infinite loop after soft offline

2019-10-17 Thread Michal Hocko
On Thu 17-10-19 09:34:10, Naoya Horiguchi wrote: > On Mon, Oct 14, 2019 at 10:39:14AM +0200, Michal Hocko wrote: [...] > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > > index 89c19c0feadb..5fb3fee16fde 100644 > > --- a/mm/page_isolation.c > > +++ b/mm/page_isolation.c > > @@ -274,7 +27

Re: memory offline infinite loop after soft offline

2019-10-17 Thread Naoya Horiguchi
On Mon, Oct 14, 2019 at 10:39:14AM +0200, Michal Hocko wrote: > On Fri 11-10-19 17:32:44, Qian Cai wrote: > > # /opt/ltp/runtest/bin/move_pages12 > > move_pages12.c:263: INFO: Free RAM 258988928 kB > > move_pages12.c:281: INFO: Increasing 2048kB hugepages pool on node 0 to 4 > > move_pages12.c:291:

Re: memory offline infinite loop after soft offline

2019-10-14 Thread Michal Hocko
On Fri 11-10-19 17:32:44, Qian Cai wrote: > # /opt/ltp/runtest/bin/move_pages12 > move_pages12.c:263: INFO: Free RAM 258988928 kB > move_pages12.c:281: INFO: Increasing 2048kB hugepages pool on node 0 to 4 > move_pages12.c:291: INFO: Increasing 2048kB hugepages pool on node 8 to 4 > move_pages12.c:

Re: memory offline infinite loop after soft offline

2019-10-12 Thread osalvador
On 2019-10-11 23:32, Qian Cai wrote: # /opt/ltp/runtest/bin/move_pages12 move_pages12.c:263: INFO: Free RAM 258988928 kB move_pages12.c:281: INFO: Increasing 2048kB hugepages pool on node 0 to 4 move_pages12.c:291: INFO: Increasing 2048kB hugepages pool on node 8 to 4 move_pages12.c:207: INFO:

memory offline infinite loop after soft offline

2019-10-11 Thread Qian Cai
# /opt/ltp/runtest/bin/move_pages12 move_pages12.c:263: INFO: Free RAM 258988928 kB move_pages12.c:281: INFO: Increasing 2048kB hugepages pool on node 0 to 4 move_pages12.c:291: INFO: Increasing 2048kB hugepages pool on node 8 to 4 move_pages12.c:207: INFO: Allocating and freeing 4 hugepages on nod