Re: maps2-add-proc-pid-pagemap-interface.patch

2007-07-10 Thread Rusty Russell
On Tue, 2007-07-10 at 01:27 -0500, Matt Mackall wrote: > On Tue, Jul 10, 2007 at 02:28:50PM +1000, Rusty Russell wrote: > > I don't think normal ptraces get cut on exec, so I'm not sure why this > > should be different. > > They absolutely do, if UID changes. Consider ptracing a shell > launching

Re: maps2-add-proc-pid-pagemap-interface.patch

2007-07-09 Thread Matt Mackall
On Tue, Jul 10, 2007 at 02:28:50PM +1000, Rusty Russell wrote: > On Mon, 2007-07-09 at 17:31 -0500, Matt Mackall wrote: > > > And how about "cpu_to_le16(1) == 1" instead of "ntohl(1) != 1"? > > > > Why? > > Using a networking macro to detect endianness is old school: we have the > nice explicit m

Re: maps2-add-proc-pid-pagemap-interface.patch

2007-07-09 Thread Rusty Russell
On Mon, 2007-07-09 at 17:31 -0500, Matt Mackall wrote: > > And how about "cpu_to_le16(1) == 1" instead of "ntohl(1) != 1"? > > Why? Using a networking macro to detect endianness is old school: we have the nice explicit macros these days... > > > + while (pm.count > 0 && vma) { > > > + if

Re: maps2-add-proc-pid-pagemap-interface.patch

2007-07-09 Thread Matt Mackall
On Sun, Jul 08, 2007 at 09:33:01PM +1000, Rusty Russell wrote: > Hi Matt, > > > +#ifdef CONFIG_PROC_PAGEMAP > > +struct pagemapread { > > + struct mm_struct *mm; > > + unsigned long next; > > + unsigned long *buf; > > + pte_t *ptebuf; > > + unsigned long pos; > > + size_t count; > > +

maps2-add-proc-pid-pagemap-interface.patch

2007-07-08 Thread Rusty Russell
Hi Matt, > +#ifdef CONFIG_PROC_PAGEMAP > +struct pagemapread { > + struct mm_struct *mm; > + unsigned long next; > + unsigned long *buf; > + pte_t *ptebuf; > + unsigned long pos; > + size_t count; > + int index; > + char __user *out; > +}; > + > +static int flush_pa