Hi Chris,
Quoting Chris Wilson :
On Thu, May 11, 2017 at 03:00:02PM -0500, Gustavo A. R. Silva wrote:
Hello everybody,
While looking into Coverity ID 1402035 I ran into the following
piece of code at kernel/locking/test-ww_mutex.c:197:
197static int test_abba(bool resolve)
198{
199s
On Thu, May 11, 2017 at 03:00:02PM -0500, Gustavo A. R. Silva wrote:
>
> Hello everybody,
>
> While looking into Coverity ID 1402035 I ran into the following
> piece of code at kernel/locking/test-ww_mutex.c:197:
>
> 197static int test_abba(bool resolve)
> 198{
> 199struct test_abba abba
Hello everybody,
While looking into Coverity ID 1402035 I ran into the following piece
of code at kernel/locking/test-ww_mutex.c:197:
197static int test_abba(bool resolve)
198{
199struct test_abba abba;
200struct ww_acquire_ctx ctx;
201int err, ret;
202
203ww_
On Thu, 15 Mar 2001, Dawson Engler wrote:
> 2. And, unrelated: given the current locking discipline, is
> it bad to hold any type of lock (not just a spin lock) when you
> call a potentially blocking function? (It at least seems bad
> for performance, since you'll hold t
As part of better understanding some of the issues in SMP,
I've been working at documenting all the global kernel locks in use,
including what's left of the BKL, and have run into a use of the BKL
that seems pretty consistent and also pretty obscure.
The code base I'm inspecting is 2.4.0-test8. (
Alan Cox wrote:
>
> > At line 1073 of ../drivers/char/i2lib.c (2.4.0-test9) we find:
> >
> > WRITE_LOCK_IRQSAVE(...
> >
> > this is followed by:
> >
> > COPY_FROM_USER(...
> >
> > It seems to me that this could result in a page fault with interrupts
> > off. Is this ok?
>
> It wont do what you
> At line 1073 of ../drivers/char/i2lib.c (2.4.0-test9) we find:
>
> WRITE_LOCK_IRQSAVE(...
>
> this is followed by:
>
> COPY_FROM_USER(...
>
> It seems to me that this could result in a page fault with interrupts
> off. Is this ok?
It wont do what you want - it'll re-enable irqs and may the
At line 1073 of ../drivers/char/i2lib.c (2.4.0-test9) we find:
WRITE_LOCK_IRQSAVE(...
this is followed by:
COPY_FROM_USER(...
It seems to me that this could result in a page fault with interrupts
off. Is this ok?
George
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel
8 matches
Mail list logo
