Re: ll_rw_blk.c fails to merge requests. Help!

2000-08-30 Thread Giuliano Pochini
> I have two comments about this patch. (the reqfree-batching-3) > > First. Couldn't it end up indefinitely starving a writer? > > Assume the free_list is empty [...] I think that can also happen in 2.2.x and plain 2.4-test7. I have a question. There is a rq queue for eache device, right ? Well

Re: ll_rw_blk.c fails to merge requests. Help!

2000-08-29 Thread Jens Axboe
On Tue, Aug 29 2000, David Mansfield wrote: > > This one works even better. Good to know, thanks for testing. > > + list_add(&req->table, &q->pending_freelist); > > + if (++q->pending_free > 64) { And you are right, this is best a fractional value of the total number

Re: ll_rw_blk.c fails to merge requests. Help!

2000-08-29 Thread David Mansfield
> > >reqfree-batching-3Name: reqfree-batching-3 > > Type: Plain Text (text/plain) > > This one works even better. > > > + list_add(&req->table, &q->pending_freelist); > + if (++q->pending_free > 64) { >^

Re: ll_rw_blk.c fails to merge requests. Help!

2000-08-29 Thread Giuliano Pochini
> > Aug 26 18:09:19 Jay kernel: W 914680 252 > > Aug 26 18:09:19 Jay kernel: W 914932 8 > > Aug 26 18:09:19 Jay kernel: W 851976 4 > > Aug 26 18:09:19 Jay kernel: W 914940 252 > > Aug 26 18:09:19 Jay kernel: W 915192 4 > > Aug 26 18:09:19 Jay kernel: W 915196 252 > > Aug 26 18:09:19 J

Re: ll_rw_blk.c fails to merge requests. Help!

2000-08-29 Thread Giuliano Pochini
>reqfree-batching-3Name: reqfree-batching-3 > Type: Plain Text (text/plain) This one works even better. + list_add(&req->table, &q->pending_freelist); + if (++q->pending_free > 64) { ^ I think a fr