Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5

2008-01-03 Thread FUJITA Tomonori
On Thu, 03 Jan 2008 15:51:25 -0500 David Dillow <[EMAIL PROTECTED]> wrote: > > On Thu, 2008-01-03 at 15:09 -0500, David Dillow wrote: > > As for a better fix, I'm not sure. > > Here's a better way than the strncmp. If this meets everyone's approval, > then I can roll up a proper commit. Thanks!

Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5

2008-01-03 Thread Roland Dreier
> +if (scsi_is_srp_rport(dev)) > +srp_rport_del(dev_to_rport(dev)); This has the ring of truth to me as the right fix, although I certainly don't know the details of this code... Fujita-san? - R. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5

2008-01-03 Thread David Dillow
On Thu, 2008-01-03 at 15:09 -0500, David Dillow wrote: > As for a better fix, I'm not sure. Here's a better way than the strncmp. If this meets everyone's approval, then I can roll up a proper commit. diff --git a/drivers/scsi/scsi_transport_srp.c b/drivers/scsi/scsi_transport_srp.c index 44a34

Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5

2008-01-03 Thread David Dillow
On Thu, 2008-01-03 at 17:30 +0900, FUJITA Tomonori wrote: > On Wed, 02 Jan 2008 09:51:38 -0800 > Roland Dreier <[EMAIL PROTECTED]> wrote: > > > > > Can you try this? > > > > > > That patched oopsed in scsi_remove_host(), but reversing the order has > > > survived over 500 insert/probe/remove

Re: list corruption on ib_srp load in v2.6.24-rc5

2008-01-03 Thread FUJITA Tomonori
On Wed, 02 Jan 2008 09:51:38 -0800 Roland Dreier <[EMAIL PROTECTED]> wrote: > > > Can you try this? > > > > That patched oopsed in scsi_remove_host(), but reversing the order has > > survived over 500 insert/probe/remove cycles. > > > > Tested-by: David Dillow <[EMAIL PROTECTED]> > > ---

Re: list corruption on ib_srp load in v2.6.24-rc5

2008-01-02 Thread Roland Dreier
> > Can you try this? > > That patched oopsed in scsi_remove_host(), but reversing the order has > survived over 500 insert/probe/remove cycles. > > Tested-by: David Dillow <[EMAIL PROTECTED]> > --- > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c > b/drivers/infiniband/ulp/srp/ib_srp

Re: list corruption on ib_srp load in v2.6.24-rc5

2007-12-27 Thread David Dillow
On Thu, 2007-12-27 at 11:58 +0900, FUJITA Tomonori wrote: > On Wed, 26 Dec 2007 12:14:11 -0500 > David Dillow <[EMAIL PROTECTED]> wrote: > > > > > On Sun, 2007-12-23 at 01:41 +0900, FUJITA Tomonori wrote: > > > transport_container_unregister(&i->rport_attr_cont) should not fail here. > > > > >

Re: list corruption on ib_srp load in v2.6.24-rc5

2007-12-26 Thread FUJITA Tomonori
On Wed, 26 Dec 2007 12:14:11 -0500 David Dillow <[EMAIL PROTECTED]> wrote: > > On Sun, 2007-12-23 at 01:41 +0900, FUJITA Tomonori wrote: > > transport_container_unregister(&i->rport_attr_cont) should not fail here. > > > > It fails because there is still a srp rport. > > > > I think that as Pet

Re: list corruption on ib_srp load in v2.6.24-rc5

2007-12-26 Thread David Dillow
On Sun, 2007-12-23 at 01:41 +0900, FUJITA Tomonori wrote: > transport_container_unregister(&i->rport_attr_cont) should not fail here. > > It fails because there is still a srp rport. > > I think that as Pete pointed out, srp_remove_one needs to call > srp_remove_host. > > Can you try this? Tha

Re: list corruption on ib_srp load in v2.6.24-rc5

2007-12-22 Thread Dave Dillow
On Sun, 2007-12-23 at 01:41 +0900, FUJITA Tomonori wrote: > I think that as Pete pointed out, srp_remove_one needs to call > srp_remove_host. > > Can you try this? If I need to escape family during the holidays, I'll test it from home. Otherwise I'll be able to test on Wednesday. Thanks for the

Re: list corruption on ib_srp load in v2.6.24-rc5

2007-12-22 Thread FUJITA Tomonori
On Fri, 21 Dec 2007 17:18:52 -0500 David Dillow <[EMAIL PROTECTED]> wrote: > > On Fri, 2007-12-21 at 16:52 -0500, David Dillow wrote: > > I'm getting the following oops when doing the following commands: > > > > modprobe ib_srp > > > > rmmod ib_srp > > modprobe ib_srp > > > > > > I'm going to

Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5

2007-12-22 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Fri, 21 Dec 2007 17:18 -0500: > On Fri, 2007-12-21 at 16:52 -0500, David Dillow wrote: > > I'm getting the following oops when doing the following commands: > > > > modprobe ib_srp > > > > rmmod ib_srp > > modprobe ib_srp > > > > > > I'm going to try and track down ho

Re: list corruption on ib_srp load in v2.6.24-rc5

2007-12-21 Thread David Dillow
On Fri, 2007-12-21 at 16:52 -0500, David Dillow wrote: > I'm getting the following oops when doing the following commands: > > modprobe ib_srp > > rmmod ib_srp > modprobe ib_srp > > > I'm going to try and track down how the list is getting corrupted; it > looks like attribute_container_list in

Re: [ofa-general] list corruption on ib_srp load in v2.6.24-rc5

2007-12-21 Thread Roland Dreier
> I'm getting the following oops when doing the following commands: > > modprobe ib_srp > > rmmod ib_srp > modprobe ib_srp > > > I'm going to try and track down how the list is getting corrupted; it > looks like attribute_container_list in > drivers/base/attribute_container.c is the

Re: list corruption on ib_srp load in v2.6.24-rc5

2007-12-21 Thread David Dillow
On Fri, 2007-12-21 at 16:52 -0500, David Dillow wrote: > Before I get too far into this, has anyone seen this one before? I > looked at 'git diff v2.6.24-rc4..' and didn't see any changes that would > stand out as fixing it. This should read v2.6.24-rc5... -- To unsubscribe from this list: send

list corruption on ib_srp load in v2.6.24-rc5

2007-12-21 Thread David Dillow
I'm getting the following oops when doing the following commands: modprobe ib_srp rmmod ib_srp modprobe ib_srp I'm going to try and track down how the list is getting corrupted; it looks like attribute_container_list in drivers/base/attribute_container.c is the one getting corrupted. Before I