Re: linux-next crash in xhci_add_ep_to_interval

2014-06-05 Thread Dan Williams
On Thu, Jun 5, 2014 at 2:10 PM, wrote: > On Thu, 05 Jun 2014 12:05:56 -0700, Dan Williams said: > >> Subject: usb: fix ->update_hub_device() vs hdev->maxchild >> >> From: Dan Williams >> >> Commit d8521afe3586 "usb: assign default peer ports for root hubs" >> delayed marking a hub valid (set hde

Re: linux-next crash in xhci_add_ep_to_interval

2014-06-05 Thread Valdis . Kletnieks
On Thu, 05 Jun 2014 12:05:56 -0700, Dan Williams said: > Subject: usb: fix ->update_hub_device() vs hdev->maxchild > > From: Dan Williams > > Commit d8521afe3586 "usb: assign default peer ports for root hubs" > delayed marking a hub valid (set hdev->maxchild) until it had been fully > configured

Re: linux-next crash in xhci_add_ep_to_interval

2014-06-05 Thread Dan Williams
On Thu, 2014-06-05 at 13:29 -0400, valdis.kletni...@vt.edu wrote: > On Thu, 05 Jun 2014 09:35:48 -0700, Dan Williams said: > > > Actually, on second look I bet xhci_alloc_tt_info() is being called > > while hdev->maxchild is not set. Let me throw together a debug > > patch... > > Sure, no proble

Re: linux-next crash in xhci_add_ep_to_interval

2014-06-05 Thread Valdis . Kletnieks
On Thu, 05 Jun 2014 09:35:48 -0700, Dan Williams said: > Actually, on second look I bet xhci_alloc_tt_info() is being called > while hdev->maxchild is not set. Let me throw together a debug > patch... Sure, no problem - just let me know what variant of linux-next you want it applied against. :)

Re: linux-next crash in xhci_add_ep_to_interval

2014-06-05 Thread Dan Williams
On Thu, Jun 5, 2014 at 9:24 AM, wrote: > On Thu, 05 Jun 2014 08:55:07 -0700, Dan Williams said: > >> > On a working boot, it progresses: >> >> Is a working boot after reverting that change, or it intermittently >> works? If it's the latter I'm not sure I trust the bisect result, >> yet. > > Oh,

Re: linux-next crash in xhci_add_ep_to_interval

2014-06-05 Thread Valdis . Kletnieks
On Thu, 05 Jun 2014 08:55:07 -0700, Dan Williams said: > > On a working boot, it progresses: > > Is a working boot after reverting that change, or it intermittently > works? If it's the latter I'm not sure I trust the bisect result, > yet. Oh, it's a 100% guaranteed crash. The following is from

Re: linux-next crash in xhci_add_ep_to_interval

2014-06-05 Thread Dan Williams
[ adding Mathias ] On Thu, Jun 5, 2014 at 8:22 AM, Valdis Kletnieks wrote: > Dell Latitude E6530, BIOS A11, seeing a crash in xhci_add_ep_to_interval > when it's docked in a newer dock that has USB3. > > It's very possible that the BIOS is buggy - it isn't like I haven't found > BIOS bugs in ever

linux-next crash in xhci_add_ep_to_interval

2014-06-05 Thread Valdis Kletnieks
Dell Latitude E6530, BIOS A11, seeing a crash in xhci_add_ep_to_interval when it's docked in a newer dock that has USB3. It's very possible that the BIOS is buggy - it isn't like I haven't found BIOS bugs in every single Dell laptop I've had. :) But that shouldn't make the kernel crash lsusb