Re: linux-next: build failure after merge of the spi tree

2018-08-28 Thread Baolin Wang
Hi Mark, On 29 August 2018 at 08:33, Stephen Rothwell wrote: > Hi Mark, > > After merging the spi tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > In file included from include/linux/clk.h:16, > from drivers/spi/spi-sprd.c:4: > drivers/spi/spi-sprd.c:

linux-next: build failure after merge of the spi tree

2018-08-28 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from include/linux/clk.h:16, from drivers/spi/spi-sprd.c:4: drivers/spi/spi-sprd.c: In function 'sprd_spi_init_hw': drivers/spi/spi-sprd.c:462:29: error: 'struct

Re: linux-next: build failure after merge of the spi tree

2017-12-22 Thread Mark Brown
On Fri, Dec 22, 2017 at 08:39:36AM +0100, Rasmus Villemoes wrote: > Want a follow-up patch or a replacement? As the mail you got when the patch was applied says: | If any updates are required or you are submitting further changes they | should be sent as incremental updates against current git,

Re: linux-next: build failure after merge of the spi tree

2017-12-21 Thread Rasmus Villemoes
On 22 December 2017 at 03:18, Stephen Rothwell wrote: > Hi Mark, > > After merging the spi tree, today's linux-next build (x86_64 allmodconfig > build) failed like this: > > drivers/spi/spi-pxa2xx.c: In function 'setup_cs': > drivers/spi/spi-pxa2xx.c:1240:3: error: implicit declaration of function

linux-next: build failure after merge of the spi tree

2017-12-21 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (x86_64 allmodconfig build) failed like this: drivers/spi/spi-pxa2xx.c: In function 'setup_cs': drivers/spi/spi-pxa2xx.c:1240:3: error: implicit declaration of function 'gpiod_free' [-Werror=implicit-function-declaration] gpiod_fre

linux-next: build failure after merge of the spi tree

2017-07-09 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/spi/spi-imx.c: In function 'spi_imx_setupxfer': drivers/spi/spi-imx.c:1007:16: error: 'config' undeclared (first use in this function) mask = (1 << config.bpw) - 1; ^

linux-next: build failure after merge of the spi tree

2017-07-02 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/spi/spi-imx.c: In function 'spi_imx_setupxfer': drivers/spi/spi-imx.c:1007:16: error: 'config' undeclared (first use in this function) mask = (1 << config.bpw) - 1; ^

Re: linux-next: build failure after merge of the spi tree

2017-05-23 Thread Jiada Wang
Hi Mark since commit 8d4a6cad7adb ("spi: imx: dynamic burst length adjust for PIO mode ") has been reverted, then commit 1ce1c618e6b5 ("spi: imx: only allow dynamic burst in PIO mode") need to be reverted as well. I can submit another version of patch set, with all founded issues be addressed

linux-next: build failure after merge of the spi tree

2017-05-23 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/spi/spi-imx.c: In function 'spi_imx_can_dma': drivers/spi/spi-imx.c:241:9: error: 'struct spi_imx_data' has no member named 'dynamic_burst' spi_imx->dynamic_burst = 0; ^ Caus

Re: linux-next: build failure after merge of the spi tree

2016-12-11 Thread Stephen Rothwell
Hi Mark, On Fri, 9 Dec 2016 13:32:56 +1100 Stephen Rothwell wrote: > > After merging the spi tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/spi/spi-orion.c: In function 'orion_spi_baudrate_set': > drivers/spi/spi-orion.c:192:8: error: 'sspr' undeclared (

linux-next: build failure after merge of the spi tree

2016-12-08 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/spi/spi-orion.c: In function 'orion_spi_baudrate_set': drivers/spi/spi-orion.c:192:8: error: 'sspr' undeclared (first use in this function) if (sspr > 7) ^ Caused by comm

Re: linux-next: build failure after merge of the spi tree

2016-05-16 Thread Mark Brown
On Mon, May 16, 2016 at 12:08:31PM +1000, Stephen Rothwell wrote: > Hi Mark, > > After merging the spi tree, today's linux-next build (x86_64 allmodconfig) > failed like this: Sorry, dropped this patch. signature.asc Description: PGP signature

linux-next: build failure after merge of the spi tree

2016-05-15 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/spi/spi-orion.c: In function 'orion_spi_write_read': drivers/spi/spi-orion.c:407:3: error: implicit declaration of function 'writesl' [-Werror=implicit-function-declaration] writesl(o

linux-next: build failure after merge of the spi tree

2016-01-05 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/spi/spi-loopback-test.c: In function 'spi_loopback_test_probe': drivers/spi/spi-loopback-test.c:292:7: error: 'check_rx_buf' undeclared (first use in this function) if (!check_rx_buf &

linux-next: build failure after merge of the spi tree

2015-08-20 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (arm multi_v7_defconfig) failed like this: In file included from include/linux/clk.h:16:0, from drivers/spi/spi-sun4i.c:14: drivers/spi/spi-sun4i.c: In function 'sun4i_spi_transfer_one': drivers/spi/spi-sun4i.c:283:43:

linux-next: build failure after merge of the spi tree

2015-05-11 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/spi/spi-bcm2835.c: In function 'bcm2835_spi_can_dma': drivers/spi/spi-bcm2835.c:381:7: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] if (((u32)tfr->tx

linux-next: build failure after merge of the spi tree

2015-04-06 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/spi/spi-fsl-dspi.c: In function 'dspi_setup': drivers/spi/spi-fsl-dspi.c:395:2: error: implicit declaration of function 'ns_delay_scale' [-Werror=implicit-function-declaration] ns_dela

Re: linux-next: build failure after merge of the spi tree

2015-01-29 Thread Ricardo Ribalda Delgado
Hello Stephen The root of the issue is that iowrite/ioread behaves differently in different arches. 1) It does not necesary need to be a symbol in all the arches. It can be declared as a function macro: #define iowrite32(a,b) iowrite32(a,b) 2) Sometimes, even the function has a different protot

linux-next: build failure after merge of the spi tree

2015-01-29 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/spi/spi-xilinx.c: In function 'xilinx_spi_probe': drivers/spi/spi-xilinx.c:391:16: warning: assignment from incompatible pointer type xspi->read_fn = ioread32; ^ dri

Re: linux-next: build failure after merge of the spi tree

2014-12-08 Thread Laurentiu Palcu
On Mon, Dec 08, 2014 at 11:05:17PM +1100, Stephen Rothwell wrote: > Hi Mark, > > After merging the spi tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/spi/spi-dln2.c: In function 'dln2_spi_copy_from_buf': > drivers/spi/spi-dln2.c:415:4: error: implicit declar

Re: linux-next: build failure after merge of the spi tree

2014-12-08 Thread Mark Brown
On Mon, Dec 08, 2014 at 12:54:47PM +, Lee Jones wrote: > Patches re-sent without COMPILE_TEST support. > I will re-enable COMPILE_TEST when Will Deacon's patch to fix this > kind of nonsense lands. It wasn't the _relaxed() stuff that was triggering, it was implicit inclusions of the pinctrl

Re: linux-next: build failure after merge of the spi tree

2014-12-08 Thread Lee Jones
On Mon, 08 Dec 2014, Mark Brown wrote: > On Mon, Dec 08, 2014 at 11:05:17PM +1100, Stephen Rothwell wrote: > > > Caused by commit cf9e9c98fa8c ("spi: Add new driver for > > STMicroelectronics' SPI Controller"). > > > To me COMPILE_TEST means "this builds everywhere, make sure it doesn't > > brea

Re: linux-next: build failure after merge of the spi tree

2014-12-08 Thread Mark Brown
On Mon, Dec 08, 2014 at 11:05:17PM +1100, Stephen Rothwell wrote: > Caused by commit cf9e9c98fa8c ("spi: Add new driver for > STMicroelectronics' SPI Controller"). > To me COMPILE_TEST means "this builds everywhere, make sure it doesn't > break" ... not "lets set this and see if Stephen finds any

linux-next: build failure after merge of the spi tree

2014-12-08 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/spi/spi-dln2.c: In function 'dln2_spi_copy_from_buf': drivers/spi/spi-dln2.c:415:4: error: implicit declaration of function 'get_unaligned_le32' [-Werror=implicit-function-declaration]

RE: linux-next: build failure after merge of the spi tree

2014-04-14 Thread Harini Katakam
Hi Stephen/Mark, > -Original Message- > From: Stephen Rothwell [mailto:s...@canb.auug.org.au] > Sent: Tuesday, April 15, 2014 7:47 AM > To: Mark Brown > Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Harini > Katakam > Subject: linux-next: build failu

linux-next: build failure after merge of the spi tree

2014-04-14 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (x86_64_allmodconfig) failed like this: drivers/spi/spi-cadence.c: In function 'cdns_spi_write': drivers/spi/spi-cadence.c:135:2: error: implicit declaration of function 'writel_relaxed' [-Werror=implicit-function-declaration] write

Re: linux-next: build failure after merge of the spi tree

2014-02-23 Thread Mark Brown
On Mon, Feb 24, 2014 at 02:45:29PM +1100, Stephen Rothwell wrote: > compilation with COMPILE_TEST"). Please at least test building on x86 > before allowing a build with COMPILE_TEST. Yeah, I tend to rely on the zero day tester to get that when travelling since it's normally quicker to get a resu

linux-next: build failure after merge of the spi tree

2014-02-23 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/spi/spi-qup.c: In function 'spi_qup_set_state': drivers/spi/spi-qup.c:185:3: error: implicit declaration of function 'writel_relaxed' [-Werror=implicit-function-declaration] writel_re

Re: linux-next: build failure after merge of the spi tree

2014-01-05 Thread Baruch Siach
Hi Stephen, On Mon, Jan 06, 2014 at 06:03:05PM +1100, Stephen Rothwell wrote: > After merging the spi tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > drivers/spi/spi-dw-pci.c: In function 'spi_pci_probe': > drivers/spi/spi-dw-pci.c:50:29: error: 'dev' undeclared (firs

linux-next: build failure after merge of the spi tree

2014-01-05 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/spi/spi-dw-pci.c: In function 'spi_pci_probe': drivers/spi/spi-dw-pci.c:50:29: error: 'dev' undeclared (first use in this function) dwpci = devm_kzalloc(&pdev-dev, sizeof(struct dw_spi

Re: linux-next: build failure after merge of the spi tree

2013-08-27 Thread Sourav Poddar
Hi, On Tuesday 27 August 2013 11:45 AM, Stephen Rothwell wrote: Hi Mark, After merging the spi tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from drivers/spi/spi-ti-qspi.c:19:0: include/linux/module.h:87:32: error: '__mod_of_device_table' aliased to un

linux-next: build failure after merge of the spi tree

2013-08-26 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from drivers/spi/spi-ti-qspi.c:19:0: include/linux/module.h:87:32: error: '__mod_of_device_table' aliased to undefined symbol 'dra7xxx_qspi_match' extern const struct gtype##_i

Re: linux-next: build failure after merge of the spi tree

2013-07-29 Thread Mark Brown
On Mon, Jul 29, 2013 at 04:48:20PM +1000, Stephen Rothwell wrote: > On Mon, 29 Jul 2013 07:40:28 +0100 Mark Brown wrote: > > Yeah, unfortunately those issues are a good proportion of what gets > > caught by this sort of testing that wouldn't get caught in normal > > development so it doesn't seem

Re: linux-next: build failure after merge of the spi tree

2013-07-28 Thread Stephen Rothwell
Hi Mark, On Mon, 29 Jul 2013 07:40:28 +0100 Mark Brown wrote: > > Yeah, unfortunately those issues are a good proportion of what gets > caught by this sort of testing that wouldn't get caught in normal > development so it doesn't seem worth doing something that won't at least > give a linking ker

Re: linux-next: build failure after merge of the spi tree

2013-07-28 Thread Mark Brown
On Mon, Jul 29, 2013 at 03:56:09PM +1000, Stephen Rothwell wrote: > Did the 0 day tester find these? If so, then maybe you should wait a > while longer before adding these things to your published trees. If not, > then I wonder why not. No, it didn't. The latency from the zero day tester seems

Re: linux-next: build failure after merge of the spi tree

2013-07-28 Thread Stephen Rothwell
Hi Mark, On Mon, 29 Jul 2013 06:00:11 +0100 Mark Brown wrote: > > On Mon, Jul 29, 2013 at 01:42:23PM +1000, Stephen Rothwell wrote: > > > drivers/spi/spi-pxa2xx-pxadma.c: In function 'wait_dma_channel_stop': > > drivers/spi/spi-pxa2xx-pxadma.c:136:2: error: implicit declaration of > > function

Re: linux-next: build failure after merge of the spi tree

2013-07-28 Thread Mark Brown
On Mon, Jul 29, 2013 at 01:42:23PM +1000, Stephen Rothwell wrote: > drivers/spi/spi-pxa2xx-pxadma.c: In function 'wait_dma_channel_stop': > drivers/spi/spi-pxa2xx-pxadma.c:136:2: error: implicit declaration of > function 'DCSR' [-Werror=implicit-function-declaration] > while (!(DCSR(channel) &

linux-next: build failure after merge of the spi tree

2013-07-28 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/spi/spi-pxa2xx-pxadma.c: In function 'wait_dma_channel_stop': drivers/spi/spi-pxa2xx-pxadma.c:136:2: error: implicit declaration of function 'DCSR' [-Werror=implicit-function-declaration