linux-next: build failure after merge of the keys tree

2020-12-10 Thread Stephen Rothwell
Hi all, After merging the keys tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from include/linux/cred.h:13, from security/integrity/ima/ima_mok.c:12: security/integrity/ima/ima_mok.c: In function 'ima_mok_init': include/linux/key.h:292:29:

linux-next: build failure after merge of the keys tree

2020-05-17 Thread Stephen Rothwell
Hi all, After merging the keys tree, today's linux-next build (x86_64 allmodconfig) failed like this: x86_64-linux-gnu-ld: security/keys/big_key.o: in function `big_key_read': big_key.c:(.text+0x562): undefined reference to `chacha20poly1305_decrypt' x86_64-linux-gnu-ld: security/keys/big_key.o:

Re: linux-next: build failure after merge of the keys tree

2020-05-14 Thread Jason A. Donenfeld
On Thu, May 14, 2020 at 6:35 AM Masahiro Yamada wrote: > > On Thu, May 14, 2020 at 9:11 PM David Howells wrote: > > > > Jason A. Donenfeld wrote: > > > > > Your touch might be helpful here. CRYPTO_LIB_CHACHA20POLY1305 is a > > > tristate and depends on as well as selects other things that are >

Re: linux-next: build failure after merge of the keys tree

2020-05-14 Thread Masahiro Yamada
On Thu, May 14, 2020 at 9:11 PM David Howells wrote: > > Jason A. Donenfeld wrote: > > > Your touch might be helpful here. CRYPTO_LIB_CHACHA20POLY1305 is a > > tristate and depends on as well as selects other things that are > > tristates. > > > > Meanwhile BIG_KEYS is a bool, which needs to sele

Re: linux-next: build failure after merge of the keys tree

2020-05-14 Thread David Howells
Jason A. Donenfeld wrote: > Your touch might be helpful here. CRYPTO_LIB_CHACHA20POLY1305 is a > tristate and depends on as well as selects other things that are > tristates. > > Meanwhile BIG_KEYS is a bool, which needs to select > CRYPTO_LIB_CHACHA20POLY1305. However, it gets antsy if the the

Re: linux-next: build failure after merge of the keys tree

2020-05-13 Thread Jason A. Donenfeld
Hey Masahiro, Your touch might be helpful here. CRYPTO_LIB_CHACHA20POLY1305 is a tristate and depends on as well as selects other things that are tristates. Meanwhile BIG_KEYS is a bool, which needs to select CRYPTO_LIB_CHACHA20POLY1305. However, it gets antsy if the the symbol its selecting has

linux-next: build failure after merge of the keys tree

2020-05-13 Thread Stephen Rothwell
Hi all, After merging the keys tree, today's linux-next build (x86_64 allmodconfig) failed like this: WARNING: unmet direct dependencies detected for CRYPTO_LIB_CHACHA20POLY1305 Depends on [m]: CRYPTO [=y] && (CRYPTO_ARCH_HAVE_LIB_CHACHA [=m] || !CRYPTO_ARCH_HAVE_LIB_CHACHA [=m]) && (CRYPTO_AR

Re: linux-next: build failure after merge of the keys tree

2020-05-03 Thread Stephen Rothwell
Hi all, On Mon, 4 May 2020 13:25:29 +1000 Stephen Rothwell wrote: > > Due to further changes in Linus' tree over the weekend, this fixup is > not linger needed. "no longer" (Monday's ...) -- Cheers, Stephen Rothwell pgpQJB6x10RtY.pgp Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the keys tree

2020-05-03 Thread Stephen Rothwell
Hi all, On Mon, 2 Mar 2020 11:37:37 +1100 Stephen Rothwell wrote: > > After merging the keys tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > fs/io_uring.c: In function 'io_splice_punt': > fs/io_uring.c:2473:6: error: too few arguments to function 'get_pipe_info'

Re: linux-next: build failure after merge of the keys tree

2019-09-02 Thread Stephen Rothwell
Hi David, On Tue, 03 Sep 2019 00:53:14 +0100 David Howells wrote: > > Stephen Rothwell wrote: > > > > I was doing an x86_64 allmodconfig build which seems to build (all of?) > > > the samples. > > > > Of course, this breaks our crossbuilds :-( > > > > e.g. S390 allyesconfig build: > > > >

Re: linux-next: build failure after merge of the keys tree

2019-09-02 Thread David Howells
Stephen Rothwell wrote: > > I was doing an x86_64 allmodconfig build which seems to build (all of?) > > the samples. > > Of course, this breaks our crossbuilds :-( > > e.g. S390 allyesconfig build: > > /usr/bin/ld: cannot find -lkeyutils Is it a requirement that stuff in samples/ should be ab

Re: linux-next: build failure after merge of the keys tree

2019-09-02 Thread David Howells
Stephen Rothwell wrote: > > Ah, yes - the sample demonstrates the key/keyring notifications as well as > > USB and block notifications and requires a constant from the > > keyutils-devel package. Maybe I should get it from the kernel UAPI > > headers instead, but that risks generating a collisio

Re: linux-next: build failure after merge of the keys tree

2019-09-02 Thread Stephen Rothwell
Hi David, On Tue, 03 Sep 2019 00:20:08 +0100 David Howells wrote: > > Ah, yes - the sample demonstrates the key/keyring notifications as well as USB > and block notifications and requires a constant from the keyutils-devel > package. Maybe I should get it from the kernel UAPI headers instead, bu

Re: linux-next: build failure after merge of the keys tree

2019-09-02 Thread Stephen Rothwell
Hi David, On Tue, 3 Sep 2019 09:07:22 +1000 Stephen Rothwell wrote: > > > > I then discovered that I needed to install libkeyutils-dev :-( but it > > > built OK after that. > > > > ? The kernel shouldn't require that to build. > > I was doing an x86_64 allmodconfig build which seems to

Re: linux-next: build failure after merge of the keys tree

2019-09-02 Thread David Howells
Stephen Rothwell wrote: > > static inline void post_usb_device_notification(const struct usb_device > > *udev, > > unsigned int subtype, u32 > > error) {} > > But not published, yet? I was hoping to get the smack patch reviewed by Casey first, but I

Re: linux-next: build failure after merge of the keys tree

2019-09-02 Thread Stephen Rothwell
Hi David, On Mon, 02 Sep 2019 17:01:19 +0100 David Howells wrote: > > Stephen Rothwell wrote: > > > The forward declararion doesn't seem to work (at laste for the > > !CONFIG_USB_NOTIFICATIONS case. > > In the !CONFIG_USB_NOTIFICATIONS case, the argument is to a stub inline > function. Even

Re: linux-next: build failure after merge of the keys tree

2019-09-02 Thread David Howells
Stephen Rothwell wrote: > The forward declararion doesn't seem to work (at laste for the > !CONFIG_USB_NOTIFICATIONS case. In the !CONFIG_USB_NOTIFICATIONS case, the argument is to a stub inline function. Even though the argument isn't actually used, it can't be an undefined type - and, I'm gue

Re: linux-next: build failure after merge of the keys tree

2019-09-01 Thread Stephen Rothwell
Hi all, On Thu, 29 Aug 2019 15:31:16 +1000 Stephen Rothwell wrote: > > After merging the keys tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > > Caused by commit > > ef9cc255c953 ("usb: Add USB subsystem notifications") > > # CONFIG_USB_NOTIFICATIONS is not s

linux-next: build failure after merge of the keys tree

2019-08-28 Thread Stephen Rothwell
Hi all, After merging the keys tree, today's linux-next build (arm multi_v7_defconfig) failed like this: Caused by commit ef9cc255c953 ("usb: Add USB subsystem notifications") # CONFIG_USB_NOTIFICATIONS is not set I have used the keys tree from next-20190828 for today. -- Cheers, Stephen

linux-next: build failure after merge of the keys tree

2019-08-15 Thread Stephen Rothwell
Hi all, After merging the keys tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/md/dm-verity-verify-sig.c: In function 'verity_verify_get_sig_from_key': drivers/md/dm-verity-verify-sig.c:38:8: error: too few arguments to function 'request_key' key = request_key(&k

Re: linux-next: build failure after merge of the keys tree

2017-11-13 Thread David Howells
I've dropped the keyrings ACL patches from the branch for now. I'll revisit them after the merge window. David

linux-next: build failure after merge of the keys tree

2017-11-12 Thread Stephen Rothwell
Hi David, After merging the keys tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: drivers/md/dm-crypt.c: In function 'crypt_set_keyring_key': drivers/md/dm-crypt.c:2022:8: error: too few arguments to function 'request_key' key = request_key(key_string[0] == 'l' ? &key_

linux-next: build failure after merge of the keys tree

2017-04-03 Thread Stephen Rothwell
Hi David, After merging the keys tree, today's linux-next build (x86_64 allmodconfig) failed like this: security/integrity/digsig.c: In function 'integrity_init_keyring': security/integrity/digsig.c:46:30: error: passing argument 7 of 'keyring_alloc' from incompatible pointer type [-Werror=incom