Re: libata-core: devslp fails on ATP mSATA

2015-12-03 Thread Andreas Werner
On Thu, Dec 03, 2015 at 10:15:49AM -0500, Tejun Heo wrote: > Hello, > > On Thu, Dec 03, 2015 at 10:33:55AM +0100, Andreas Werner wrote: > > All the other "flag" fields in the structs are used and/or reserved > > and it seems to be no good place for such flags. > > You can use the port flags - ATA

Re: libata-core: devslp fails on ATP mSATA

2015-12-03 Thread Tejun Heo
Hello, On Thu, Dec 03, 2015 at 10:33:55AM +0100, Andreas Werner wrote: > All the other "flag" fields in the structs are used and/or reserved > and it seems to be no good place for such flags. You can use the port flags - ATA_FLAG_*. > What I am thinking about is. > > 1. Add new flag e.g. ATA_HO

Re: libata-core: devslp fails on ATP mSATA

2015-12-03 Thread Andreas Werner
On Wed, Dec 02, 2015 at 11:47:53AM -0500, Tejun Heo wrote: > Hello, Andreas. > > On Wed, Dec 02, 2015 at 10:33:10AM +0100, Andreas Werner wrote: > > Blacklisting the controller would be a solution yes, but I just > > wanna wait the answer from the FAE to be sure we really have a > > problem. > >

Re: libata-core: devslp fails on ATP mSATA

2015-12-02 Thread Tejun Heo
Hello, Andreas. On Wed, Dec 02, 2015 at 10:33:10AM +0100, Andreas Werner wrote: > Blacklisting the controller would be a solution yes, but I just > wanna wait the answer from the FAE to be sure we really have a > problem. > > What kind of identifier can I use for blacklisting? The driver name > f

Re: libata-core: devslp fails on ATP mSATA

2015-12-02 Thread Andreas Werner
On Tue, Dec 01, 2015 at 02:04:10PM -0500, Tejun Heo wrote: > On Tue, Dec 01, 2015 at 11:17:15AM -0500, Tejun Heo wrote: > > So, I suppose this is a fallout from 9faa643855df ("libata: use > > READ_LOG_DMA_EXT"). The description just says "we should try use it" > > but is there any benefit from usi

Re: libata-core: devslp fails on ATP mSATA

2015-12-01 Thread Tejun Heo
On Tue, Dec 01, 2015 at 11:17:15AM -0500, Tejun Heo wrote: > So, I suppose this is a fallout from 9faa643855df ("libata: use > READ_LOG_DMA_EXT"). The description just says "we should try use it" > but is there any benefit from using NCQ variant of read log page? I > mean, it's used during config

Re: libata-core: devslp fails on ATP mSATA

2015-12-01 Thread Andreas Werner
Hi, first sorry for the bad email format, but the IT decided to add my Email signature as HTML on the Exchange Server, this is why lkml rejected the email. Therefore I will switch to my private address. I do not think that the commit you mention is the root cause for this problem, because it is

Re: libata-core: devslp fails on ATP mSATA

2015-12-01 Thread Tejun Heo
(cc'ing Hannes and Margin) Hello, On Tue, Dec 01, 2015 at 10:22:34AM +0100, Andreas Werner wrote: > Hi, > i have a question regarding the devslp feature in several SATA devices. > > I currently working on an embedded board with a Freescale P1013/P1022. > I have a mSATA Device from ATP which is c