Re: leds: avoid flush_work in atomic context

2019-05-26 Thread Hugh Dickins
On Sun, 26 May 2019, Pavel Machek wrote: > Hi! > > > Thank you for the patch. > > > > I've applied it however I'm not sure if it is an official > > submission, since it doesn't look like (no [PATCH] tag > > in the subject). > > It was official submission :-). > > > Beside that 'Fixes' tag is so

Re: leds: avoid flush_work in atomic context

2019-05-26 Thread Pavel Machek
Hi! > Thank you for the patch. > > I've applied it however I'm not sure if it is an official > submission, since it doesn't look like (no [PATCH] tag > in the subject). It was official submission :-). > Beside that 'Fixes' tag is somewhat incomplete - it should be > generated using following gi

Re: leds: avoid flush_work in atomic context

2019-05-26 Thread Jacek Anaszewski
Hi Pavel, Thank you for the patch. I've applied it however I'm not sure if it is an official submission, since it doesn't look like (no [PATCH] tag in the subject). Beside that 'Fixes' tag is somewhat incomplete - it should be generated using following git command: git log -1 0db37915d912 --fo

leds: avoid flush_work in atomic context

2019-05-26 Thread Pavel Machek
It turns out that various triggers use led_blink_setup() from atomic context, so we can't do a flush_work there. Flush is still needed for slow LEDs, but we can move it to sysfs code where it is safe. WARNING: inconsistent lock state 5.2.0-rc1 #1 Tainted: GW --