On Mon, Jun 27, 2016 at 04:24:22PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki
> Subject: [PATCH v2] x86/power/64: Fix kernel text mapping corruption during
> image restoration
>
> Logan Gunthorpe reports that hibernation stopped working reliably for
> him after commit ab76f7b4ab23
On Tuesday, June 21, 2016 11:04:41 AM Kees Cook wrote:
> On Mon, Jun 20, 2016 at 9:35 PM, Logan Gunthorpe wrote:
> > Hey Rafael,
> >
> > This patch appears to be working on my laptop. Thanks.
>
> Same for me: resume still works with KASLR in my tests too.
Unfortunately, Boris still sees post-res
On Tuesday, June 21, 2016 11:04:41 AM Kees Cook wrote:
> On Mon, Jun 20, 2016 at 9:35 PM, Logan Gunthorpe wrote:
> > Hey Rafael,
> >
> > This patch appears to be working on my laptop. Thanks.
>
> Same for me: resume still works with KASLR in my tests too.
Thanks for the confirmation!
Rafael
On Mon, Jun 20, 2016 at 9:35 PM, Logan Gunthorpe wrote:
> Hey Rafael,
>
> This patch appears to be working on my laptop. Thanks.
Same for me: resume still works with KASLR in my tests too.
-Kees
--
Kees Cook
Chrome OS & Brillo Security
On Monday, June 20, 2016 10:35:16 PM Logan Gunthorpe wrote:
> Hey Rafael,
Hi,
> This patch appears to be working on my laptop. Thanks.
Thanks for the confirmation!
Rafael
Hey Rafael,
This patch appears to be working on my laptop. Thanks.
Logan
On 20/06/16 07:22 PM, Rafael J. Wysocki wrote:
On Tuesday, June 21, 2016 02:05:59 AM Rafael J. Wysocki wrote:
On Monday, June 20, 2016 11:15:18 PM Rafael J. Wysocki wrote:
On Mon, Jun 20, 2016 at 8:29 PM, Linus Torvalds
On Tuesday, June 21, 2016 02:05:59 AM Rafael J. Wysocki wrote:
> On Monday, June 20, 2016 11:15:18 PM Rafael J. Wysocki wrote:
> > On Mon, Jun 20, 2016 at 8:29 PM, Linus Torvalds
> > wrote:
> > > On Mon, Jun 20, 2016 at 7:38 AM, Rafael J. Wysocki
> > > wrote:
> > >>
> > >> Overall, we seem to be
On Monday, June 20, 2016 11:15:18 PM Rafael J. Wysocki wrote:
> On Mon, Jun 20, 2016 at 8:29 PM, Linus Torvalds
> wrote:
> > On Mon, Jun 20, 2016 at 7:38 AM, Rafael J. Wysocki
> > wrote:
> >>
> >> Overall, we seem to be heading towards the "really weird" territory here.
> >
> > So the whole comm
On Mon, Jun 20, 2016 at 8:29 PM, Linus Torvalds
wrote:
> On Mon, Jun 20, 2016 at 7:38 AM, Rafael J. Wysocki wrote:
>>
>> Overall, we seem to be heading towards the "really weird" territory here.
>
> So the whole commit that Boris bisected down to is weird to me.
>
> Why isn't the temporary text m
On Mon, Jun 20, 2016 at 7:38 AM, Rafael J. Wysocki wrote:
>
> Overall, we seem to be heading towards the "really weird" territory here.
So the whole commit that Boris bisected down to is weird to me.
Why isn't the temporary text mapping just set up unconditionally in
the temp_level4_pgt?
Why do
On Friday, June 17, 2016 11:03:46 PM Rafael J. Wysocki wrote:
> On Fri, Jun 17, 2016 at 6:12 PM, Borislav Petkov wrote:
> > On Fri, Jun 17, 2016 at 05:28:10PM +0200, Rafael J. Wysocki wrote:
> >> A couple of questions:
> >> - I guess this is reproducible 100% of the time?
> >
> > Yap.
> >
> > I to
On Monday, June 20, 2016 04:17:13 PM chenyu wrote:
> On Fri, Jun 17, 2016 at 11:28 PM, Rafael J. Wysocki wrote:
> > On Fri, Jun 17, 2016 at 4:33 PM, Borislav Petkov wrote:
> >> Ok,
> >>
> >> bisect is done, full log below.
> >>
> >> Rafael, that fix
> >>
> >> 70595b479ce1 ("x86/power/64: Fix cr
On Fri, Jun 17, 2016 at 11:28 PM, Rafael J. Wysocki wrote:
> On Fri, Jun 17, 2016 at 4:33 PM, Borislav Petkov wrote:
>> Ok,
>>
>> bisect is done, full log below.
>>
>> Rafael, that fix
>>
>> 70595b479ce1 ("x86/power/64: Fix crash whan the hibernation code passes
>> control to the image kernel"
On Fri, Jun 17, 2016 at 11:03 PM, Rafael J. Wysocki wrote:
> On Fri, Jun 17, 2016 at 6:12 PM, Borislav Petkov wrote:
>> On Fri, Jun 17, 2016 at 05:28:10PM +0200, Rafael J. Wysocki wrote:
>>> A couple of questions:
>>> - I guess this is reproducible 100% of the time?
>>
>> Yap.
>>
>> I took latest
On Fri, Jun 17, 2016 at 6:12 PM, Borislav Petkov wrote:
> On Fri, Jun 17, 2016 at 05:28:10PM +0200, Rafael J. Wysocki wrote:
>> A couple of questions:
>> - I guess this is reproducible 100% of the time?
>
> Yap.
>
> I took latest Linus + tip/master which has your commit.
>
>> - If you do "echo dis
On Fri, Jun 17, 2016 at 05:28:10PM +0200, Rafael J. Wysocki wrote:
> A couple of questions:
> - I guess this is reproducible 100% of the time?
Yap.
I took latest Linus + tip/master which has your commit.
> - If you do "echo disk > /sys/power/state" instead of using s2disk,
> does it still crash
On Fri, Jun 17, 2016 at 4:33 PM, Borislav Petkov wrote:
> Ok,
>
> bisect is done, full log below.
>
> Rafael, that fix
>
> 70595b479ce1 ("x86/power/64: Fix crash whan the hibernation code passes
> control to the image kernel")
>
> breaks s2disk here. It explodes during resume and a statically a
Ok,
bisect is done, full log below.
Rafael, that fix
70595b479ce1 ("x86/power/64: Fix crash whan the hibernation code passes
control to the image kernel")
breaks s2disk here. It explodes during resume and a statically allocated
struct's member is NULL. See
https://lkml.kernel.org/r/20160617
On Fri, Jun 17, 2016 at 01:53:53PM +0200, Thomas Gleixner wrote:
> It must be initialized otherwise you won't reach suspend. I have no idea how
> that can happen.
Btw, there's one other thing I'm seeing in the boot kernel, while it suspends.
It hardly is related though:
[ 42.046585] kvm: exitin
On Fri, 17 Jun 2016, Borislav Petkov wrote:
> look what I've found this morning during resume:
>
> [ 45.746236] BUG: unable to handle kernel done.
> [ 45.752542] NULL pointer dereference at 0001
> [ 45.752544] IP: [<0001>] 0x1
> static inline cycle_t timekeeping_get_
Hi guys,
look what I've found this morning during resume:
[ 45.732934] PM: Image restored successfully.
[ 45.738064] PM: Basic memory bitmaps freed
[ 45.742914] Restarting tasks ...
[ 45.746236] BUG: unable to handle kernel done.
[ 45.752542] NULL pointer dereference at 000
21 matches
Mail list logo
