Re: kswapd using __this_cpu_add() in preemptible code

2014-03-20 Thread Christoph Lameter
On Tue, 18 Mar 2014, Andrew Morton wrote: > Christoph caught one. How does this look? The fundamental decision to be made here is if we want the counter overhead coming on platforms that do not have lockless percpu atomics and therefore would require an irq on/off sequence for safe counter incre

Re: kswapd using __this_cpu_add() in preemptible code

2014-03-19 Thread Dave Chinner
On Tue, Mar 18, 2014 at 02:22:16PM -0700, Andrew Morton wrote: > On Tue, 18 Mar 2014 21:53:30 +0300 Sergey Senozhatsky > wrote: > > > Hello gentlemen, > > > > Commit 589a606f9539663f162e4a110d117527833b58a4 ("percpu: add preemption > > checks to __this_cpu ops") added preempt check to used in

Re: kswapd using __this_cpu_add() in preemptible code

2014-03-18 Thread Sergey Senozhatsky
On (03/18/14 14:22), Andrew Morton wrote: > On Tue, 18 Mar 2014 21:53:30 +0300 Sergey Senozhatsky > wrote: > > > Hello gentlemen, > > > > Commit 589a606f9539663f162e4a110d117527833b58a4 ("percpu: add preemption > > checks to __this_cpu ops") added preempt check to used in > > __count_vm_events

Re: kswapd using __this_cpu_add() in preemptible code

2014-03-18 Thread Andrew Morton
On Tue, 18 Mar 2014 21:53:30 +0300 Sergey Senozhatsky wrote: > Hello gentlemen, > > Commit 589a606f9539663f162e4a110d117527833b58a4 ("percpu: add preemption > checks to __this_cpu ops") added preempt check to used in __count_vm_events() > __this_cpu ops, causing the following kswapd warning: >

kswapd using __this_cpu_add() in preemptible code

2014-03-18 Thread Sergey Senozhatsky
Hello gentlemen, Commit 589a606f9539663f162e4a110d117527833b58a4 ("percpu: add preemption checks to __this_cpu ops") added preempt check to used in __count_vm_events() __this_cpu ops, causing the following kswapd warning: BUG: using __this_cpu_add() in preemptible [] code: kswapd0/56 ca