Re: kexec: device shutdown vs. remove

2016-07-24 Thread Benjamin Herrenschmidt
On Sun, 2016-07-24 at 16:36 -0500, Eric W. Biederman wrote: > > A lot of drivers we care about are modular. But maybe the right > > approach is to do something like remove() if it exist and > shutdown() if > > it doesn't ? Or a new callback for kexec ? quiesce() ? > > Perhaps remove if shutdown do

Re: kexec: device shutdown vs. remove

2016-07-24 Thread Eric W. Biederman
Benjamin Herrenschmidt writes: > On Sat, 2016-07-23 at 22:18 -0700, Guenter Roeck wrote: >> I suspect that using (or depending on) the remove function may not be >> feasible >> anymore after the recent effort by Paul Gortmaker to make drivers explicitly >> non-modular if they are only configurab

Re: kexec: device shutdown vs. remove

2016-07-24 Thread Eric W. Biederman
Benjamin Herrenschmidt writes: > On Sun, 2016-07-24 at 00:24 -0500, Eric W. Biederman wrote: >> If you are willing to do the work to merge shutdown into remove and >> simplify the drivers, perform the testing and the other state I am in >> favor of the change.  I think we have had enough time to

Re: kexec: device shutdown vs. remove

2016-07-24 Thread Benjamin Herrenschmidt
On Sun, 2016-07-24 at 00:24 -0500, Eric W. Biederman wrote: > If you are willing to do the work to merge shutdown into remove and > simplify the drivers, perform the testing and the other state I am in > favor of the change.  I think we have had enough time to see if have two > methods was maintain

Re: kexec: device shutdown vs. remove

2016-07-24 Thread Benjamin Herrenschmidt
On Sat, 2016-07-23 at 22:18 -0700, Guenter Roeck wrote: > I suspect that using (or depending on) the remove function may not be feasible > anymore after the recent effort by Paul Gortmaker to make drivers explicitly > non-modular if they are only configurable as boolean. In many cases, this > invol

Re: kexec: device shutdown vs. remove

2016-07-23 Thread Eric W. Biederman
Benjamin Herrenschmidt writes: > Hi ! > > This is somewhat of a recurring issue, some of my previous attempts on > lkml, I suspect, were just drowned in the noise. Eric, we had a quick > discussion about this a while back but I don't think we reached a > conclusion. > > A bit of context: On OpenP

Re: kexec: device shutdown vs. remove

2016-07-23 Thread Guenter Roeck
On Sun, Jul 24, 2016 at 06:51:52AM +1000, Benjamin Herrenschmidt wrote: > Hi ! > > This is somewhat of a recurring issue, some of my previous attempts on > lkml, I suspect, were just drowned in the noise. Eric, we had a quick > discussion about this a while back but I don't think we reached a > co

kexec: device shutdown vs. remove

2016-07-23 Thread Benjamin Herrenschmidt
Hi ! This is somewhat of a recurring issue, some of my previous attempts on lkml, I suspect, were just drowned in the noise. Eric, we had a quick discussion about this a while back but I don't think we reached a conclusion. A bit of context: On OpenPOWER machines, we have a Linux based bootloader