Re: kernel/relay.c: a strange usage of delayed_work

2007-05-03 Thread Tom Zanussi
On Fri, 2007-05-04 at 01:38 +0400, Oleg Nesterov wrote: > relay_switch_subbuf() does schedule_delayed_work(&buf->wake_readers, 1), > wakeup_readers() only does wake_up_interruptible() and nothing more. > > Why can't we use a plain timer for this? > > In any case, this "wake_up ->read_wait after a

kernel/relay.c: a strange usage of delayed_work

2007-05-03 Thread Oleg Nesterov
relay_switch_subbuf() does schedule_delayed_work(&buf->wake_readers, 1), wakeup_readers() only does wake_up_interruptible() and nothing more. Why can't we use a plain timer for this? In any case, this "wake_up ->read_wait after a minimal possible delay" looks somewhat strange to me, could you exp