Re: irda rmmod lockdep trace.

2007-03-16 Thread Samuel Ortiz
On Tue, Mar 13, 2007 at 07:22:37PM -0700, David Miller wrote: > From: Samuel Ortiz <[EMAIL PROTECTED]> > Date: Wed, 14 Mar 2007 02:50:03 +0200 > > > On Mon, Mar 12, 2007 at 04:49:21PM -0700, David Miller wrote: > > > I would strongly caution against adding any run-time overhead just to > > > cure

Re: irda rmmod lockdep trace.

2007-03-13 Thread David Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Wed, 14 Mar 2007 02:50:03 +0200 > On Mon, Mar 12, 2007 at 04:49:21PM -0700, David Miller wrote: > > I would strongly caution against adding any run-time overhead just to > > cure a false lockdep warning. Even adding a new function argument > > is too m

Re: irda rmmod lockdep trace.

2007-03-13 Thread Samuel Ortiz
On Mon, Mar 12, 2007 at 04:49:21PM -0700, David Miller wrote: > I would strongly caution against adding any run-time overhead just to > cure a false lockdep warning. Even adding a new function argument > is too much IMHO. > > Make the cost show up for lockdep only, perhaps by putting each > hashb

Re: irda rmmod lockdep trace.

2007-03-13 Thread Samuel Ortiz
On 3/12/2007, "David Miller" <[EMAIL PROTECTED]> wrote: >From: Samuel Ortiz <[EMAIL PROTECTED]> >Date: Mon, 12 Mar 2007 02:38:43 +0200 > >> On Sat, Mar 10, 2007 at 07:43:26PM +0200, Samuel Ortiz wrote: >> > Hi Dave, >> > >> > On Thu, Mar 08, 2007 at 05:54:36PM -0500, Dave Jones wrote: >> > > modp

Re: irda rmmod lockdep trace.

2007-03-12 Thread David Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Mon, 12 Mar 2007 02:38:43 +0200 > On Sat, Mar 10, 2007 at 07:43:26PM +0200, Samuel Ortiz wrote: > > Hi Dave, > > > > On Thu, Mar 08, 2007 at 05:54:36PM -0500, Dave Jones wrote: > > > modprobe irda ; rmmod irda in 2.6.21rc3 gets me the spew below.. > >

Re: irda rmmod lockdep trace.

2007-03-11 Thread Samuel Ortiz
Hi Dave, On Sat, Mar 10, 2007 at 07:43:26PM +0200, Samuel Ortiz wrote: > Hi Dave, > > On Thu, Mar 08, 2007 at 05:54:36PM -0500, Dave Jones wrote: > > modprobe irda ; rmmod irda in 2.6.21rc3 gets me the spew below.. > Well it seems that we call __irias_delete_object() from hashbin_delete(). Then >

Re: irda rmmod lockdep trace.

2007-03-10 Thread Samuel Ortiz
Hi Dave, On Thu, Mar 08, 2007 at 05:54:36PM -0500, Dave Jones wrote: > modprobe irda ; rmmod irda in 2.6.21rc3 gets me the spew below.. Well it seems that we call __irias_delete_object() from hashbin_delete(). Then __irias_delete_object() calls itself hashbin_delete() again. We're trying to get th

irda rmmod lockdep trace.

2007-03-08 Thread Dave Jones
modprobe irda ; rmmod irda in 2.6.21rc3 gets me the spew below.. Dave NET: Registered protocol family 23 NET: Unregistered protocol family 23 = [ INFO: possible recursive locking detected ] 2.6.20-1.2966.fc7 #1 -