Re: [PATCH][V2][netdev-next] gre: remove duplicated assignment of iph

2017-08-23 Thread David Miller
From: Colin King Date: Wed, 23 Aug 2017 12:59:48 +0100 > From: Colin Ian King > > iph is being assigned the same value twice; remove the redundant > first assignment. (Thanks to Nikolay Aleksandrov for pointing out > that the first asssignment should be removed and not the sec

Re: [PATCH][netdev-next] gre: remove duplicated assignment of iph

2017-08-23 Thread David Miller
From: Colin King Date: Wed, 23 Aug 2017 12:13:05 +0100 > From: Colin Ian King > > iph is being assigned the same value twice; remove the redundant > second assignment. > > Fixes warning: > net/ipv4/ip_gre.c:265:2: warning: Value stored to 'iph' is never read >

Re: [PATCH][V2][netdev-next] gre: remove duplicated assignment of iph

2017-08-23 Thread Nikolay Aleksandrov
On 23/08/17 14:59, Colin King wrote: > From: Colin Ian King > > iph is being assigned the same value twice; remove the redundant > first assignment. (Thanks to Nikolay Aleksandrov for pointing out > that the first asssignment should be removed and not the second) > > Fixe

[PATCH][V2][netdev-next] gre: remove duplicated assignment of iph

2017-08-23 Thread Colin King
From: Colin Ian King iph is being assigned the same value twice; remove the redundant first assignment. (Thanks to Nikolay Aleksandrov for pointing out that the first asssignment should be removed and not the second) Fixes warning: net/ipv4/ip_gre.c:265:2: warning: Value stored to 'ip

Re: [PATCH][netdev-next] gre: remove duplicated assignment of iph

2017-08-23 Thread Nikolay Aleksandrov
On 23/08/17 14:13, Colin King wrote: > From: Colin Ian King > > iph is being assigned the same value twice; remove the redundant > second assignment. > > Fixes warning: > net/ipv4/ip_gre.c:265:2: warning: Value stored to 'iph' is never read > > Signed-off-

[PATCH][netdev-next] gre: remove duplicated assignment of iph

2017-08-23 Thread Colin King
From: Colin Ian King iph is being assigned the same value twice; remove the redundant second assignment. Fixes warning: net/ipv4/ip_gre.c:265:2: warning: Value stored to 'iph' is never read Signed-off-by: Colin Ian King --- net/ipv4/ip_gre.c | 1 - 1 file changed, 1 deletion(-) di

[PATCH 4.8 21/45] GSO: Reload iph after pskb_may_pull

2016-12-09 Thread Greg Kroah-Hartman
--- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -1237,7 +1237,7 @@ struct sk_buff *inet_gso_segment(struct fixedid = !!(skb_shinfo(skb)->gso_type & SKB_GSO_TCP_FIXEDID); /* fixed ID is invalid if DF bit is not set */ - if (fixedid &&

[PATCH 3.2 180/185] net: flow_dissector: fail on evil iph->ihl

2013-12-28 Thread Ben Hutchings
3.2.54-rc1 review patch. If anyone has any objections, please let me know. -- From: Jason Wang commit 6f092343855a71e03b8d209815d8c45bf3a27fcd upstream. We don't validate iph->ihl which may lead a dead loop if we meet a IPIP skb whose iph->ihl is zero. Fix this

[PATCH 3.8 006/152] net: flow_dissector: fail on evil iph->ihl

2013-12-06 Thread Kamal Mostafa
3.8.13.14 -stable review patch. If anyone has any objections, please let me know. -- From: Jason Wang [ Upstream commit 6f092343855a71e03b8d209815d8c45bf3a27fcd ] We don't validate iph->ihl which may lead a dead loop if we meet a IPIP skb whose iph->ihl is zero.

[PATCH 3.5 36/78] net: flow_dissector: fail on evil iph->ihl

2013-11-25 Thread Luis Henriques
3.5.7.26 -stable review patch. If anyone has any objections, please let me know. -- From: Jason Wang commit 6f092343855a71e03b8d209815d8c45bf3a27fcd upstream. We don't validate iph->ihl which may lead a dead loop if we meet a IPIP skb whose iph->ihl is zero.

[PATCH 3.11 03/25] net: flow_dissector: fail on evil iph->ihl

2013-11-18 Thread Greg Kroah-Hartman
3.11-stable review patch. If anyone has any objections, please let me know. -- From: Jason Wang [ Upstream commit 6f092343855a71e03b8d209815d8c45bf3a27fcd ] We don't validate iph->ihl which may lead a dead loop if we meet a IPIP skb whose iph->ihl is zero. Fix this

[PATCH 3.4 03/12] net: flow_dissector: fail on evil iph->ihl

2013-11-18 Thread Greg Kroah-Hartman
3.4-stable review patch. If anyone has any objections, please let me know. -- From: Jason Wang [ Upstream commit 6f092343855a71e03b8d209815d8c45bf3a27fcd ] We don't validate iph->ihl which may lead a dead loop if we meet a IPIP skb whose iph->ihl is zero. Fix this

[PATCH 3.10 07/24] net: flow_dissector: fail on evil iph->ihl

2013-11-18 Thread Greg Kroah-Hartman
3.10-stable review patch. If anyone has any objections, please let me know. -- From: Jason Wang [ Upstream commit 6f092343855a71e03b8d209815d8c45bf3a27fcd ] We don't validate iph->ihl which may lead a dead loop if we meet a IPIP skb whose iph->ihl is zero. Fix this

[PATCH 3.12 03/19] net: flow_dissector: fail on evil iph->ihl

2013-11-18 Thread Greg Kroah-Hartman
3.12-stable review patch. If anyone has any objections, please let me know. -- From: Jason Wang [ Upstream commit 6f092343855a71e03b8d209815d8c45bf3a27fcd ] We don't validate iph->ihl which may lead a dead loop if we meet a IPIP skb whose iph->ihl is zero. Fix this

Re: [PATCH net] net: flow_dissector: fail on evil iph->ihl

2013-11-03 Thread Daniel Borkmann
On 11/01/2013 08:01 AM, Jason Wang wrote: We don't validate iph->ihl which may lead a dead loop if we meet a IPIP skb whose iph->ihl is zero. Fix this by failing immediately when iph->ihl is evil (less than 5). This issue were introduced by commit ec5efe7946280d1e84603389a1030cc

Re: [PATCH net] net: flow_dissector: fail on evil iph->ihl

2013-11-02 Thread Michael S. Tsirkin
On Fri, Nov 01, 2013 at 03:01:10PM +0800, Jason Wang wrote: > We don't validate iph->ihl which may lead a dead loop if we meet a IPIP > skb whose iph->ihl is zero. Fix this by failing immediately when iph->ihl > is evil (less than 5). > > This is

Re: [PATCH net] net: flow_dissector: fail on evil iph->ihl

2013-11-01 Thread David Miller
From: Jason Wang Date: Fri, 1 Nov 2013 15:01:10 +0800 > We don't validate iph->ihl which may lead a dead loop if we meet a IPIP > skb whose iph->ihl is zero. Fix this by failing immediately when iph->ihl > is evil (less than 5). > > This is

Re: [PATCH net] net: flow_dissector: fail on evil iph->ihl

2013-11-01 Thread Ben Hutchings
On Fri, 2013-11-01 at 15:01 +0800, Jason Wang wrote: > We don't validate iph->ihl which may lead a dead loop if we meet a IPIP > skb whose iph->ihl is zero. Fix this by failing immediately when iph->ihl > is evil (less than 5). > > This is

Re: [PATCH net] net: flow_dissector: fail on evil iph->ihl

2013-11-01 Thread Eric Dumazet
On Fri, 2013-11-01 at 15:01 +0800, Jason Wang wrote: > We don't validate iph->ihl which may lead a dead loop if we meet a IPIP > skb whose iph->ihl is zero. Fix this by failing immediately when iph->ihl > is evil (less than 5). > > This is

[PATCH net] net: flow_dissector: fail on evil iph->ihl

2013-11-01 Thread Jason Wang
We don't validate iph->ihl which may lead a dead loop if we meet a IPIP skb whose iph->ihl is zero. Fix this by failing immediately when iph->ihl is evil (less than 5). This issue were introduced by commit ec5efe7946280d1e84603389a1030ccec0a767ae (rps: support IPIP encapsulati

[patch 12/73] IPV4 raw: Strengthen check on validity of iph->ihl

2008-02-06 Thread Greg KH
2.6.23-stable review patch. If anyone has any objections, please let us know. -- From: Herbert Xu <[EMAIL PROTECTED]> [IPV4] raw: Strengthen check on validity of iph->ihl [ Upstream commit: f844c74fe07321953e2dd227fe35280075f18f60 ] We currently check that iph->ih

Re: [PATCH] Remove unneeded pointer iph from ipcomp6_input() in net/ipv6/ipcomp6.c

2007-09-05 Thread David Miller
From: Micah Gruber <[EMAIL PROTECTED]> Date: Wed, 05 Sep 2007 13:44:40 +0800 > This trivial patch removes the unneeded pointer iph, which is never used. > > Signed-off-by: Micah Gruber < [EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line &quo

[PATCH] Remove unneeded pointer iph from ipcomp6_input() in net/ipv6/ipcomp6.c

2007-09-04 Thread Micah Gruber
This trivial patch removes the unneeded pointer iph, which is never used. Signed-off-by: Micah Gruber < [EMAIL PROTECTED]> --- --- a/net/ipv6/ipcomp6.c2007-09-04 23:18:43.0 +0800 +++ b/net/ipv6/ipcomp6.c2007-09-05 00:48:05.0 +0800 @@ -65,7 +65,6 @@ stat

iph

2001-01-02 Thread Sourav Sen
Hi, I want to know what the field, ihl in the struct iphdr is there for, I mean its function and the values it takes in different condition. Specifically, what is the condition when ihl>5. (See ip_input.c , line 497, depending on if ihl>5, some code is getting executed.) I am talking of