Re: ipc/msg: zalloc struct msg_queue when creating a new msq

2018-07-04 Thread Dmitry Vyukov
On Wed, Jul 4, 2018 at 4:08 PM, Manfred Spraul wrote: > Hello Dmitry, > On 07/04/2018 12:03 PM, Dmitry Vyukov wrote: >> >> On Wed, Jul 4, 2018 at 11:18 AM, Manfred Spraul >> wrote: >>> >>> >>> There are 2 relevant values: kern_ipc_perm.id and kern_ipc_perm.seq. >>> >>> For kern_ipc_perm.id, it is

Re: ipc/msg: zalloc struct msg_queue when creating a new msq

2018-07-04 Thread Manfred Spraul
Hello Dmitry, On 07/04/2018 12:03 PM, Dmitry Vyukov wrote: On Wed, Jul 4, 2018 at 11:18 AM, Manfred Spraul wrote: There are 2 relevant values: kern_ipc_perm.id and kern_ipc_perm.seq. For kern_ipc_perm.id, it is possible to move the access to the codepath that hold the lock. For kern_ipc_perm

Re: ipc/msg: zalloc struct msg_queue when creating a new msq

2018-07-04 Thread Dmitry Vyukov
On Wed, Jul 4, 2018 at 11:18 AM, Manfred Spraul wrote: > Hello together, > > On 06/25/2018 11:21 AM, Dmitry Vyukov wrote: >> >> On Sun, Jun 24, 2018 at 4:56 AM, Davidlohr Bueso >> wrote: >>> >>> The following splat was reported around the msg_queue structure >>> which can have uninitialized field

Re: ipc/msg: zalloc struct msg_queue when creating a new msq

2018-07-04 Thread Manfred Spraul
Hello together, On 06/25/2018 11:21 AM, Dmitry Vyukov wrote: On Sun, Jun 24, 2018 at 4:56 AM, Davidlohr Bueso wrote: The following splat was reported around the msg_queue structure which can have uninitialized fields left over after newque(). Future syscalls which make use of the msq id (now v

Re: ipc/msg: zalloc struct msg_queue when creating a new msq

2018-06-25 Thread Dmitry Vyukov
On Sun, Jun 24, 2018 at 4:56 AM, Davidlohr Bueso wrote: > The following splat was reported around the msg_queue structure > which can have uninitialized fields left over after newque(). > Future syscalls which make use of the msq id (now valid) can thus > make KMSAN complain because not all fields

ipc/msg: zalloc struct msg_queue when creating a new msq

2018-06-23 Thread Davidlohr Bueso
The following splat was reported around the msg_queue structure which can have uninitialized fields left over after newque(). Future syscalls which make use of the msq id (now valid) can thus make KMSAN complain because not all fields are explicitly initialized and we have the padding as well. Thi