Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

2020-08-04 Thread daniel
On Thu, Jul 30, 2020 at 08:10:27AM +0200, Christoph Hellwig wrote: > If a TAINT_PROPRIETARY_MODULE exports symbol, inherit the taint flag > for all modules importing these symbols, and don't allow loading > symbols from TAINT_PROPRIETARY_MODULE modules if the module previously > imported gplonly sy

Re: inherit TAINT_PROPRIETARY_MODULE v2

2020-08-01 Thread Josh Triplett
On July 31, 2020 11:53:08 PM PDT, Christoph Hellwig wrote: >[note: private reply now to start a flame fest with the usual suspects] [You still CCed LKML.] >On Fri, Jul 31, 2020 at 01:11:46PM -0700, j...@joshtriplett.org wrote: >> Christoph Hellwig wrote: >> > we've had a bug in our resolution of

Re: inherit TAINT_PROPRIETARY_MODULE v2

2020-07-31 Thread Christoph Hellwig
[note: private reply now to start a flame fest with the usual suspects] On Fri, Jul 31, 2020 at 01:11:46PM -0700, j...@joshtriplett.org wrote: > Christoph Hellwig wrote: > > we've had a bug in our resolution of _GPL modules since day one, that > > is a module can claim to be GPL licensed and use _

Re: inherit TAINT_PROPRIETARY_MODULE v2

2020-07-31 Thread josh
Christoph Hellwig wrote: > we've had a bug in our resolution of _GPL modules since day one, that > is a module can claim to be GPL licensed and use _GPL exports, while > it also depends on symbols from non-GPL modules. This is used as a > circumvention of the _GPL exports by using a small shim mod

Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

2020-07-31 Thread Jessica Yu
+++ Christoph Hellwig [31/07/20 11:00 +0200]: On Fri, Jul 31, 2020 at 10:51:30AM +0200, Jessica Yu wrote: + if (mod->using_gplonly_symbols) { + pr_info("%s: module using GPL-only symbols uses symbols from proprietary module %s.\n", + mod->name, owner->n

Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

2020-07-31 Thread Christoph Hellwig
On Fri, Jul 31, 2020 at 10:51:30AM +0200, Jessica Yu wrote: >> +if (mod->using_gplonly_symbols) { >> +pr_info("%s: module using GPL-only symbols uses symbols from >> proprietary module %s.\n", >> +mod->name, owner->name); > > pr_err() maybe? > >> +re

Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

2020-07-31 Thread Jessica Yu
From 25e928b6b691911717d30b3449e56fca3e13dba9 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Tue, 28 Jul 2020 23:33:33 +0200 Subject: modules: inherit TAINT_PROPRIETARY_MODULE If a TAINT_PROPRIETARY_MODULE exports symbol, inherit the taint flag for all modules importing these symbols,

Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

2020-07-30 Thread Christoph Hellwig
ion: --- >From 25e928b6b691911717d30b3449e56fca3e13dba9 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Tue, 28 Jul 2020 23:33:33 +0200 Subject: modules: inherit TAINT_PROPRIETARY_MODULE If a TAINT_PROPRIETARY_MODULE exports symbol, inherit the taint flag for all modules importing these

Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

2020-07-30 Thread Jessica Yu
+++ Christoph Hellwig [30/07/20 08:10 +0200]: If a TAINT_PROPRIETARY_MODULE exports symbol, inherit the taint flag for all modules importing these symbols, and don't allow loading symbols from TAINT_PROPRIETARY_MODULE modules if the module previously imported gplonly symbols. Add a anti-circumve

[PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

2020-07-29 Thread Christoph Hellwig
If a TAINT_PROPRIETARY_MODULE exports symbol, inherit the taint flag for all modules importing these symbols, and don't allow loading symbols from TAINT_PROPRIETARY_MODULE modules if the module previously imported gplonly symbols. Add a anti-circumvention devices so people don't accidentally get t

inherit TAINT_PROPRIETARY_MODULE v2

2020-07-29 Thread Christoph Hellwig
Hi Jessica, we've had a bug in our resolution of _GPL modules since day one, that is a module can claim to be GPL licensed and use _GPL exports, while it also depends on symbols from non-GPL modules. This is used as a circumvention of the _GPL exports by using a small shim module using the _GPL e

Re: [PATCH 7/7] modules: inherit TAINT_PROPRIETARY_MODULE

2020-07-28 Thread Greg Kroah-Hartman
On Wed, Jul 29, 2020 at 08:27:11AM +0200, Christoph Hellwig wrote: > If a TAINT_PROPRIETARY_MODULE exports symbol, inherit the tain flag s/tain/taint/ > for all modules importing these symbols, and don't allow loading > symbols from TAINT_PROPRIETARY_MODULE modules if the module previously > impo

[PATCH 7/7] modules: inherit TAINT_PROPRIETARY_MODULE

2020-07-28 Thread Christoph Hellwig
If a TAINT_PROPRIETARY_MODULE exports symbol, inherit the tain flag for all modules importing these symbols, and don't allow loading symbols from TAINT_PROPRIETARY_MODULE modules if the module previously imported gplonly symbols. Add a anti-circumvention devices so people don't accidentally get th

inherit TAINT_PROPRIETARY_MODULE

2020-07-28 Thread Christoph Hellwig
Hi Jessica, we've had a bug in our resolution of _GPL modules since day one, that is a module can claim to be GPL licensed and use _GPL exports, while it also depends on symbols from non-GPL modules. This is used as a circumvention of the _GPL exports by using a small shim module using the _GPL e