[PATCH 5.10 014/152] drm/i915/backlight: fix CPU mode backlight takeover on LPT

2021-01-18 Thread Greg Kroah-Hartman
done in the interface between hardware registers and panel->backlight.level. The CPU mode takeover code added in commit 5b1ec9ac7ab5 ("drm/i915/backlight: Fix backlight takeover on LPT, v3.") reads the hardware register and converts to panel->backlight.level correctly, however the va

[PATCH 5.4 19/76] drm/i915/backlight: fix CPU mode backlight takeover on LPT

2021-01-18 Thread Greg Kroah-Hartman
done in the interface between hardware registers and panel->backlight.level. The CPU mode takeover code added in commit 5b1ec9ac7ab5 ("drm/i915/backlight: Fix backlight takeover on LPT, v3.") reads the hardware register and converts to panel->backlight.level correctly, however t

[v3 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-26 Thread Shobhit Kumar
Use the CRC PWM device in intel_panel.c and add new MIPI backlight specififc callbacks v2: Modify to use pwm_config callback v3: Addressed Jani's comments - Renamed all function as pwm_* instead of vlv_* - Call intel_panel_actually_set_backlight in enable function - Return -ENODEV in c

Re: [Intel-gfx] [v2 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-26 Thread Jani Nikula
On Thu, 25 Jun 2015, Shobhit Kumar wrote: > On Thu, Jun 25, 2015 at 2:18 PM, Ville Syrjälä > wrote: >> On Mon, Jun 22, 2015 at 04:24:25PM +0530, Shobhit Kumar wrote: >>> Use the CRC PWM device in intel_panel.c and add new MIPI backlight >>> specififc callbacks >>> >>> v2: Modify to use pwm_config

Re: [Intel-gfx] [v2 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-25 Thread Shobhit Kumar
On Thu, Jun 25, 2015 at 6:17 PM, Ville Syrjälä wrote: > On Thu, Jun 25, 2015 at 05:38:50PM +0530, Shobhit Kumar wrote: >> On Thu, Jun 25, 2015 at 2:18 PM, Ville Syrjälä >> wrote: >> > On Mon, Jun 22, 2015 at 04:24:25PM +0530, Shobhit Kumar wrote: >> >> Use the CRC PWM device in intel_panel.c and

Re: [Intel-gfx] [v2 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-25 Thread Ville Syrjälä
On Thu, Jun 25, 2015 at 05:38:50PM +0530, Shobhit Kumar wrote: > On Thu, Jun 25, 2015 at 2:18 PM, Ville Syrjälä > wrote: > > On Mon, Jun 22, 2015 at 04:24:25PM +0530, Shobhit Kumar wrote: > >> Use the CRC PWM device in intel_panel.c and add new MIPI backlight > >> specififc callbacks > >> > >> v2:

Re: [Intel-gfx] [v2 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-25 Thread Shobhit Kumar
On Thu, Jun 25, 2015 at 2:18 PM, Ville Syrjälä wrote: > On Mon, Jun 22, 2015 at 04:24:25PM +0530, Shobhit Kumar wrote: >> Use the CRC PWM device in intel_panel.c and add new MIPI backlight >> specififc callbacks >> >> v2: Modify to use pwm_config callback >> v3: Addressed Jani's comments >> -

Re: [Intel-gfx] [v2 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-25 Thread Ville Syrjälä
On Mon, Jun 22, 2015 at 04:24:25PM +0530, Shobhit Kumar wrote: > Use the CRC PWM device in intel_panel.c and add new MIPI backlight > specififc callbacks > > v2: Modify to use pwm_config callback > v3: Addressed Jani's comments > - Renamed all function as pwm_* instead of vlv_* > - Call in

[v2 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-06-22 Thread Shobhit Kumar
Use the CRC PWM device in intel_panel.c and add new MIPI backlight specififc callbacks v2: Modify to use pwm_config callback v3: Addressed Jani's comments - Renamed all function as pwm_* instead of vlv_* - Call intel_panel_actually_set_backlight in enable function - Return -ENODEV in c

Re: [PATCH 8/8] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-05-06 Thread Jani Nikula
On Wed, 29 Apr 2015, Shobhit Kumar wrote: > Use the CRC PWM device in intel_panel.c and add new MIPI backlight > specififc callbacks > > v2: Modify to use pwm_config callback > > CC: Samuel Ortiz > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Thierry Reding > Signed-off-by: Shobhit Kumar >

[PATCH 8/8] drm/i915: Backlight control using CRC PMIC based PWM driver

2015-04-29 Thread Shobhit Kumar
Use the CRC PWM device in intel_panel.c and add new MIPI backlight specififc callbacks v2: Modify to use pwm_config callback CC: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/intel_drv.h | 5 +++ drivers/gpu/

Re: [BUG] drm/i915: backlight off after resume

2015-01-09 Thread Jani Nikula
On Fri, 09 Jan 2015, Jeremiah Mahler wrote: > Jani, all, > > On a Lenovo X1 Carbon if the display is off when suspend is entered > it will be off when it is resumed. A key must be pressed to restore > normal brightness. Please file a bug on [1] and attach dmesg with drm.debug=14 set, from boot t

[BUG] drm/i915: backlight off after resume

2015-01-08 Thread Jeremiah Mahler
Jani, all, On a Lenovo X1 Carbon if the display is off when suspend is entered it will be off when it is resumed. A key must be pressed to restore normal brightness. xset dpms force off sleep 1 sudo systemctl suspend (resume) (screen off, press any key) The behavior I am accustomed to

Re: i915 backlight

2013-08-05 Thread Daniel Vetter
On Fri, Aug 02, 2013 at 09:16:03AM +0800, Aaron Lu wrote: > Hi Jani & Daniel, > > It turned out there is an integer overflow problem, and the below patch > fixed this problem on Acer Aspire 4732Z and thinkpad R61i. > > From: Aaron Lu > Subject: [PATCH] drm/i915: avoid brightness overflow when do

Re: i915 backlight

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 6:35 PM, Rafael J. Wysocki wrote: > On Friday, August 02, 2013 01:58:55 PM Felipe Contreras wrote: >> On Fri, Aug 2, 2013 at 9:03 AM, Rafael J. Wysocki wrote: >> > On Friday, August 02, 2013 01:48:37 AM Felipe Contreras wrote: >> >> I think it's pretty obvious that for the

Re: i915 backlight

2013-08-02 Thread Rafael J. Wysocki
On Friday, August 02, 2013 01:58:55 PM Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 9:03 AM, Rafael J. Wysocki wrote: > > On Friday, August 02, 2013 01:48:37 AM Felipe Contreras wrote: > >> On Fri, Aug 2, 2013 at 1:25 AM, Josep Lladonosa wrote: > >> > Hello, > >> > > >> > I am using a Lenovo

Re: i915 backlight

2013-08-02 Thread Josep Lladonosa
On 2 August 2013 23:25, Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 3:11 PM, Josep Lladonosa wrote: >> "Before" means with previous kernels that worked with >> >> GRUB_CMDLINE_LINUX="acpi_osi=Linux acpi_backlight=vendor" > > That's probably a different issue. You would need to bisect the pro

Re: i915 backlight

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 3:11 PM, Josep Lladonosa wrote: > "Before" means with previous kernels that worked with > > GRUB_CMDLINE_LINUX="acpi_osi=Linux acpi_backlight=vendor" That's probably a different issue. You would need to bisect the problem. > I have not checked this issue with acpi_osi="!Wi

Re: i915 backlight

2013-08-02 Thread Borislav Petkov
On Fri, Aug 02, 2013 at 10:11:27PM +0200, Josep Lladonosa wrote: > "Before" means with previous kernels that worked with > > GRUB_CMDLINE_LINUX="acpi_osi=Linux acpi_backlight=vendor" > > I have not checked this issue with acpi_osi="!Windows 2012". Hey Josep, would you please not top-post when y

Re: i915 backlight

2013-08-02 Thread Josep Lladonosa
"Before" means with previous kernels that worked with GRUB_CMDLINE_LINUX="acpi_osi=Linux acpi_backlight=vendor" I have not checked this issue with acpi_osi="!Windows 2012". Josep On 2 August 2013 22:08, Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 3:03 PM, Josep Lladonosa wrote: >> With t

Re: i915 backlight

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 3:03 PM, Josep Lladonosa wrote: > With this setup, something has happened: in xorg, when screen goes to > screensaver and after, enters into Standby mode, when I press a key, > it keeps black and, to recover screen, I have to adjust brightness > manually (by increasing), as

Re: i915 backlight

2013-08-02 Thread Josep Lladonosa
Hi, With this setup, something has happened: in xorg, when screen goes to screensaver and after, enters into Standby mode, when I press a key, it keeps black and, to recover screen, I have to adjust brightness manually (by increasing), as if it didn't remember previous value to standby mode. This

Re: i915 backlight

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 9:03 AM, Rafael J. Wysocki wrote: > On Friday, August 02, 2013 01:48:37 AM Felipe Contreras wrote: >> On Fri, Aug 2, 2013 at 1:25 AM, Josep Lladonosa wrote: >> > Hello, >> > >> > I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to >> > change to this paramet

Re: i915 backlight

2013-08-02 Thread Rafael J. Wysocki
On Friday, August 02, 2013 01:48:37 AM Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 1:25 AM, Josep Lladonosa wrote: > > Hello, > > > > I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to > > change to this parameter to the kernel boot: > > > > > > GRUB_CMDLINE_LINUX="acpi_osi=\

Re: i915 backlight

2013-08-02 Thread Borislav Petkov
On Fri, Aug 02, 2013 at 09:16:03AM +0800, Aaron Lu wrote: > Since the sysfs interface works on your system, I think your problem > should be different. Can you please file a bug for this? I can provide > you with a debug patch and then see what happened. Please attach > acpidump when filing the bug

Re: i915 backlight

2013-08-02 Thread Borislav Petkov
On Fri, Aug 02, 2013 at 02:00:42PM +0800, Aaron Lu wrote: > Assume you have specified to use intel_backlight in xorg.conf Right, I have: Section "Device" Option "Backlight" "intel_backlight" Identifier "Card0" Driver "intel" BusID "PCI:0:2:0" EndSe

Re: i915 backlight

2013-08-02 Thread Josep Lladonosa
Hello, Yes, it works! I get now 11 levels from all black to the brightest. acpi_listen shows messages Josep On 2 August 2013 08:36, Aaron Lu wrote: > On 08/02/2013 02:25 PM, Josep Lladonosa wrote: >> Hello, >> >> I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to >> change to

Re: i915 backlight

2013-08-01 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 1:25 AM, Josep Lladonosa wrote: > Hello, > > I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to > change to this parameter to the kernel boot: > > > GRUB_CMDLINE_LINUX="acpi_osi=\"!Windows 2012\"" I think it's pretty obvious that for the time being we need

Re: i915 backlight

2013-08-01 Thread Aaron Lu
On 08/02/2013 02:25 PM, Josep Lladonosa wrote: > Hello, > > I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to > change to this parameter to the kernel boot: > > > GRUB_CMDLINE_LINUX="acpi_osi=\"!Windows 2012\"" What if you remove the above from kernel command line, and add vid

Re: i915 backlight

2013-08-01 Thread Josep Lladonosa
Hello, I am using a Lenovo Edge E530 and, with kernel 3.11.0-rc3, I had to change to this parameter to the kernel boot: GRUB_CMDLINE_LINUX="acpi_osi=\"!Windows 2012\"" instead of previous GRUB_CMDLINE_LINUX="acpi_osi=Linux acpi_backlight=vendor" to be able to change brightness. In some kerne

Re: i915 backlight

2013-08-01 Thread Aaron Lu
On 08/01/2013 04:07 PM, Borislav Petkov wrote: > On Wed, Jul 31, 2013 at 11:16:52PM +0200, Rafael J. Wysocki wrote: >> Does reverting efaa14c help? > > Nope. > > But see my other reply to Aaron. Assume you have specified to use intel_backlight in xorg.conf, does booting with video.brightness_swi

Re: i915 backlight

2013-08-01 Thread Aaron Lu
On 08/01/2013 05:07 PM, Aaron Lu wrote: > On 08/01/2013 04:12 PM, Borislav Petkov wrote: >> On Thu, Aug 01, 2013 at 09:13:35AM +0800, Aaron Lu wrote: >>> Can you please run acpi_listen and then press the Fn-Fx key, see if the >>> events are correctly sent out? >> >> Like this? >> >> # acpi_listen >

Re: i915 backlight

2013-08-01 Thread Aaron Lu
On 08/01/2013 04:12 PM, Borislav Petkov wrote: > On Thu, Aug 01, 2013 at 09:13:35AM +0800, Aaron Lu wrote: >> Can you please run acpi_listen and then press the Fn-Fx key, see if the >> events are correctly sent out? > > Like this? > > # acpi_listen > video/brightnessdown BRTDN 0087 >

Re: i915 backlight

2013-08-01 Thread Borislav Petkov
On Thu, Aug 01, 2013 at 09:13:35AM +0800, Aaron Lu wrote: > Can you please run acpi_listen and then press the Fn-Fx key, see if the > events are correctly sent out? Like this? # acpi_listen video/brightnessdown BRTDN 0087 video/brightnessup BRTUP 0086 video/brightnessdow

Re: i915 backlight

2013-08-01 Thread Borislav Petkov
On Wed, Jul 31, 2013 at 11:16:52PM +0200, Rafael J. Wysocki wrote: > Does reverting efaa14c help? Nope. But see my other reply to Aaron. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: i915 backlight

2013-07-31 Thread Aaron Lu
On 08/01/2013 12:36 AM, Borislav Petkov wrote: > On Wed, Jul 31, 2013 at 06:22:52PM +0200, Borislav Petkov wrote: >> Dudes, >> >> has anyone already reported this (happens on Linus of today + >> tip/master): > > Oh, one more thing: I can't control the backlight anymore on this x230 > with the Fn-F

Re: i915 backlight

2013-07-31 Thread Rafael J. Wysocki
On Wednesday, July 31, 2013 06:36:23 PM Borislav Petkov wrote: > On Wed, Jul 31, 2013 at 06:22:52PM +0200, Borislav Petkov wrote: > > Dudes, > > > > has anyone already reported this (happens on Linus of today + > > tip/master): > > Oh, one more thing: I can't control the backlight anymore on this

Re: i915 backlight

2013-07-31 Thread Borislav Petkov
On Wed, Jul 31, 2013 at 06:22:52PM +0200, Borislav Petkov wrote: > Dudes, > > has anyone already reported this (happens on Linus of today + > tip/master): Oh, one more thing: I can't control the backlight anymore on this x230 with the Fn-Fx keys and this is most probably related to that recent ba