Re: i2c-core: One function call less in acpi_i2c_space_handler() after error detection

2015-12-26 Thread SF Markus Elfring
>> I would appreciate if an unnecessary function call can be avoided here >> so that the affected exception handling can become also a bit more efficient. > > Simpler code is easier to maintain. There are different opinions available around the desired simplicity. > See your patch, you didn't g

Re: i2c-core: One function call less in acpi_i2c_space_handler() after error detection

2015-12-26 Thread Wolfram Sang
On Sat, Dec 26, 2015 at 09:52:11AM +0100, SF Markus Elfring wrote: > >> The kfree() function was called in one case by the > >> acpi_i2c_space_handler() function during error handling > >> even if the passed variable "client" contained a null pointer. > > > > This is OK. kfree() is known to be NUL

Re: i2c-core: One function call less in acpi_i2c_space_handler() after error detection

2015-12-26 Thread SF Markus Elfring
>> The kfree() function was called in one case by the >> acpi_i2c_space_handler() function during error handling >> even if the passed variable "client" contained a null pointer. > > This is OK. kfree() is known to be NULL-tolerant and we rely on it in > various places to keep the code simpler. I

Re: [PATCH v2] i2c-core: One function call less in acpi_i2c_space_handler() after error detection

2015-12-25 Thread Wolfram Sang
> The kfree() function was called in one case by the > acpi_i2c_space_handler() function during error handling > even if the passed variable "client" contained a null pointer. This is OK. kfree() is known to be NULL-tolerant and we rely on it in various places to keep the code simpler. signatur

[PATCH v2] i2c-core: One function call less in acpi_i2c_space_handler() after error detection

2015-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 26 Dec 2015 08:00:52 +0100 The kfree() function was called in one case by the acpi_i2c_space_handler() function during error handling even if the passed variable "client" contained a null pointer. Implementation details could be improved by the adjustment of jump

Re: [PATCH] i2c-core: One function call less in acpi_i2c_space_handler() after error detection

2015-12-25 Thread kbuild test robot
-call-less-in-acpi_i2c_space_handler-after-error-detection/20151226-143820 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux i2c/for-next config: x86_64-randconfig-x010-12251849 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH

[PATCH] i2c-core: One function call less in acpi_i2c_space_handler() after error detection

2015-12-25 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 26 Dec 2015 07:30:35 +0100 The kfree() function was called in one case by the acpi_i2c_space_handler() function during error handling even if the passed variable "client" contained a null pointer. Implementation details could be improved by the adjustment of jump