Re: [v10] i2c: imx: support slave mode for imx I2C driver

2020-12-12 Thread Oleksij Rempel
; Sent: 2020年12月10日 1:18 > > To: Wolfram Sang ; Kevin Herbert > > ; Biwen Li (OSS) ; Leo Li > > ; li...@rempel-privat.de; ker...@pengutronix.de; > > shawn...@kernel.org; s.ha...@pengutronix.de; feste...@gmail.com; Aisheng > > Dong ; Clark Wang ; > > o.rem...@pengutro

Re: [EXT] Re: [v10] i2c: imx: support slave mode for imx I2C driver

2020-12-11 Thread Kevin Herbert
el-privat.de; ker...@pengutronix.de; > shawn...@kernel.org; s.ha...@pengutronix.de; feste...@gmail.com; Aisheng Dong > ; Clark Wang ; > o.rem...@pengutronix.de; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org; Jiafei Pan ; Xiaobo Xie > ; linux-arm-ker...@lists.infradead.org; Biwen L

Re: [v10] i2c: imx: support slave mode for imx I2C driver

2020-12-09 Thread Wolfram Sang
On Wed, Dec 09, 2020 at 09:03:50AM -0800, Kevin Herbert wrote: > What is the protocol for the I2C_SLAVE_STOP event? I am working on my own > backend, and I've only tried it with this i.mx driver, and I do not receive > I2C_SLAVE_STOP at the end of every I2C transaction. It was my expectation > I'd

Re: [v10] i2c: imx: support slave mode for imx I2C driver

2020-12-02 Thread Wolfram Sang
On Wed, Nov 11, 2020 at 07:32:55PM +0800, Biwen Li wrote: > From: Biwen Li > > The patch supports slave mode for imx I2C driver > > Signed-off-by: Biwen Li Applied to for-next, thanks! signature.asc Description: PGP signature

RE: [v10] i2c: imx: support slave mode for imx I2C driver

2020-11-29 Thread Biwen Li (OSS)
> > > > The patch supports slave mode for imx I2C driver > > > > Signed-off-by: Biwen Li > > Thank you for your work! > > Acked-by: Oleksij Rempel > > @Wolfram, Christian Eggers I2SR_IAL patches should go before this one. Hi Wolfram, Any progress? Regards, Biwen Li > > > --- > > Change in

Re: [v10] i2c: imx: support slave mode for imx I2C driver

2020-11-13 Thread Oleksij Rempel
On Wed, Nov 11, 2020 at 07:32:55PM +0800, Biwen Li wrote: > From: Biwen Li > > The patch supports slave mode for imx I2C driver > > Signed-off-by: Biwen Li Thank you for your work! Acked-by: Oleksij Rempel @Wolfram, Christian Eggers I2SR_IAL patches should go before this one. > --- > Chang

[v10] i2c: imx: support slave mode for imx I2C driver

2020-11-11 Thread Biwen Li
From: Biwen Li The patch supports slave mode for imx I2C driver Signed-off-by: Biwen Li --- Change in v10: - totally remove CONFIG_I2C_SLAVE - replace api with i2c_imx_clart_irq() - remove robust code - place pm_runtime_get in i2c_imx_slave_init() to i2

RE: [v9 1/2] i2c: imx: support slave mode for imx I2C driver

2020-11-11 Thread Biwen Li (OSS)
> Hi, > > On Mon, Nov 02, 2020 at 04:21:01PM +0800, Biwen Li wrote: > > From: Biwen Li > > > > The patch supports slave mode for imx I2C driver > > > > Signed-off-by: Biwen Li > > --- > > Change in v9: > > - remove #ifdef after select I2C_SLAVE by default > > > > Change in v8: > > - fi

Re: [v9 1/2] i2c: imx: support slave mode for imx I2C driver

2020-11-10 Thread Oleksij Rempel
Hi, On Mon, Nov 02, 2020 at 04:21:01PM +0800, Biwen Li wrote: > From: Biwen Li > > The patch supports slave mode for imx I2C driver > > Signed-off-by: Biwen Li > --- > Change in v9: > - remove #ifdef after select I2C_SLAVE by default > > Change in v8: > - fix build issue > > Chan

RE: [v9 1/2] i2c: imx: support slave mode for imx I2C driver

2020-11-09 Thread Biwen Li
Hi Oleksij, Wolfram, Any comments? Regards, Biwen Li > From: Biwen Li > > The patch supports slave mode for imx I2C driver > > Signed-off-by: Biwen Li > --- > Change in v9: > - remove #ifdef after select I2C_SLAVE by default > > Change in v8: > - fix build issue > > Change in v

[v9 1/2] i2c: imx: support slave mode for imx I2C driver

2020-11-02 Thread Biwen Li
From: Biwen Li The patch supports slave mode for imx I2C driver Signed-off-by: Biwen Li --- Change in v9: - remove #ifdef after select I2C_SLAVE by default Change in v8: - fix build issue Change in v7: - support auto switch mode between master and slave - enabl

RE: [v8] i2c: imx: support slave mode for imx I2C driver

2020-10-30 Thread Biwen Li (OSS)
> > > +/* > > > + * Enable bus idle interrupts > > > + * Note: IBIC register will be cleared after disabled i2c module. > > > + */ > > > +static void i2c_imx_enable_bus_idle(struct imx_i2c_struct *i2c_imx) { > > > + unsigned int temp; > > > + > > > + temp = imx_i2c_read_reg(i2c_imx, IMX_I2C_IBIC);

RE: [v8] i2c: imx: support slave mode for imx I2C driver

2020-10-30 Thread Biwen Li (OSS)
> > +/* > > + * Enable bus idle interrupts > > + * Note: IBIC register will be cleared after disabled i2c module. > > + */ > > +static void i2c_imx_enable_bus_idle(struct imx_i2c_struct *i2c_imx) { > > + unsigned int temp; > > + > > + temp = imx_i2c_read_reg(i2c_imx, IMX_I2C_IBIC); > > + te

Re: [v8] i2c: imx: support slave mode for imx I2C driver

2020-10-29 Thread Oleksij Rempel
Hi On Mon, Oct 26, 2020 at 06:05:14PM +0800, Biwen Li wrote: > From: Biwen Li > > The patch supports slave mode for imx I2C driver > > Signed-off-by: Biwen Li > --- > Change in v8: > - fix build issue > > Change in v7: > - support auto switch mode between master and slave >

[v8] i2c: imx: support slave mode for imx I2C driver

2020-10-26 Thread Biwen Li
From: Biwen Li The patch supports slave mode for imx I2C driver Signed-off-by: Biwen Li --- Change in v8: - fix build issue Change in v7: - support auto switch mode between master and slave - enable interrupt when idle in slave mode - remove #ifdef Change in v6

[v7] i2c: imx: support slave mode for imx I2C driver

2020-10-16 Thread Biwen Li
From: Biwen Li The patch supports slave mode for imx I2C driver Signed-off-by: Biwen Li --- Change in v7: - support auto switch mode between master and slave - enable interrupt when idle in slave mode - remove #ifdef Change in v6: - delete robust logs and commen

Re: [RESEND v2] i2c: imx: support slave mode for imx I2C driver

2019-10-14 Thread Oleksij Rempel
Hi, I'm trying to test you patch on i.MX6S RIoTBoard. So far I fail to get it working with following setup: 1. register i2c-gpio 2. connect i2c-gpio SCL to i2c-imx SCL pin and i2c-gpio SDA to i2c-imx SDA pin 3. run this command to register i2c slave eeprom on i2c-imx: echo slave-24c02 0x1064 >

[RESEND v2] i2c: imx: support slave mode for imx I2C driver

2019-10-09 Thread Biwen Li
The patch supports slave mode for imx I2C driver Signed-off-by: Biwen Li --- Change in v2: - remove MACRO CONFIG_I2C_SLAVE drivers/i2c/busses/i2c-imx.c | 180 --- 1 file changed, 166 insertions(+), 14 deletions(-) diff --git a/drivers/i2c/busses/i2c-imx.

[v2] i2c: imx: support slave mode for imx I2C driver

2019-10-09 Thread Biwen Li
The patch supports slave mode for imx I2C driver Signed-off-by: Biwen Li --- Change in v2: - remove MACRO CONFIG_I2C_SLAVE drivers/i2c/busses/i2c-imx.c | 180 --- 1 file changed, 166 insertions(+), 14 deletions(-) diff --git a/drivers/i2c/busses/i2c-imx.

RE: [EXT] Re: i2c: imx: support slave mode for imx I2C driver

2019-08-12 Thread Biwen Li
> Subject: Re: [EXT] Re: i2c: imx: support slave mode for imx I2C driver > > Caution: EXT Email > > On Fri, Aug 09, 2019 at 04:04:45AM +, Biwen Li wrote: > > > > > > Hi, > > > > > > On Thu, Aug 08, 2019 at 11:53:43AM +0800, Biwen Li wrote

Re: [EXT] Re: i2c: imx: support slave mode for imx I2C driver

2019-08-11 Thread Sascha Hauer
On Fri, Aug 09, 2019 at 04:04:45AM +, Biwen Li wrote: > > > > Hi, > > > > On Thu, Aug 08, 2019 at 11:53:43AM +0800, Biwen Li wrote: > > > The patch supports slave mode for imx I2C driver > > > > > > Signed-off-by: Biwen Li > > > --- > > > drivers/i2c/busses/i2c-imx.c | 199 > > > +++

RE: [EXT] Re: i2c: imx: support slave mode for imx I2C driver

2019-08-11 Thread Biwen Li
> On Fri, Aug 09, 2019 at 03:18:01AM +, Biwen Li wrote: > > > > The patch supports slave mode for imx I2C driver > > > > > > > > Signed-off-by: Biwen Li > > > > > > Wow, this is much simpler than the other approach flying around: > > > > > > http://patchwork.ozlabs.org/patch/1124048/ > > > > >

Re: [EXT] Re: i2c: imx: support slave mode for imx I2C driver

2019-08-09 Thread Wolfram Sang
On Fri, Aug 09, 2019 at 03:18:01AM +, Biwen Li wrote: > > > The patch supports slave mode for imx I2C driver > > > > > > Signed-off-by: Biwen Li > > > > Wow, this is much simpler than the other approach flying around: > > > > http://patchwork.ozlabs.org/patch/1124048/ > > > > Can this one b

RE: [EXT] Re: i2c: imx: support slave mode for imx I2C driver

2019-08-08 Thread Biwen Li
> > Hi, > > On Thu, Aug 08, 2019 at 11:53:43AM +0800, Biwen Li wrote: > > The patch supports slave mode for imx I2C driver > > > > Signed-off-by: Biwen Li > > --- > > drivers/i2c/busses/i2c-imx.c | 199 > > --- > > 1 file changed, 185 insertions(+), 14 deletions(

RE: [EXT] Re: i2c: imx: support slave mode for imx I2C driver

2019-08-08 Thread Biwen Li
> > The patch supports slave mode for imx I2C driver > > > > Signed-off-by: Biwen Li > > Wow, this is much simpler than the other approach flying around: > > http://patchwork.ozlabs.org/patch/1124048/ > > Can this one be master and slave on the same bus, too? At the same time, the same bus is i

Re: i2c: imx: support slave mode for imx I2C driver

2019-08-08 Thread Wolfram Sang
On Thu, Aug 08, 2019 at 11:53:43AM +0800, Biwen Li wrote: > The patch supports slave mode for imx I2C driver > > Signed-off-by: Biwen Li Wow, this is much simpler than the other approach flying around: http://patchwork.ozlabs.org/patch/1124048/ Can this one be master and slave on the same bus,

Re: i2c: imx: support slave mode for imx I2C driver

2019-08-08 Thread Sascha Hauer
Hi, On Thu, Aug 08, 2019 at 11:53:43AM +0800, Biwen Li wrote: > The patch supports slave mode for imx I2C driver > > Signed-off-by: Biwen Li > --- > drivers/i2c/busses/i2c-imx.c | 199 --- > 1 file changed, 185 insertions(+), 14 deletions(-) > > diff --git a/dri

i2c: imx: support slave mode for imx I2C driver

2019-08-07 Thread Biwen Li
The patch supports slave mode for imx I2C driver Signed-off-by: Biwen Li --- drivers/i2c/busses/i2c-imx.c | 199 --- 1 file changed, 185 insertions(+), 14 deletions(-) diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index b1b8b938d7f4..f7