Re: factor out common s2ram wakeup code

2008-01-25 Thread H. Peter Anvin
Pavel Machek wrote: diff --git a/arch/x86/kernel/acpi/rm/wakemain.c b/arch/x86/kernel/acpi/rm/wakemain.c new file mode 100644 index 000..d3173cc --- /dev/null +++ b/arch/x86/kernel/acpi/rm/wakemain.c @@ -0,0 +1,18 @@ +#include "wakeup.h" +#include "boot.h" + +extern struct wakeup_header wake

Re: factor out common s2ram wakeup code

2008-01-25 Thread Pavel Machek
Hi! > Here is a patch which at least compiles (but doesn't link, since the > interface to the higher-level ACPI code needs to be adjusted). Thanks a lot! Here is patch that seems to work a bit... video settings are hardcoded at mode 6 for now.

Re: factor out common s2ram wakeup code

2008-01-23 Thread Rafael J. Wysocki
On Tuesday, 22 of January 2008, Pavel Machek wrote: > > It seems to compile 32/64bit, and work 32bit... It also works on a 64-bit system. Thanks, Rafael > --- > > Factor out common real-mode part of wakeup_{32,64}.S. > > Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> > > --- > commit 2fac

Re: factor out common s2ram wakeup code

2008-01-22 Thread H. Peter Anvin
Pavel Machek wrote: Shared structure would be okay, plus I need pointer to beggining and end of code so that I can copy it to lowmem. Pavel OK, that's easy. -hpa -- To unsubscribe from this list: send the line "unsubscri

Re: factor out common s2ram wakeup code

2008-01-22 Thread Pavel Machek
On Tue 2008-01-22 13:51:02, H. Peter Anvin wrote: > Pavel Machek wrote: >>> >>> The biggest question is if your 16-bit code needs to touch symbols in the >>> 32/64-bit code, or vice versa. That complicates things a little bit, >>> obviously. >> >> The code is in arch/x86/kernel/acpi/wakeup_32.S

Re: factor out common s2ram wakeup code

2008-01-22 Thread H. Peter Anvin
Pavel Machek wrote: The biggest question is if your 16-bit code needs to touch symbols in the 32/64-bit code, or vice versa. That complicates things a little bit, obviously. The code is in arch/x86/kernel/acpi/wakeup_32.S . acpi_copy_wakeup_routine needs to know offsets within 16-bit code.

Re: factor out common s2ram wakeup code

2008-01-22 Thread Pavel Machek
Hi! (Lists added back to CC, I dropped them by mistake). It seems to compile 32/64bit, and work 32bit... Now, video code should be probably shared with kernel/boot; but that was rewritten to C and I'm not sure if I know enough about linkers... basically the C code should repla

Re: factor out common s2ram wakeup code

2008-01-22 Thread H. Peter Anvin
Pavel Machek wrote: It seems to compile 32/64bit, and work 32bit... Now, video code should be probably shared with kernel/boot; but that was rewritten to C and I'm not sure if I know enough about linkers... basically the C code should replace mode_set() and friends. Peter, can you help? Yes, ab

factor out common s2ram wakeup code

2008-01-22 Thread Pavel Machek
It seems to compile 32/64bit, and work 32bit... Now, video code should be probably shared with kernel/boot; but that was rewritten to C and I'm not sure if I know enough about linkers... basically the C code should replace mode_set() and friends. Peter, can you help?