Re: drivers/base/core.c broken for non-CONFIG_HOTPLUG

2007-07-20 Thread Andrew Morton
On Fri, 20 Jul 2007 14:06:19 +0200 Kay Sievers <[EMAIL PROTECTED]> wrote: > On Fri, 2007-07-20 at 00:59 -0700, Andrew Morton wrote: > > On Fri, 20 Jul 2007 09:01:06 +0200 Robert Schwebel <[EMAIL PROTECTED]> > > wrote: > > > > > You add and use > > > > > > extern const char *kobject_actions[];

Re: drivers/base/core.c broken for non-CONFIG_HOTPLUG

2007-07-20 Thread Kay Sievers
On Fri, 2007-07-20 at 00:59 -0700, Andrew Morton wrote: > On Fri, 20 Jul 2007 09:01:06 +0200 Robert Schwebel <[EMAIL PROTECTED]> wrote: > > > You add and use > > > > extern const char *kobject_actions[]; > > Added it in a .c file, too. Even checkpatch.pl knows that > was wrong. The kernel

Re: drivers/base/core.c broken for non-CONFIG_HOTPLUG

2007-07-20 Thread Andrew Morton
On Fri, 20 Jul 2007 09:01:06 +0200 Robert Schwebel <[EMAIL PROTECTED]> wrote: > You add and use > > extern const char *kobject_actions[]; Added it in a .c file, too. Even checkpatch.pl knows that was wrong. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

drivers/base/core.c broken for non-CONFIG_HOTPLUG

2007-07-20 Thread Robert Schwebel
Kay, With commit 60a96a59569bab85571d0089682109bd3324e896, you broke drivers/base/core.c for systems which have not enabled CONFIG_HOTPLUG. You add and use extern const char *kobject_actions[]; but the code in lib/kobject_uevent.c who actually brings in the code is only compiled when CO

Re: drivers/base/core.c broken for non-CONFIG_HOTPLUG

2007-07-20 Thread Greg KH
On Fri, Jul 20, 2007 at 09:01:06AM +0200, Robert Schwebel wrote: > Kay, > > With commit 60a96a59569bab85571d0089682109bd3324e896, you broke > drivers/base/core.c for systems which have not enabled CONFIG_HOTPLUG. > > You add and use > > extern const char *kobject_actions[]; > > but the co