Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7

2016-06-15 Thread Joe Perches
On Thu, 2016-06-16 at 01:07 +0200, Wim Osterholt wrote: > On my first message I stated: > >  It looks to me that the code in floppy.c is quite old; no changes here. >  So the bug is elsewhere in the kernel. >   > That was because the changelog at the beginning of floppy.c ended in 2003. > Wouln't

Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7

2016-06-15 Thread Jiri Kosina
On Thu, 16 Jun 2016, Wim Osterholt wrote: > That was because the changelog at the beginning of floppy.c ended in 2003. > Wouln't it be wise to keep these items updated? Those things have only historical value these days. The real changelog has been kept in git (formerly bitkeeper) changelogs for

Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7

2016-06-15 Thread Wim Osterholt
On my first message I stated: It looks to me that the code in floppy.c is quite old; no changes here. So the bug is elsewhere in the kernel. That was because the changelog at the beginning of floppy.c ended in 2003. Wouln't it be wise to keep these items updated? Groeten, Wim. - w...@dj

Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7

2016-06-15 Thread Wim Osterholt
On Wed, Jun 15, 2016 at 04:13:53PM +0200, Jiri Kosina wrote: > > Wim, could you please test whether the patch below, applied on top of > vanilla kernel (i.e. drop the revert), everything you are using still > works as expected? > Applied on kernel-4.7-rc3 it looks like it's working. (Strace se

Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7

2016-06-15 Thread Jiri Kosina
On Wed, 15 Jun 2016, Al Viro wrote: > ioctl-only open. It's an old weird part of /dev/fd0 ABI Ah, right you are, I completely forgot about this gem. > and if you are playing with that driver, I am merely trying to keep it in a state that doesn't crash the system. > you'd better bother to ch

Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7

2016-06-15 Thread Al Viro
On Wed, Jun 15, 2016 at 09:09:13AM +0200, Jiri Kosina wrote: > On Tue, 14 Jun 2016, Wim Osterholt wrote: > > > Surprising or not, the thusly compiled kernel ran fine and I could > > handle floppies like before! (open(/dev/fd0,O_ACCMODE) succeeds.) > > Thanks for testing. > > Now next question -

Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7

2016-06-15 Thread Wim Osterholt
On Wed, Jun 15, 2016 at 09:09:13AM +0200, Jiri Kosina wrote: > > Surprising or not, the thusly compiled kernel ran fine and I could > > handle floppies like before! (open(/dev/fd0,O_ACCMODE) succeeds.) > > Thanks for testing. > > Now next question -- what do you actually want to achieve with pas

Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7

2016-06-15 Thread Jiri Kosina
On Tue, 14 Jun 2016, Wim Osterholt wrote: > Surprising or not, the thusly compiled kernel ran fine and I could > handle floppies like before! (open(/dev/fd0,O_ACCMODE) succeeds.) Thanks for testing. Now next question -- what do you actually want to achieve with passing O_ACCMODE to open()? O_

Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7

2016-06-14 Thread Al Viro
On Mon, Jun 13, 2016 at 02:15:15PM +0200, Jiri Kosina wrote: > Hmm, could you please test with 09954bad448 reverted? (although I don't > really have a good explanation currently how it'd be causing what you are > observing). I do, actually - ->f_mode on open(..., 3) contains neither FMODE_READ

Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7

2016-06-14 Thread Wim Osterholt
On Mon, Jun 13, 2016 at 02:15:15PM +0200, Jiri Kosina wrote: > > up to vanilla kernel 4.4.13 floppy functionality performs like it should. > > (On an x86 PC that is. With a 1.44MB diskette drive.) > > >From kernel 4.5* and up it changed to barely usable. > > > > After a virgin start (cold or warm

Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7

2016-06-13 Thread Jiri Kosina
On Sat, 11 Jun 2016, Wim Osterholt wrote: > > up to vanilla kernel 4.4.13 floppy functionality performs like it should. > (On an x86 PC that is. With a 1.44MB diskette drive.) > >From kernel 4.5* and up it changed to barely usable. > > After a virgin start (cold or warm boot) with an empty diske

Re: VFS regression ? Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7

2016-06-11 Thread Wim Osterholt
On Sat, Jun 11, 2016 at 02:15:01PM +0100, One Thousand Gnomes wrote: > > open(/dev/fd0, O_ACCMODE) = -1 > If you do > > touch foo > > then compile and run the following program does it error on the newer > kernel ? > > #include > #include > > int main(int argc, char *argv[]) > { > if (op

VFS regression ? Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7

2016-06-11 Thread One Thousand Gnomes
On Sat, 11 Jun 2016 01:02:55 +0200 Wim Osterholt wrote: > L.S. > > up to vanilla kernel 4.4.13 floppy functionality performs like it should. > (On an x86 PC that is. With a 1.44MB diskette drive.) > >From kernel 4.5* and up it changed to barely usable. > > After a virgin start (cold or warm b

disfunctional floppy driver in kernels 4.5, 4.6 and 4.7

2016-06-10 Thread Wim Osterholt
L.S. up to vanilla kernel 4.4.13 floppy functionality performs like it should. (On an x86 PC that is. With a 1.44MB diskette drive.) >From kernel 4.5* and up it changed to barely usable. After a virgin start (cold or warm boot) with an empty diskette drive and then loaded with a standard 720K dis